From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47A3A1A9B24 for ; Mon, 24 Aug 2026 01:41:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787535698; cv=none; b=SxH1saI3HVA+Ohv81sSNZU/53hmLJW+Rum6/KVds89vJ4f0Re7mPyo78FEmsTG+mhvi1Gvp3edvwsRt7kEAHQWMaVr4qObqmW0+tKG7QCK2UU41+wqcOFhljAQg+fwcaXcgF0Udrmj7FcJ4LdhajoBokhwOxQLXJgEMsWyZVNlo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787535698; c=relaxed/simple; bh=H10Ip/v2WwNa/9K84HicFmrsRHXPyUP1NserWBBgXQk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=huo/UW920WHfnSlAGpLvaYsnBeDE7kQ3D4GhYyJC3gx1CLkGc8vK1D1nT3NdEvySf4FMhx9QUnTPF9ulpkVs/2qCEAuJkDXmtev+hf5QrCXM8umiDKHeknQdOVE8vrCuc77jxaHwBPi9cYD7WfTYJ2nzZ88MhzQP8J+TIcqJvxg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pgUnUNJb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kNTweE6t; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pgUnUNJb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kNTweE6t" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67O0l3bH1344408 for ; Mon, 24 Aug 2026 01:41:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=5CT1DVv6oJp +278cP3iXlXVLmvw18dDcdc8XIOiLBVY=; b=pgUnUNJbh2qVpJYcJiC98YG3iZO kJYMSuv+C+SMAHH0QZOjNbUKmKWEkFZk4HBp5Ut48103RdChDjfoK39IkLGykw/i fFoT02EMlyzFvD2Gnd99IJWn4y9d1i8zceeRMtVNgq7+xjWVca51fCk2WG2ituXk ja7FYJetm84SfymI6XrykvRhq8RM4CBYOQOPxNak9XW6FwSUTr2ozquk86tUYVpX 0uD+7CtmWHYqlLCS8M4MA2TnDzJnH4bsRjK+L5Y9eDlM7rxG3vXSyR7j/OTroUnH jCmcz4lLw0CYtDDld8IMHsE5kWQvVbXCpuBb55vkH9CTkGvj4kJcLQi9YCg== Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g741qvx4c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Aug 2026 01:41:29 +0000 (GMT) Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-836c9f68dcbso49654467b3.0 for ; Sun, 23 Aug 2026 18:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787535689; x=1788140489; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5CT1DVv6oJp+278cP3iXlXVLmvw18dDcdc8XIOiLBVY=; b=kNTweE6tQSk3jc1fXyxWk3QJvTGZ+80Bp6zGils5nK1VrkxwL9vD7h0VgsE2G6/f3A v43Vu6dSQ84PkMbqDdTcGvw3uAEQwGcuGFdY/UwN7hzbfHYPuc5zHMZd9/MjJI1Z+SMi lrTJ0P4DAHP2oLeUeLdjd3TTzH7xM7iMU2lo+XGeX91oNPh1WdN/c1YB0kxH542Y3SyI aRE2Ws7tynvkqR0xKuY92TTYB63HgV3A6MDp4uXT2I/sR6+dGTMMQft9xA5rN/DUDtaF NPeztGmnZLdAC850v01KVp8acna/5mvM5mLuhYaO3A4ds93YSHmC+ZIAZl0VCjCJnyMY LmCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787535689; x=1788140489; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5CT1DVv6oJp+278cP3iXlXVLmvw18dDcdc8XIOiLBVY=; b=n7GjkPHa7AwXBSMnwKtCEO5Ob1ymLodFHKyxw4uinLG2FSZoJtZwa2AQq8WwUj2tMC LqbXViEuHuGXVZSwMt+H5Sn8821ptDs2VrUpAL100qbiyOypjVfQ2XzqSYOg+Jv39iu8 0BduICBHIPcfrd78qSEi4orluIeOH4IffHgijgqkwiyeVfuwEYFOFfLkufE716MZKut/ NB/YKRFh776lWsjV4PmGoaergmJdUqtBuyXoWpTnctCnBuAfbHVqvqoimN8V223zIPqB HhjYlZj/OSh9t9RYVYkMqDZ487ygg1gLgEYBZ0BfOZolADeg+e7MCGuTuaD7WPkFvcFd zsOw== X-Forwarded-Encrypted: i=1; AHgh+RpLCDpLLeM/vuCVaD6pgXj4TOScq6+Q+HuXio8fzpQZFdRN0MitVtQlyH4+Snb/vPIluhiDlHdBteeXOdU=@vger.kernel.org X-Gm-Message-State: AFuF++lbK6/TYZsjdwtomi3kl7jqaQ1Js9au1M2A0hk61AuOlWLYrqoo drkyA8NxFmv4ew5CyWb+bekUgjsUid5Iz6mlR6cSi4zi9+rg7n9RjpmJLJOF57XLZJeBOXrRQxN 7wj+i4cC9k1aapcUsRFDogvN44WcgQsH37JGnOEJG4e33Rdl3WuZkJ5inW8ZetKxO/K0= X-Gm-Gg: AR+sD12mgVfEM4sEOTLn2pkidpmcNhoAUOmR1IeSgospEmhytCxCRpfKLcaz05dwhqc FjOPi8WvqUPlPMwHPMzx/Xgk2PnDvS4glw1bReKZVGr28MNtdn+3788s1uifabkcCoTFfVsfNBC uzPl+V1b1T4CUUKxOqIbhpEt8dVvD/2M5WyvTmlFE4fIpw8CqUJCIjzagosOrpxoHHL57wQ+QVK 2NW8yO3/Bsyl2UcMlFBiDSkhAJpcB03GjAUQryt8UqyJ6a6JKJ5UPxM8tbtE1wdDnnVHrUsIRwm zapbnuPxZv0/QxJX9JqQq3JDafPYH4phpZ/H5k2rbVLCHsunj55HFQpPYIZJJAFV5MC8aaz0d7C y640Oq9cKqn8mJ2LpZTSzvjTGDTvSdzu9C7XkFPu80BE0vhq2Hg== X-Received: by 2002:a05:690c:9c0e:b0:81d:e7d2:a46d with SMTP id 00721157ae682-849eff488a2mr92669457b3.5.1787535689141; Sun, 23 Aug 2026 18:41:29 -0700 (PDT) X-Received: by 2002:a05:690c:9c0e:b0:81d:e7d2:a46d with SMTP id 00721157ae682-849eff488a2mr92669247b3.5.1787535688738; Sun, 23 Aug 2026 18:41:28 -0700 (PDT) Received: from agents-mac-mini.lan ([2600:1700:b450:a0df:b0fe:707a:f08c:6903]) by smtp.gmail.com with ESMTPSA id 00721157ae682-84cac00f57dsm25687587b3.40.2026.08.23.18.41.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 23 Aug 2026 18:41:28 -0700 (PDT) From: Jason Pettit To: Nabige Aala , Vinod Koul , Neil Armstrong , Wesley Cheng , Abel Vesa , Dmitry Baryshkov Cc: Jason Pettit , Ritesh Kumar , Mahadevan P , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: qualcomm: qmp-combo: update DP PHY PLL programming on Glymur Date: Sun, 23 Aug 2026 18:41:25 -0700 Message-ID: <20260824014125.2210-1-jason.pettit@oss.qualcomm.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260822142508.25473-1-jason.pettit@oss.qualcomm.com> References: <20260721-glymur-phy-conf-v1-1-7c8909552c5e@oss.qualcomm.com> <20260822142508.25473-1-jason.pettit@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI0MDAxMyBTYWx0ZWRfX5QU8td8PSOHR Uv/sTkexAbqFVDROwf/J6HK/cGi0g6tiOFSJtpTvefsBGpkzv8OzLWglUWq84Udg2Ltn34ng//P hrjdKXeXD7sKAl3heBIGgautHhzi/rsi8WsVySgGoRTofj0YnEQRTn0VCP+AI0kq4qdW2FBlcJI fknlDxlQepGpPVmRIzXWkDAsjqO3oNJPX5tn7hZbXDvVMa2xzhjZpDlLdv6j49zNAJQCnXpDmxL /fJZ4qACH9FkyOLaTuk+mUQw5WuXL9CuvXrNws0PZi/YgnHLh2f0IBWGlhNgi0Q38ohTwz2BrnK g746ZB5+9tKNIMWEMdZaw84MF2FbIBHkSwMgqbpxSpu//ogeoemDbJt/gWZNQEUNRm5ilpKzmlP E86I8U5GsZ+ePhljf9IdBuOrnDVscp1RCiYSo92jjcJ7/VHxewqlCTyvCkwlt5l2zCoFfAcWylZ DXd3X907e4P2By07xqw== X-Authority-Analysis: v=2.4 cv=GvNyPE1C c=1 sm=1 tr=0 ts=6a8ba149 cx=c_pps a=0mLRTIufkjop4KoA/9S1MA==:117 a=xqWC_Br6kY4A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=gJSUdyVw_5VDRsqcVNoA:9 a=WgItmB6HBUc_1uVUp3mg:22 X-Proofpoint-ORIG-GUID: aanii7CNBgTshkUiPRidovdJvEL2WAgu X-Proofpoint-Spam-Info: AW1haW4tMjYwODI0MDAxMyBTYWx0ZWRfX5TfyqyDZdVVZ EbgyUmVwm42AO7E3ldRhZxJOIk8RbJjmMKewsDkZujCHTDCXQjIXpzD4UTcAIqJDRQBZcG9E5fb x65adaRkP0jI4csBVc1uHgfLAaNCEoM= X-Proofpoint-GUID: aanii7CNBgTshkUiPRidovdJvEL2WAgu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-24_01,2026-08-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 adultscore=0 impostorscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608240013 Correcting myself. My earlier reply was wrong and I apologise for the noise. I said the include had "dp" and "qserdes" transposed. It does not. The file drivers/phy/qualcomm/phy-qcom-qmp-dp-qserdes-com-v8.h exists in v7.2 and the include was correct when this patch was posted on 21 July. I checked only current linux-next and drew the wrong conclusion. What actually changed is a later cleanup. 4b04c8779a50 ("phy: qcom-qmp: qserdes-com: drop duplicate v8 DP headers") authored 22 July, merged 7 August. It removed that header as a duplicate of phy-qcom-qmp-qserdes-dp-com-v8.h, reverting d10736db98d2. So the build break on current linux-next is a rebase consequence, not an error in the patch. The practical fix is unchanged. On a tree that has 4b04c8779a50, the include needs to become #include "phy-qcom-qmp-qserdes-dp-com-v8.h" which still supplies DP_QSERDES_V8_COM_C_READY_STATUS and DP_QSERDES_V8_COM_CMN_STATUS. The other point in my earlier reply stands. eca0e717aab1 ("phy: qualcomm: qmp-combo: Add support for Hawi SoC") added lines to the same include block on 3 August, so "git am -3" is needed to apply this cleanly. Sorry again for the misdiagnosis. Thanks, Jason