From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16D573793B0 for ; Mon, 24 Aug 2026 06:41:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787553663; cv=none; b=DQP9ytyq7IY7O7pbNE+FK1PtgsYg/S3LZXOMLF7eOPMobRnnRO85xSq5hgeNU2Q66RkRfu43mfLKcRI3kmvwSjO/jJX464Rn9VRBoF0DQRiVPLNGuJf0j2qtEMANpzH510aCkRXlo4RWxavIAPXLszUBCLUXOsTPNQVYzkzv0jU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787553663; c=relaxed/simple; bh=w5T/CpzZNH+Po6ctf9eekS1wGRE1YNhAce0uyJz4xn4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=liM8c9jh1IKgrxd4Jb1GUAbdI5rfInp4r8peIs/nvWXC5IscacbP5k4pCxAAWEo14H/I3ExiPldjPsQGjquIgKq40VehwyYDdXNj5oDQOgM0hTtXIEIiVkfTQDndPaZWLRtepZDa4wMycHp0QoOa4DoBpkyamZKrLyqrZLNOKqg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PiN9eQTf; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PiN9eQTf" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-6a173ad7cf4so5651860a12.3 for ; Sun, 23 Aug 2026 23:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787553660; x=1788158460; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=0gXhef06+kYUg6uksH6pZhR/nr5m3jbOk30lqsvuPnA=; b=PiN9eQTfSIQfYqOW09mF9Zxed9p3bYaFXHqeUz18Il0/3dXkCaewZ6z8u5JKEwb6Fo iHIWwL22zIMfY1nUHQlYdkTwOzSOqQ8Xi5MO4ihgzEYcoFJPrOvbDuB4kP3KIY0buNLW MyUjLl9UumIcU2O9bGOBYtnLF5L5ITF/+zCC2hngsEQvhhunmP1181LEzgsBY5DrpW8e YuW2PRJ72nwak0XFrxPA4crv+6PixDPbOP7ZvATx0gaRkYhXTK5OG/EmqO4lX5y1t2Vf b5cyGS8fD+1XaX+djAj/Dm8EANFw+Qfhu3C4qw6wcjg452R4qJ6O23YwCTodhMftKNqG 7ItA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787553660; x=1788158460; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0gXhef06+kYUg6uksH6pZhR/nr5m3jbOk30lqsvuPnA=; b=qed98LU8vZim2iWWRAmXT4AcOyYt8qVr3Mq8CRsYH6glP0yGmKbIifSMJnkX/sSCNU OM7dowI+s7qLo4ebNQIXBzY/NFry7A/9NeTP0lUlTXoQZBzCUAdDakpXAhhu54IONzwI pEj+yenqZeyiFlNGwV2bKO+5m1mL22ox1P7Brf3+N8C/WQu2O6bStvI5dpbMhKl4//JI EdBC++Mf49PB/lHKFHMYsMh1PqCUVL5vXVD4gvuqkWNo9gu3ic9kDc4xUxSYsHpZLybp 814igYoGPAqGF8KJc3mw9UT2bNcmVvOCpjlciPm9cLBckeuzrj2kpLy+VCQwCBjMu88l oclA== X-Forwarded-Encrypted: i=1; AHgh+Ronotl4VvuQYtfVkli4wB6vDyA30XjvijJe8BU3L27iIrAf0ANCF22wcuQqNGRr4svEM5LMhDAQ3N0OxZo=@vger.kernel.org X-Gm-Message-State: AFuF++nfK50+lnmMmqXaWFtEuS9RrI05Ty0oQDvJSxUurUpJ7yIcYro3 LSjSbBUuqeYLYqoHAZQgQD0cfJ2zXahoquPDCuZfpNNHERt5Mi/PnsJd X-Gm-Gg: AR+sD11Ut2jG1VaBfclqAYPS84xjurK8h340dzqMFvP52GrMgUeUsbHHKoIumZQYdVX EM2hhDSlDudkoj24G1kIETl9Ltuy+GNx/BJfvuo0aRGjk3JRIDumOjJw1iBt+LoM5hc2RzJJdi2 0nwTs8nu3LqYwkTrd4fu5qVJseo70akwXwLlYBDFyS2vLFveXA0ILaIQG6rtF6Oi63k8RGMyeO3 LnpurAaS3yjOGWJC3PW4qkqR6e7RbNjC9370qxFhedDg0N2XNavT1IpYkKcjdZH7dcBip/zFX1y Q+yeCQA9mdB2ifcN4SV1Iz3ab6eFRQPkylQTcqEAVfQPFAa1Iqswwauog+BbRB47M2jJnHUs2lX Pr5sWMrfWCZHJxPujIP6thf1sKfKYI6fgu6IUGjQSKWukbGSq/tjsDTdiTmrQNHZ4lE6kA7uBgq W31xsi8IS0UFlb3gapLQwSnpB+ajxiuc4xnwgJdwMyMprQkiedsKH32W0QwccwuUpuQ6+SMzcIa k3shq6kVmWZIC7D1vIE7/UeXRVnsxwjvcChIrLcyv2L7cMgV1dfzwmZkwlJWE6wFwNasoI6xvGL /mhym06BskL/QGs+E7EjNzREGTOwecoWUvYnas1vwGNe6zez0qgvR3obKqzy4jbT6DRee5L68oN j0T8osIQYNCeVbSR9rS+SVPSqYuOY3sPMp+FIUdCFSg5Jf928VCb5642C43t62hSNmC6OhQ== X-Received: by 2002:a05:6402:21db:b0:6a4:cc9:c8f0 with SMTP id 4fb4d7f45d1cf-6a582b052b3mr18432026a12.1.1787553660246; Sun, 23 Aug 2026 23:41:00 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a59e1c3003sm6885559a12.23.2026.08.23.23.40.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 23:41:00 -0700 (PDT) Date: Mon, 24 Aug 2026 08:40:41 +0200 From: Joshua Crofts To: Greg Kroah-Hartman , Heikki Krogerus Cc: Andy Shevchenko , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+6c7e68b141ebd3a2cadf@syzkaller.appspotmail.com Subject: Re: [PATCH] usb: typec: stusb160x: add missing NULL check for i2c_get_match_data() Message-ID: <20260824084041.0000295f@gmail.com> In-Reply-To: <20260806084301.1340-1-joshua.crofts1@gmail.com> References: <20260806084301.1340-1-joshua.crofts1@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 6 Aug 2026 08:43:01 +0000 Joshua Crofts wrote: > In stusb160x_probe(), the return value of i2c_get_match_data() is not > checked, causing a null pointer dereference later on if the device was > registered manually (without devicetree or ACPI). > > Fix this by adding a NULL check for the return value of > i2c_get_match_data(). > > Reported-by: syzbot+6c7e68b141ebd3a2cadf@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=6c7e68b141ebd3a2cadf > Fixes: 823754697556 ("usb: typec: stusb160x: Make use of i2c_get_match_data()") > Signed-off-by: Joshua Crofts > --- > drivers/usb/typec/stusb160x.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c > index 6d85b25b40bc..8f3435c669cd 100644 > --- a/drivers/usb/typec/stusb160x.c > +++ b/drivers/usb/typec/stusb160x.c > @@ -645,6 +645,8 @@ static int stusb160x_probe(struct i2c_client *client) > i2c_set_clientdata(client, chip); > > regmap_config = i2c_get_match_data(client); > + if (!regmap_config) > + return -ENODEV; > > chip->regmap = devm_regmap_init_i2c(client, regmap_config); > if (IS_ERR(chip->regmap)) { Hi Greg and Heikki, A (very) gentle ping on this patch. Do you need a v2 to include the Cc to stable? -- Kind regards, Joshua Crofts