From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+6c7e68b141ebd3a2cadf@syzkaller.appspotmail.com
Subject: Re: [PATCH] usb: typec: stusb160x: add missing NULL check for i2c_get_match_data()
Date: Mon, 24 Aug 2026 09:04:56 +0200 [thread overview]
Message-ID: <20260824090456.00006dba@gmail.com> (raw)
In-Reply-To: <aovpOp4QunPBx-XT@ashevche-desk.local>
On Mon, 24 Aug 2026 09:48:26 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Mon, Aug 24, 2026 at 08:40:41AM +0200, Joshua Crofts wrote:
> > On Thu, 6 Aug 2026 08:43:01 +0000
> > Joshua Crofts <joshua.crofts1@gmail.com> wrote:
>
> ...
>
> > > regmap_config = i2c_get_match_data(client);
> > > + if (!regmap_config)
> > > + return -ENODEV;
>
> Return -ENODATA here, it will distinguish better in case of debugging.
Yep, this was before our discussion about this in IIO :)
--
Kind regards,
Joshua Crofts
prev parent reply other threads:[~2026-08-24 7:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 8:43 Joshua Crofts
2026-08-06 8:47 ` Joshua Crofts
2026-08-24 6:40 ` Joshua Crofts
2026-08-24 6:45 ` Greg Kroah-Hartman
2026-08-24 6:48 ` Andy Shevchenko
2026-08-24 7:04 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260824090456.00006dba@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=syzbot+6c7e68b141ebd3a2cadf@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®