From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61A64403E88 for ; Mon, 24 Aug 2026 10:08:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787566132; cv=none; b=tsWZMvYY692mt1D2KAphpdJE7vobgRnOuSp0xW8FlXrNbczqgldVLVRGZqi5FdxZSV0oBfQPO9NlPVVS/caHgIL4Uu77ymfNDSfa5Na04SJZKe+w6YG/Oai77tIeL54GLe+rfRjqsqVBHHgRDq9SDsPQiSYbdr+b4dRUSMkwhww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787566132; c=relaxed/simple; bh=/JYatdn31meLcQd/D3tIjVAyB0LfgwUcuSDHoSPSPWw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZJ9cMW7IHPzwKNpcmxtzRt9qCzRGy/6JuedL+YdKkCc6qh35S/1v5wosnynffT4rktpigVd/Vqobre86mNqXtQA2b/xdIP2d2evLdSNKMvFj24T2Q9zLYpY67kBrJet79kgF3a8vj019y1ooK//IFS2CG0NbVOLqUsMDDbNxDis= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f5w5JPOl; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f5w5JPOl" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-cbedbaba5fdso1888358a12.0 for ; Mon, 24 Aug 2026 03:08:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787566130; x=1788170930; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=umgcoSfn5DzL6NaHAeud4eWB5u+3aTh8Dut0celLp8o=; b=f5w5JPOlGnhfiQS62NMkej/+s9kYgMeN3sO2+d6mkX2Me3NEMcAINlUnHrHjCVwvZl 6IYbbh4jlgsZayoAcuo6PBq2LElqr9bNhh547wg1kux6/w0fxb1SlUhErZrtvzEWxx8h +PnYXlZcofhQOb4pB8/DceAPRmOGF1d8rCT46rkuj6dAT/2kKQWRGebFRVXLfWBJnkEn HhLNKd/59Q70U6f5uRGj+0oK+67mrPb8AYNheE7LisgDu8rQ0AowMWe8gfGMbwifJbR5 iyQnhMpr0wXhfLwDzdo5kBxDBvgu7m1FsnShLo/j/FAr5eA+J5bdjoNf5KacjjWJubZ5 BLKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787566130; x=1788170930; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=umgcoSfn5DzL6NaHAeud4eWB5u+3aTh8Dut0celLp8o=; b=EFOM6atxxHYD6bssBPSaaYMZHAVsgzXusIHT7YNB80FeerBziyWUVPhke8F3KJCW2G cEC5b5V29vksT/FzvxcpvWAyCnbq23cDUoEkRVYVKy5q59ftobjESQ58KucgtqvKeFA9 80xTIw+9f0ubEM3NGZNvXaxUeLUooN7er+5K5VZsB04nmAlQI3P9YRk6axCXFayVy0mL xl18qpHgukC4NbyMUqfDBE3qLMuyJCy9+TRV63JO353oYg9K4Iiq5KJbn3iVy+kWrUcg nHg8AJTecNbJqwbjhcZagoESM5GM/Zp/h1xJJGwY5zecLILmX4Bs2K0OYOMv5AZxBRZw K+dA== X-Forwarded-Encrypted: i=1; AHgh+Rpq8TS4nhjYwyRqGBKNA33MRRGYhD06Qnven0AGKu1sPSABO4MUgMQqNZf7xzswYbAhot+Gw3dqY6ijJ/o=@vger.kernel.org X-Gm-Message-State: AFuF++muY5IGvvBCov+LlMaO2Tn7mvwwos4gFt4ZLB+6KyMqF36u71aV erzdAYE+EtaBsR82R5EYx4Jnm+JgWTPzXHZi0iQyLpHoDLeh5B5JBBbm X-Gm-Gg: AR+sD12Fbu74tc6Mxzjf1EnTjKEJ39ED6BGMGvTbCr+Y4aYgzJeywT2txm6nTwioWpg AB3cYvls/WVcbBfthkVjZruUQVomAe+OgEGcvCscfQVC3VUAk44tV3G/ykK2tE8ru92hJx50ma4 8N6+B8Yx7KcDr7xVus/48YJyKrf723envyXznAOivpSENEi7Y69URJsBTSjuhpuWrgMIbzJ+dk9 LC23PJky3D2pOp8lMU3nt+ahHc5jtGTvbT2darFx3kd1kukScSHbFFDC4WarTHCBlDf7YNac7y/ Lqr5oIf0b+c5zBFqmcpcWVdwqP4D7XglobTyno6YmUoCyguJl+OpadeSnZcO9ayMrs8eodCCcM+ +75LBnAz+UG6IDSZzNpBY0ZngWA0KbMNTMvomxZ8Fxt1vjPJ6otycytBZjiRqNBunYVy0XYT2Ih DRN41VimztcTcSyiNPks8ElyR/CCLA3cpAiUufsTHL0g1ASXsnp+SsHU2geuBiMwKIIaEa6LqzS qzLceGujXr11OTRPgbzHWSIcY09GOd8J+HZBs0uVKI6V0BEGNuSGGG2ij+H+rGGEYRlbwIvIN89 IGZA X-Received: by 2002:a05:6a21:a96:b0:3c3:954d:278d with SMTP id adf61e73a8af0-3cd3009cf0fmr18811755637.9.1787566129563; Mon, 24 Aug 2026 03:08:49 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc199dafa1fsm888828a12.3.2026.08.24.03.08.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 03:08:49 -0700 (PDT) From: phucduc.bui@gmail.com To: Wei Fang , Frank Li , Shenwei Wang Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , imx@lists.linux.dev, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bui duc phuc Subject: [PATCH net] net: fec: only stop PTP if it was initialized Date: Mon, 24 Aug 2026 17:08:34 +0700 Message-ID: <20260824100834.31655-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc fec_ptp_init() is only called when fep->bufdesc_ex is available. However, fec_probe() unconditionally calls fec_ptp_stop() on the failed_init path. Check fep->bufdesc_ex before calling fec_ptp_stop() to avoid stopping PTP when it was not initialized. Fixes: 32cba57ba74b ("net: fec: introduce fec_ptp_stop and use in probe fail path") Signed-off-by: bui duc phuc --- drivers/net/ethernet/freescale/fec_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index ced4dbf8cd90..7a87f40d12d9 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -5457,7 +5457,8 @@ fec_probe(struct platform_device *pdev) failed_irq: fec_enet_deinit(ndev); failed_init: - fec_ptp_stop(pdev); + if (fep->bufdesc_ex) + fec_ptp_stop(pdev); failed_reset: pm_runtime_put_noidle(&pdev->dev); pm_runtime_disable(&pdev->dev); -- 2.43.0