From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FC033F7882 for ; Mon, 24 Aug 2026 10:37:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787567843; cv=none; b=X9a4iYU4+zbeT7hZ3rGI4M41e3nmxZ/8j+To1Aga/4VMPI6PNEWhMgD5y7dBOE4P7Wvv1BaUkPYGBmH+DT4mFZhLdSQZyhwF6oe4YzVpfe3AiZy1i5eLNvqC4nWQMR6zbBxC0Bqb8oDfvoIzoooFQ07TMxbnOOcCFU/gmXd9jHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787567843; c=relaxed/simple; bh=J19TaZpjBFKFpKQddWptge89fLyuS77fbLqrx4LT1p8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VL7OsuSM0L0EjTKHxSkpzMEXqRbcfYWY872dE0oLktFmlQ4mQbK8YztTcfBBhYYMBxxGB9jh5cwZDaTEDY3DJVFuAziY2xoD7TgASXmXBa05naXxbWzsFhbzVjhwvMtuADSft2PFpVqU+J0qXqQTZ/zZ3ti4tr+xpRsnQdNyIc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rFzkTkvP; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rFzkTkvP" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-481595afa73so270846f8f.0 for ; Mon, 24 Aug 2026 03:37:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787567840; x=1788172640; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ZIXvGRqZDv1pZyUfC6Atrs4lIO+NNS5+uMrqd4f/BwE=; b=rFzkTkvPA3/EppNWkYBTKqpHBlE2APdLndcyISwev/m1pt39ZexLehOTNlKRFmtkDO Xgz0mqpnWwX1rkWr/PMm8kRLMGMVjYMp125u8OHqjDME92e/Q41e0R4XejAAXR1Duf+E aj2Up+sEMA1WATBaYonQQ2PgB1/kLbx+LFnUdBVjttt9uslWanoOEic9ueJ5NJqChH+j WJa8LoBlAjyWPHpFortvbAuk5vxw2y/3AXDjwHSjg9g9fpHMPzBZqxVaq+9KIiryKuM6 wgylsrgtqhwvybzWd68E3o36zVfqU6+VU0o6Fyv92ReN1NojKzzY5aRxZTN7YZe+MLI1 vSuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787567840; x=1788172640; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZIXvGRqZDv1pZyUfC6Atrs4lIO+NNS5+uMrqd4f/BwE=; b=Vsv/CtCkaWV/NSmag4lkpnVyjZVgq2YPATwzDHNzwqpVURmosmoh6M3BDQ13qyu+cO a5fceF5Yro2Q59WMcFv0gnZC2De1g+F79O7wqrxQxZe4fYt1xCrQpcVlDT1dYQ1WJaWA OL6FXmlTypbym1rxJ/1xPXaFP69BC55xtGEdj3DSHqLPLs+p9j5D6FoK/J3GxAFiJz4K 7w6HGkeF00Qt0pAXs69Gbm8AP2Vxd0BYNV4h2Hamj/75F6ldGekzvg7g29IyKNKZ1Duy TFQ/3Ow9Ov+9Btyn/JxWlvu8lezWuYQdrr6kkfdA/a1KDcJhe/wlGH12Uly156epwcMP kOgw== X-Forwarded-Encrypted: i=1; AHgh+RqGevv1XQB4xrs9/sZ3upSKISYaojKtPvDG5pVmpo8riTHeqFrdgL+q1SeT/4L0A+N9uslxZj2nAzrr3KA=@vger.kernel.org X-Gm-Message-State: AFuF++kAQHWT2AdUKEgUFP0l2FE7WP5yjiWNzShEzn/aPBeCMEp612W6 IV92xx8Vp+WgzvP/tv3hsLhvl8KUvtg4xRGE3ZSCyvKBCaDxGIDwxbY/ X-Gm-Gg: AR+sD12Ei3/HBwV84UcF+c23TYGm/jiNhcbqRbjmgufSrfedLLTR1/49owMwf8DCmgb bfBlWM0ulsOIruH6KDhH2uT4FEnTNpjeJ+YPgBQK1O7ikmLcKJFulKQA1xDwvuVjLrsEV7bAjY8 i/11VX3NAvt3VOxENLCoctMJCHtxZYHDF0lil9Lm84H0ZM9AHB63BCVNJyMsoARJL7TMmUJkEhK rzRuLuEm4c91SFHz4Yc3+bCmfk41tQuAx3M1AgdD+ghN4yM2uXTfAZy9rkQKq89q0mawrJ4+Snb ZULTKaBzSg0yPGDGTr9RCHwV5K00Vw2S9Wc+mRckTMLWFdsDEsFA9PSAPj92DG5TRHou9+iwJN3 sxvDDh38xuEYD3t+aYL8/qveriO/bLBBoYE9zsVMqAtwg9MSv0Tm+aIF45bzg8NnyUOCupHEuk4 ITHSDpLiunLx+fwL5ZAkAfcfabX4nkYxDd3V8oU/HAZIx27cjLGKLFQP5LQvgZ8Fsc6g== X-Received: by 2002:a05:600c:548c:b0:499:5b0f:72b with SMTP id 5b1f17b1804b1-499b835251emr145411275e9.1.1787567839702; Mon, 24 Aug 2026 03:37:19 -0700 (PDT) Received: from dkdwn-fedora ([2a01:e0a:354:c290:491:87c7:45df:9c03]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482c9bfcc31sm7675717f8f.17.2026.08.24.03.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 03:37:19 -0700 (PDT) From: Lucas Poupeau To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Lucas Subject: [PATCH] net: 8139too: use unaligned helpers when setting MAC address Date: Mon, 24 Aug 2026 12:37:09 +0200 Message-ID: <20260824103709.98373-1-lucasp.linux@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Lucas rtl8139_set_mac_address() accesses dev->dev_addr by casting it to u32 pointers. Besides potentially performing unaligned accesses, the second read starts at offset 4 and reads 32 bits even though only two bytes remain in the Ethernet address. Use get_unaligned_le32() and get_unaligned_le16() to read the address with the appropriate width and endianness. This also fixes the Sparse type warnings caused by passing __le32 values to iowrite32(). Signed-off-by: Lucas Poupeau --- drivers/net/ethernet/realtek/8139too.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/8139too.c b/drivers/net/ethernet/realtek/8139too.c index 8241bcf76664..1736599d7244 100644 --- a/drivers/net/ethernet/realtek/8139too.c +++ b/drivers/net/ethernet/realtek/8139too.c @@ -112,6 +112,7 @@ #include #include #include +#include /* Default Message level */ #define RTL8139_DEF_MSG_ENABLE (NETIF_MSG_DRV | \ @@ -2230,8 +2231,8 @@ static int rtl8139_set_mac_address(struct net_device *dev, void *p) spin_lock_irq(&tp->lock); RTL_W8_F(Cfg9346, Cfg9346_Unlock); - RTL_W32_F(MAC0 + 0, cpu_to_le32 (*(u32 *) (dev->dev_addr + 0))); - RTL_W32_F(MAC0 + 4, cpu_to_le32 (*(u32 *) (dev->dev_addr + 4))); + RTL_W32_F(MAC0 + 0, get_unaligned_le32(dev->dev_addr)); + RTL_W32_F(MAC0 + 4, get_unaligned_le16(dev->dev_addr + 4)); RTL_W8_F(Cfg9346, Cfg9346_Lock); spin_unlock_irq(&tp->lock); -- 2.55.0