From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86141374A11; Mon, 24 Aug 2026 10:47:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787568439; cv=none; b=jYs+EjrPWVObWbood5BgZt8bf4MmRJOHIm9Y6TKbvtGtOq6nhZJOk3L2EXIJiLomYtx3DcaOVRGt8569em3Fiv4xB4IQ4Fdi1NfBtKWS4isSKgeIaik70doExAC8BmedJDv05YWLK6r1nXdXHKUtkt1vRjuAmy8vPgtky0zCwOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787568439; c=relaxed/simple; bh=ueq6y2YG5GElD/3FAlklMHqkVzNrCvRg6FqkcjqVT9I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QdWyWzq2aD1cqa7NiyqDCjsWqHk/5lIlOZOyvmOnDGASmb5OupzSkf12XQXRp8K1De2duTISNV28paomsN09R/hRqjpUy01cLbw7TFF4MvJ6FnbIdhOQi48xkiMYaW4y/tCOZ8+/1ySge773sF03CH3kbT4GyIbHogZ3Q5DTYh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=M+3LRGpU; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="M+3LRGpU" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kecduTM8fiFYuvWS6sKsRPncX3hGJMO1Itmw2LG6ip8=; b=M+3LRGpUFk4ba7tgBBU9lsIbP3 cLF6gq3mIJCHOWQEj4LAPQCnbRm7gCOBgx43+hujsN/ApabtIgiePPz6ct6T2slyKmLa+36+TabgE gi0lP3mRt42I4txFes6KNc+T+cou0Z9lJNVwYuKYeZVZ0DCmvQAbyryfgJFN5BBE1D1nbgdNszsnr /e6yQeKfFb1znv4wLpCL1EvMzg6/Op4xO0u7bYhtmRNi7KsIvdVd6WZidQdYINT+UD3aFC4gYF8MD z9aizyJmkMcdCK+uxx/3Yiptqt7M8qdbMpr8bFMCUVPFc9clO3fmDal/G8v74L4Gw8G4vm866fZGU x/gWB2pA==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wySCn-000000055Sl-3LjI; Mon, 24 Aug 2026 10:47:06 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 5B7CE300244; Mon, 24 Aug 2026 12:47:04 +0200 (CEST) Date: Mon, 24 Aug 2026 12:47:04 +0200 From: Peter Zijlstra To: linux-kernel@vger.kernel.org Cc: linux-tip-commits@vger.kernel.org, Boqun Feng , x86@kernel.org, Thomas Gleixner Subject: Re: [tip: locking/core] locking: Switch to _irq_{disable,enable}() variants in cleanup guards Message-ID: <20260824104704.GA4121339@noisy.programming.kicks-ass.net> References: <20260804161447.84806-8-boqun@kernel.org> <178635226387.442315.3868294476114711805.tip-bot2@tip-bot2> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178635226387.442315.3868294476114711805.tip-bot2@tip-bot2> On Mon, Aug 10, 2026 at 08:57:43AM -0000, tip-bot2 for Boqun Feng wrote: > The following commit has been merged into the locking/core branch of tip: > > Commit-ID: 1b086687483371621e684e2a05b2bcd2cf07b634 > Gitweb: https://git.kernel.org/tip/1b086687483371621e684e2a05b2bcd2cf07b634 > Author: Boqun Feng > AuthorDate: Tue, 04 Aug 2026 09:14:29 -07:00 > Committer: Peter Zijlstra > CommitterDate: Mon, 10 Aug 2026 10:50:18 +02:00 > > locking: Switch to _irq_{disable,enable}() variants in cleanup guards > > The semantics of various IRQ disabling guards match what > *_irq_{disable,enable}() provide, i.e. the interrupt disabling is > properly nested, therefore it's OK to switch to use > *_irq_{disable,enable}() primitives. > > [boqun: Adjust the user-side changes in do_sched_cfs_*_timer() provided > by Peter and Lyude] > > Signed-off-by: Boqun Feng > Signed-off-by: Peter Zijlstra (Intel) > Link: https://patch.msgid.link/20260804161447.84806-8-boqun@kernel.org I'm going to revert this patch, the rest can stay, but this patch is broken vs existing code. Notably, the one found by syzbot is postix_timer_delete() doing spin_unlock_irq()+spin_lock_irq() inside a scoped_guard(spinlock_irq). We're going to need stronger tools/debug before trying this again.