From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7787C466AE6 for ; Mon, 24 Aug 2026 16:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787590786; cv=none; b=Vg/tGRw/RyX896+yakx+nkfTpzF4GmOkWINEiBukVqF7eeMffUHf7sACCqnXB06ceMsDQ9wjO+41MXiCXw6h83jPvNSutb7+DSamVeZ7DK5OnbhwCAo51paQ7qzXZQrnuNO3wDbEB/fvsjJFRN1IcDysfDdOk2NFCdbqNB4wNOg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787590786; c=relaxed/simple; bh=/thmYbLym9rw4GFAAIYXzFpUeGKHfH0osbsFj6XJivM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S/GZ3HPKUa9BwllnWZot3M8UynSqPWd3I0ec8JnM7dl5KhisAKazqWvbin32LuSPejN/5TJ/I1GfclcyCW66o7lYMrU46PgzMNyLHfd9GjG1bpgVLSj8BhLr9T//7yZKtbUn6LN4t54a32egLm4f5lcsKQGqjBWouyrC5PPgpRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Edu+Rne6; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Edu+Rne6" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-7f3b2c92428so1926849a34.0 for ; Mon, 24 Aug 2026 09:59:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787590784; x=1788195584; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MA9J/J4dz8CmMza6uNEHvAF2e5np5uw3UUGqTjXdZKA=; b=Edu+Rne65ynKWWNex+O7eVUK6MaNEUKrB1h0p4q8Fd8KT0HKoDAk6J+Su6KdVLKkPy 6qvqjm2eMskLkYxb+W+JzYExKrhfwxeP4vUFiZkxc4NuzhiikfuF57l4n1CxZM4Iey7g NqyDthrhT+pFnOuQ4XaB7zpZx54HPmOitwQ7c8zi8nEoycmTQO1T6rCKwtfgP8kEfM2x DzFE8BrNVCszbWD7n2iMjxZpcq3a8/y1INBbZ4VaCsx+kJl/pAxCIBm+t8ypXA2kx7h+ nnWgS4okiJV8qUe0Mko7KqTV8nWOrUBEwhosonG1FvQgMlVIPHyS+Z0DEHt2+M8u+XqP 8Cpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787590784; x=1788195584; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MA9J/J4dz8CmMza6uNEHvAF2e5np5uw3UUGqTjXdZKA=; b=MtWKjtanG+TM7yGAdTQVXZtkj6kTBA/vqf42ZnbRJxd5Tf3NW/MXoD06nuCAT/74HS 68oB2Ollzc6b+LDhHsJXFaCI64VueZmP9CCdbXeVuvwlvQ1U18bd5FCVQ9uXWDgC5lDI 5i2fQwVmB4u/CyjJ/iPxXtkey8fz/mo5l6cTGl3dhcZS8Vfcc0pHpxDi2zgPXE1N9tq0 nfLcRiZgSIDq0ZKRUHs+Zefvht4lFxhAvj67AVrtcXSwe7ws0nf0KnWQxjnC6tXQMoGQ pciqgx2VWcMHKBlv3Srkl9086q0QAsxWgEV5qS8WJJoIxQxc93O4Mmm1lpkHdErxqj/g ksKA== X-Forwarded-Encrypted: i=1; AHgh+RpL1vKotx6iUyt4jD6ybz6mzsE3H21oRVU7Gpz5IIl+ivHW1wPoVeji5cpIQwClquKYA+cxdfiWsmB4SS4=@vger.kernel.org X-Gm-Message-State: AFuF++nR/LD71atiGRaBu3EcaANNTjg410SZpHJ70P0WBJXyTAMEHc65 S1RdRWxPhmK3ZRAR2cst51OMdYaUKAe+fD7sC0SoX6Msni2WE4QFyobt X-Gm-Gg: AR+sD12cCHvoflmKB84CFrbvW/YoQxuRGCn/twCkgyjULO1Dm4CoD6EOC5tUid1p4KF SuZxcRUwy5IkjNEgY80N+W7nnEaNHDWueULjLbsYKlgKfTNU6lmeq5mhahfdMVtUxSrne+gjVR2 CyzIYcLUo+rlEhObWoggYsd/Y4xMYqf1KJ1QGkwSwhGCQzo88xxWEG0X4uCVrRLHvCuHSHotFIR AVGu7uLJYbBuek/giASDRbNrMw8VHNLGf5UVBNC42Hat+NH02nAmuy87FNunVW9X2qlHEPplJFo vpTSq7r3dpykBBuIYyiwzu8lDgl+vUxf9Lrfzva5CHUlzRhwPtW7qOZTI6zsDQ/9V23TVo/uZ0G fgg76oxAK2ChMVtsH5wq2J2Rw2hF/s0KY6FNKj79d5Wi3QheWx4RQTTP+4hu4J6wM8w38I8qmeH LF2p1Mdo8/mAa98Fa49dqByAg3qbIf50mYufwiRn2g5GQjnw0rsDeptdm1ZLzXrmPB5Do02VjjU HBsUN1bgfdf3D7nkKg= X-Received: by 2002:a05:6830:6187:b0:7e9:e257:81cb with SMTP id 46e09a7af769-7f461845b89mr33734265a34.7.1787590784236; Mon, 24 Aug 2026 09:59:44 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:2a::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f48fae8e1fsm4566560a34.1.2026.08.24.09.59.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 09:59:43 -0700 (PDT) From: Joshua Hahn To: Kaitao Cheng Cc: Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaitao Cheng , Joshua hahn Subject: Re: [PATCH] mm/hugetlb: use hugetlb_vmemmap_optimizable() in boolean contexts Date: Mon, 24 Aug 2026 09:59:40 -0700 Message-ID: <20260824165941.2354729-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260824151655.30840-1-kaitao.cheng@linux.dev> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, 24 Aug 2026 23:16:55 +0800 Kaitao Cheng wrote: > From: Kaitao Cheng > > The two boot-time sites in hugetlb_hstate_alloc_pages_onenode() and > hugetlb_pages_alloc_boot_node() only need to know whether HVO is > applicable, not the exact optimizable size. Switch them from > hugetlb_vmemmap_optimizable_size() to hugetlb_vmemmap_optimizable() > to make intent explicit. Hi Kaitao, thank you for the patch. I think the changes look good. hugetlb_vmemmap_optimizable is just a oneliner that checks hugetlb_vmemmap_optimizable_size != 0 anyways so this change seems clean with no side effects. Notably this leaves the only user of hugetlb_vmemmap_optimizable_size an inittimepr_info statement. Just thought I would note that here. Have a great day! Reviewed-by: Joshua hahn > No functional change intended. > > Signed-off-by: Kaitao Cheng > --- > mm/hugetlb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index a03a75fd7fa8..885f721999e6 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -3416,7 +3416,7 @@ static void __init hugetlb_hstate_alloc_pages_onenode(struct hstate *h, int nid) > folio = only_alloc_fresh_hugetlb_folio(h, gfp_mask, nid, > &node_states[N_MEMORY], NULL); > if (!folio && !list_empty(&folio_list) && > - hugetlb_vmemmap_optimizable_size(h)) { > + hugetlb_vmemmap_optimizable(h)) { > prep_and_add_allocated_folios(h, &folio_list); > INIT_LIST_HEAD(&folio_list); > folio = only_alloc_fresh_hugetlb_folio(h, gfp_mask, nid, > @@ -3485,7 +3485,7 @@ static void __init hugetlb_pages_alloc_boot_node(unsigned long start, unsigned l > for (i = 0; i < num; ++i) { > struct folio *folio; > > - if (hugetlb_vmemmap_optimizable_size(h) && > + if (hugetlb_vmemmap_optimizable(h) && > (si_mem_available() == 0) && !list_empty(&folio_list)) { > prep_and_add_allocated_folios(h, &folio_list); > INIT_LIST_HEAD(&folio_list); > -- > 2.50.1 (Apple Git-155) > >