From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C385A3803E1 for ; Mon, 24 Aug 2026 17:51:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787593870; cv=none; b=Em6jBASId3VMahWiA3rBjfzgufa1P8tR5f42sscY3zbDYd2ffsjh7WWh2P6cC1yXOIlDJE0co+4OfbJYvA+i/XfSoYhpzzhDj5TTR9I6v/nHI95zs7/H3WVlmbYYN/prb4MvJp36a1BKFGx+jweaOubCjRireXwFKIJPxH/QU90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787593870; c=relaxed/simple; bh=VylVE97urOnGo1fKhA1IwM8dNjVc6rVPycHxhapEvGA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pC+khD0a8sBvxepIRkbtsLfE0ZDJtOmXYrMs8Tje8kHqCn1dk5nlBNeoCEEXki9AakJojdgN8R0c55ECW/4jGK4Bdq7NA87G41BuTP+7KY+kaVDye+mv5sT4HwTQ/U4gTyRKyhhn4mS1Yeprjf1w/k8DqECqgcuKKnyvneBkwmo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VZNEHqdq; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VZNEHqdq" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-395ea741d07so1665598a91.1 for ; Mon, 24 Aug 2026 10:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787593867; x=1788198667; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5mP6wFrKPhYjd/5KHULwyWUdonzv0xy3jN9195/5g2U=; b=VZNEHqdqh73dRJ90JBI/k7ctacPrY2CRjheyuT18bHhSF8WwaPi/E9UAMg63NnjK+h R10VcO/NvmDIaFafquDJQJcC21crhJG12B2+r6F3iKESkA1Tvo1v4ykiswng+vkvMUJF hXJpZr075UN0KQGDyEkgu9qhtl4UlBfxno5PO08Rk5TZUuGPqyhh2MB2700umXN+/iDZ qEJ48N+qzCOW7/Lc+DPpOmK8zutSee9Q+m5Rl1K8hdSr3Re2BbQqdfiNS/rx7RmEb4S9 zczrXZKg4sjyolnfL7nGkVt1d5aFlFVVMkO/xPFKnkdPZ/da7bAhhQlNctP40DKsGiko VM9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787593867; x=1788198667; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5mP6wFrKPhYjd/5KHULwyWUdonzv0xy3jN9195/5g2U=; b=R71/m9Q6VoX6J2w9oHXE45gNb/fUwmMSjst+3mWgNJsNYtk3DrJCwsH2S6RXhgWmqP QRBWNPpUZdAZ0RwVXoa8tO085kyWmjK4Eq3Uhsdrc4+wHP4hCayoWGOPi7/XOgPdbSur /u0+PTL2p7KfP195aas3rOtNjGy4CemMsf2AIKArDkpXuxsQxI+05ig4A4zKe2NAj5ZT nqp7RVckR/qwmSqiT42fOzrqyis5JrgbbWf/O0KVoT00BSR/o3xkJfSo6xVIxcjq8U8F oBbpCzlQqwJkFnuph/M5imaavg7AgrdTu6nqOZSAj4pqhUlkfU87tp9+saNYZ97aywWY 1o2Q== X-Forwarded-Encrypted: i=1; AHgh+RquwITbWounUka4k4pxrLedjqYbyVZ4k9AAecEeBtuQXucQJZiV97s+YrbmH01Fju2yltJeeWX9t04eQAc=@vger.kernel.org X-Gm-Message-State: AFuF++lZNo6Ydn6gOU1JcpTGTbqsqz26uX0t2oRMN7EaRODZvD1XkvOn VZg/LdWwCYhazexiPNo5wP+pqmZhIPKkq5qsGR1GUTzZT4X4YS++Ed/H X-Gm-Gg: AR+sD13BLg+tfQA/ItOFd36s1ggc/jel+rCVunk+LkUg7w9dgWZMhDLCBQ+QKHwFLiU 1iKqz6glihOn2LdzklnGe8DMFD1ruB0GHLBkZUXYK0VP0F+BNXefX10wxaMEn5ETYNH3wG7dFwf VsJ1JRsoqQnQMna2sjwFOm4cj+phBYRLUJ9kyMJd5aw4QIOFOC/lGrHbBh/hMsn29ZzMkvYY+pN IdeMihHFf8nzfQyuzz8OU7fAK2eXUH9jYuvgY2+lq1xiBWvkGnOHaNS5tZNC3jisJT4nFXLO0Qp 5yigKTUml5T+lp73VsuVuHUFjN84JWrLxYOyP+VlYWFAAgEgWVhhOxh+0c7v1FwO9QPRk+iHIVA ZIlOQ+Ik5EcaC8dKhn5v+IQgWvEOpUnzGrAmQ4hLSL1ZGPR//iTgjfqOPdsnnaWc7IpzRaVxrfm Qcj79VTaE5YjusiT9+uTp+9tv1EeOIE2aZp7imHicTRx4pYOkOwpp8h/ZGcIoax6d5zTA= X-Received: by 2002:a17:90b:4986:b0:38e:e9b:ffa4 with SMTP id 98e67ed59e1d1-395c33cf295mr51309257a91.6.1787593867050; Mon, 24 Aug 2026 10:51:07 -0700 (PDT) Received: from localhost ([2620:10d:c090:500::4:ddd2]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141861732f8sm26815132c88.10.2026.08.24.10.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 10:51:06 -0700 (PDT) From: Zinc Lim To: Alexander Duyck , Jakub Kicinski , Andrew Lunn , "David S . Miller" , Eric Dumazet , Paolo Abeni , Guenter Roeck , Simon Horman , Mohsin Bashir Cc: kernel-team@meta.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, zinclim@meta.com, Zinc Lim Subject: [PATCH net-next v2 2/6] eth: fbnic: expose all hwmon attributes unconditionally as read-only Date: Mon, 24 Aug 2026 10:50:55 -0700 Message-ID: <20260824175059.2485048-3-limzhineng2@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260824175059.2485048-1-limzhineng2@gmail.com> References: <20260824175059.2485048-1-limzhineng2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit All fbnic hwmon attributes are read-only and always present, so fbnic_hwmon_is_visible() can simply return 0444 for everything instead of matching on the sensor type and attribute. This also prepares for the threshold and alarm attributes added in the following patches: they are exposed unconditionally and reads return attribute values. Signed-off-by: Zinc Lim --- drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c b/drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c index 6c8c66ab86c1..38bb26cb8e6c 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c @@ -20,12 +20,7 @@ static umode_t fbnic_hwmon_is_visible(const void *drvdata, enum hwmon_sensor_types type, u32 attr, int channel) { - if (type == hwmon_temp && attr == hwmon_temp_input) - return 0444; - if (type == hwmon_in && attr == hwmon_in_input) - return 0444; - - return 0; + return 0444; } static int fbnic_hwmon_sensor_read(struct fbnic_dev *fbd, int id, long *val) -- 2.53.0-Meta