From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98F27370AFD for ; Mon, 24 Aug 2026 18:11:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787595111; cv=none; b=FKLqGJNfoqatAdANEcHlHeNq7vJOYItRqFiSr6g1qjw9aQXvVOcAbpb9IN21TTkOgghIrrEPeoEmbaOIdPZid3Uq2xI9oIZ5zdo0+hb9BnAWzqxQQrhn9mTh54/Iu7EkZGHxjsVBeyddx7WabP+sHT/roXLCfA0QESE9STu3gnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787595111; c=relaxed/simple; bh=MDZe9E4t93ZKZ9CWIn3OeWSjkVfP/QNe+b5AN8xnqb0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=p5eBtF3gTVW2b6Pv+PRT2H0jFygwqeXNAUxsHrbjnwXBE8lDoXfvQuNe0E8PgkH6I20AWjHiqGKnZONH4fQJSabW8NhcOQ4yavf8LeQKz3U+HBMok/baPqPdcR0RbUzRXwsExIKf7/RPS6IoZoIHjPeJQmz+AMT940+0t5coCNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M5StIGEa; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M5StIGEa" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-6a422090b2fso5620305a12.0 for ; Mon, 24 Aug 2026 11:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787595108; x=1788199908; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=SBNJ14VCdpFgw4LDjCoQmNNZfTNO5gFu+ceu/TNn3/w=; b=M5StIGEaCBb611lwUFIjuq5EivPyA1PGjC1RQs0bSJYDGk5JPellOt2VVT8jEHCgX/ VRWkQfztIegIRMQqGaBd7cr6c2cQlhGg8rwZpGnZDfgoglJS3NmheHOzdnKQ0T6oubgt wDUK2P53gqxUV9EKfKsUMF3BWBoG4DnDivB/xCbBzJlGlWrNsFpdgYjvoJz8VTncwKmV H+hRcZoUUCTsJnIFnkRoyFYSHJfeMskPEQuGKBIf/7Hj+M3wQNAUsWWMV7gEygbxpuPI F2kZflxIsNorM5VfRmhD/sa+MCQbnCOs/jAJ/XZzh1kLupBXMvCLu2stGr2nM1381YbP MFeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787595108; x=1788199908; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SBNJ14VCdpFgw4LDjCoQmNNZfTNO5gFu+ceu/TNn3/w=; b=D7kpTfiQtIKVIRcsOr+lXEFhbzrDLEJTOVYp3EaHZkRefVMBVChZlLMhKmEvUqK7SG Gvm6l67Rj6VwJDFcJEvQPNoktcW4PqYl/Ayt3t7iKr0Dmq2hTxkXyIiv/VQTpoTBXCbB RCO4cCoVqnRakJcqzWzd81efYwrCj4VTvP0rOF/gVDWn4qIxT2tYJJvXrO5ySxM3KtgM kCTBM7hreuHCLzRp8DBgtEmX3ugC232da0hUoltih3axEFZ4mzpQCob2yTKGwZXPMZ3Q AlpALzptIAauAGBQYOIp6lNC42F8j2RULHmNZa5EMlpKrv+nwMt1RNVqY9XOAXKz7rUs qGSQ== X-Forwarded-Encrypted: i=1; AHgh+Rpfg7p+LBBhQnBdB4Ca5Gsio50lTO9mbpd/sjqLHxV1uPjL1zV2a89zeNXyvgIZDSXqhX+0Z7vuWqxRDvs=@vger.kernel.org X-Gm-Message-State: AFuF++lY/HVBbpxsr0FEderr4yHrlDvNodmtMB2Mqtw1zPtg320EpYGW kB/Vzz7eh3pFfgGPDeG/CilnPO7sIkCky9CvebVre9hQU4n26umYsQHi X-Gm-Gg: AR+sD13KKwxTpRXY58g/Gh5ZUyBGilBdv4U+U7snv4bHAKG91qFeaz8INsAOX7H7YNC Z2tFYcxi3G5H16XMYOTHjJjjhgzqRz2NYVz/2/OEZoBpgtlhO6vnjtQumRAg0JngCgamCkmIrY+ P/Gj8T5UsgzV+h3U2PJ4w5PWPsMWKUrWtogOc5CRPzG7qlq5QxycYl4t25ABd2F2vjiCEzFjk6y E6vI8tDF9p6i54Nvpd0oJzxlkQ6OkrU+rzFq99jdWGu/6dPaEtlyhmC5uwlmTvlgDoxqlwEa+Vw 1vNJA65zUQK0kmugqqLaN6Q4SxBd+B9F6jaEiuekXnQ+EVdAjeS11oghD6wkQH7s8MMdObWX7RA /YQmij6j39JnMjE311xLNQUzdavRvF/xFRGjWHVbhn1UPULi9nn+4DFVvoMbCi/tE3X/Trej1Hw TuO8aromPKzi0yazweziQHfeANQkiqILNnF/5eiLDzkFzHdoLk0XDZGA3uW4DG72PY7athwGedQ B660bOu6pwWqZjULHiDBy3fBxTb2rY= X-Received: by 2002:a05:6402:510d:b0:69f:d4b7:9476 with SMTP id 4fb4d7f45d1cf-6a5c40f286amr448135a12.4.1787595107634; Mon, 24 Aug 2026 11:11:47 -0700 (PDT) Received: from buildhost.darklands.se ([2001:9b1:ff:d701:51eb:176f:63d9:53f8]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a59dd550bcsm10586910a12.0.2026.08.24.11.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 11:11:47 -0700 (PDT) From: Magnus Lindholm To: richard.henderson@linaro.org, mattst88@gmail.com, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org Cc: Magnus Lindholm Subject: [PATCH v2 0/2] alpha: disable DAC for 32-bit PCI cards on Tsunami/Typhoon Date: Mon, 24 Aug 2026 19:36:52 +0200 Message-ID: <20260824181126.3559638-1-linmag7@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is a follow-up to a patch I posted last year (Sep 2025, "[PATCH 0/1] alpha: disable DAC for 32-bit PCI on tsunami"), which was not merged. Changes since v1: - Split into two patches: generic bus_dma_limit plumbing (1/2) and the Tsunami policy itself (2/2). - Rebased onto current mainline (pci_iommu.c's DMA-mapping API moved from map_page()/virtual addresses to map_phys()/phys_addr_t - bus_dma_limit is now treated as a numeric address ceiling rather than a bitmask: the DAC path in pci_map_single_1()/sg_fill() is bound-checked against it directly, instead of folding it into the DAC capability test in pci_dac_dma_supported() (which is otherwise unchanged). Fixed a NULL-pointer dereference this exposed on no-IOMMU machines once that bound check could fail. - Use ST_DEC_TSUNAMI instead of the raw sys_type value 34. Boot tested on an AlphaServer ES40 (Tsunami) with a QLogic ISP1040B controller. Original background, still accurate: I've spent quite some time trying to make the qla1280 driver work with 64-bit DMA on Alpha/Tsunami systems with more than 2GB RAM. Many thanks to Martin, James, Maciej, Thomas and Christoph who took the time to provide feedback and testing during my attempts. This is what I've concluded: * The ISP1040B (32-bit card) works with a 64-bit DMA mask on a 21164 Rawhide machine - the card itself supports DAC, even though the data sheet doesn't officially claim support until rev C (as Thomas Bogendoerfer pointed out earlier). * The ISP1080 (64-bit PCI slot/card) works with a 64-bit DMA mask on a 21264 Tsunami machine - so the monster window itself works fine on Tsunami. * Data gets corrupted on Alpha/Tsunami specifically when DAC/monster window is used by a 32-bit PCI card. The amount corrupted varies a lot between runs, from none at all to several kilobytes out of 20MB transferred. When it happens, it's always in 64-byte chunks, which coincides with the 21264's cache block size. Manual inspection of the corrupted data shows it's memory content from other active processes doing DMA on other drives/controllers at the time. The fix is unchanged from the original posting: limit 32-bit PCI cards from using DAC/monster window DMA on Tsunami based Alphas, by setting bus_dma_limit to DMA_BIT_MASK(32) for devices that have no 64-bit memory BAR. There are 64-bit PCI cards that only have 32-bit memory BARs, like the QLogic ISP1080 and ISP10160 SCSI controllers; these will be needlessly constrained even though they work correctly on Tsunami. I believe this is an acceptable trade-off, since those controllers are not known to be supported by SRM firmware and are therefore uncommon on Alpha systems. In practice there are very few 32-bit PCI cards likely to be used on Alpha with drivers that request 64-bit DMA addressing. The only example I've found is the qla1280 driver with an ISP1040 controller, which is supported by most SRM firmware versions and hence fairly common on Alpha systems. Magnus Lindholm (2): alpha: respect dev->bus_dma_limit as the effective DMA address ceiling alpha: disable DAC for 32-bit PCI cards on Tsunami/Typhoon arch/alpha/kernel/pci.c | 22 ++++++++++++++++++++++ arch/alpha/kernel/pci_iommu.c | 22 ++++++++++++++++------ 2 files changed, 38 insertions(+), 6 deletions(-) -- 2.53.0