From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8824E38643B for ; Mon, 24 Aug 2026 18:39:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787596753; cv=none; b=g/94W1+DhVMsI597DFLHsVFZe2N7NuKtfrOdvRgoN4EX8GW3h1XsMQFDS7Yh+p6SUE4SzaXNhMNidvguo6DSPoOTA/gCT6ZMHtvI32JLNueb0xWRdZkez856gMQsLST6/J6HREKGASrKrtYgWg8w4HK9AgopzYklsTadeBQy3Og= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787596753; c=relaxed/simple; bh=3zTrUNP97wjygcEyxUmUMs4ernWyBlapMobTCcEOsLo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LqPOT7XmfnkQMEWh7oydyiKxlfPbLhl2OL3xZMBIFh6ga6r8x9qpJe0KsTPodpG8XnZ/ihiJgi9aiPT92Ez5XyF/eFC5pedxeEGfAww35/wmIHBnkqN6AZFYKWNB9tVsgZ31hZis7iqT1X/eD00H9q/lu4oqHz7qOiYUEndnFVo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kBn/OwzN; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kBn/OwzN" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-c169ae1cb26so38265966b.1 for ; Mon, 24 Aug 2026 11:39:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787596750; x=1788201550; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yNGuRramHsyQedVrqROIzZg6iP7sI/lSPknDcuWVUUc=; b=kBn/OwzNF6zi/8HqX9mV/gBhhauV13H/WoF2Iuv+BkB4dlX1/koXfELDN4jLW0kh1j u4PKFDVwRRwr0CaJnEjiSj8SNBi/X+zypXZv0VeVu3we2gEp30TiPd8cXCL2lPuDG7VV ZdWuxPa3D4c1/gzjpb2eK2Mk+2fo7cbJI06Ewk3jCeO3lDyv8Vaw1zl+MYEDLviHVj15 Hd8ozAll0M/YiDvuj6Sjue6PztWkumvy2uLB/GDEAm5KWKDnlxrmcwd5enpbxJRxEpyq 3IJoF19XQsLA5ksPAF7de1GyEx8lwTITQVMu4ISUOacWXF1SxMPjfqWho8Suwtck7M5c QGMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787596750; x=1788201550; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=yNGuRramHsyQedVrqROIzZg6iP7sI/lSPknDcuWVUUc=; b=Dz81eF3gx/Ta74QurCNmJl/UWMGEbYotCaFTlnd6sNAXmCRgvKaxyPqV4rL4Dq0mjy dz18AufDBmbQzWcf1ZbJR+NQVKS+qzA8gUPe46rzWeg6H2oBoa8xEv2ga/9wrEr4AeEl Ot2p/ra/HSyUWAklhd45yiarHANXbQgp/3JNyNlPV1FtutSUCc7g4tMriMTfjTQWRRNG Dtb3MHqhSTFwEcE3TJSyNencRXgIvFYfsMV54efzZ8DikbzxP/rgTjLpw4u/ILoKhxYd tcggD74xFWc+tYxvhjm4IZaKocdEdMeFfW807X4xkdoaCH8ZG/m6mRDqxMMcBZf8/NFu Uv6A== X-Forwarded-Encrypted: i=1; AHgh+RoNeb3RJTxU7JcGXtNR/y5ZtoREHugy/Z6x83ByosJh0wlDURuMffAcDZDjlIX3n0tjuRxamWlOkfMLv2Y=@vger.kernel.org X-Gm-Message-State: AFuF++k9qSIpF3r8KnG+i8K5ovkBlEelStiEeCI0lCQsZER4iLMACUI3 R4q2QIWg8SMSACsQDS+spkozEX6ENNTiEr1TnPPVkXsZqlNlkVbykH8Y X-Gm-Gg: AR+sD11HqpYjBPAx6KMnb3qpzPog665ie4zU3WTKhKEEDFuc0lhcQq0eQ5FoAKDUkNx +/DTjsdM848h0aKgpRKtcpPtHjVc99VYaJu0sRyveLkzJUd0I9ga/wdvW21P+HgDFXSKWwF5BGX zYG3JtnppqcZ04K7apNlQyfgFEDeM4B/YHJBlIFWf5Egl5KREbHrZN5vJZrTh3o3xE9DtBjR9k4 +gzBTwxK0mfRLURItv5LLy3NT8zNSwgtVu/plj4WfhqyOaiCpwtsTylW8PNWZzb9hEmIvBvVKIU xBUWO0xoJQyHXL60Lml8AS1DjgvH5B/wSQ6fdRe0VWrOyZxPy3usMgzBpb3rCZq7fwukzv6TbX+ FX/oJIrHrmdH/Nq0qaY8e3CAH70wyvKhGA8Wfpg8FePYH4e8WNq4FOCAMNi8rZ732eikj4I76K2 q4M/ujqhhYsXAFPXlYB75L6mv+vkhpypALjAIvUCzAKBhURBtqDdc9VE9r6SvuKs9Vn4SqX/Hm+ YG1yaOn6Gq3XVOISVg32in4wL5p406jZz7VldTRN9oQRg== X-Received: by 2002:a17:906:794f:b0:c1c:4c72:e6df with SMTP id a640c23a62f3a-c24e2860886mr95058966b.0.1787596749638; Mon, 24 Aug 2026 11:39:09 -0700 (PDT) Received: from flaviu-Aspire-E5-572G.. ([2a02:2f08:440b:2900:8e59:1937:8c58:aeb6]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c249673d43bsm1307499266b.47.2026.08.24.11.39.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 11:39:09 -0700 (PDT) From: Flaviu Nistor To: Guenter Roeck , Jean Delvare , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Flaviu Nistor , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 2/2] hwmon: (lm90) Reject channel 2 on chips with only one remote sensor Date: Mon, 24 Aug 2026 21:39:00 +0300 Message-ID: <20260824183900.8983-3-flaviu.nistor@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260824183900.8983-1-flaviu.nistor@gmail.com> References: <20260824183900.8983-1-flaviu.nistor@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Validate firmware channel definitions against chip capabilities and return -EINVAL when channel 2 is configured on devices with 1 remote channel. Signed-off-by: Flaviu Nistor --- drivers/hwmon/lm90.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c index 1c603272538a..3faeb2c6ab01 100644 --- a/drivers/hwmon/lm90.c +++ b/drivers/hwmon/lm90.c @@ -2712,6 +2712,11 @@ static int lm90_probe_channel(struct i2c_client *client, return -EINVAL; } + if (id == 2 && !(data->flags & LM90_HAVE_TEMP3)) { + dev_err(dev, "channel %d is not supported for this chip in %pfw\n", id, child); + return -EINVAL; + } + err = fwnode_property_read_string(child, "label", &data->channel_label[id]); if (err == -ENODATA || err == -EILSEQ) { dev_err(dev, "invalid label property in %pfw\n", child); -- 2.34.1