From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FEA4386559 for ; Mon, 24 Aug 2026 18:42:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787596935; cv=none; b=YSBH+ONxXkk1cp9pp72uUdxH7sJ59pEK4XaDp98yk0A1gF2BkCqcDP16+sioWK7ovTYgHxX8VTg7s9w6rVV9bGmMwi2vg8UdhHDvtMSZ/55e3krtpRHlhRld3t1/o1ugIxI7MZNt1U31wA76bg3uWwnXXQw6uWw+j7ICMlnGZC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787596935; c=relaxed/simple; bh=PjYmrfLVvUBP+hJPWHcHP1Yl0S8esm3P4bwPD1D8xIQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JVTySkdqBlFxXiO2Ty00n2JulfzdP5QxSbJTXNYTe2pfbCsDczPhkFuNVWc2JAuopQGV7TM25oQnUFsBgQgBL2R0EqBJgNAuFG4GwZM0M/t77tYuv9QK5Okxv4lt/AkeEkCtNbcg50C9NgoJRnKW8bq2fSEbjescBW5QvolOrM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ionos.com; spf=pass smtp.mailfrom=ionos.com; dkim=pass (2048-bit key) header.d=ionos.com header.i=@ionos.com header.b=CK5tgKsE; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ionos.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ionos.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ionos.com header.i=@ionos.com header.b="CK5tgKsE" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-c247f6687dcso448543266b.2 for ; Mon, 24 Aug 2026 11:42:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; t=1787596932; x=1788201732; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZMHV6Hk2N+WQQfLCucQHiHvg+yo3kZaqddjw6yoje2M=; b=CK5tgKsECcRrb3gxRmOkVe9ja80HUiUDOU+grMIZ6B72UQ+lXokGcWwCHJk7V6SwoM n8j1yNeB43MuvoIMryTtXIKyKTE7h8JM38SNQpvp4GOzkTtz2Jz/MNwX1CAZFQS8+yF1 N7RusOkToi+XIPXCHcEjcMbjcYNnuWYC9HQHglF0vhiV40dEcxhuhd9bogYIvPipCHV1 v5Kd30LoRfemgpRZq6S7PDmp0SWUUIM5W7ZayKseMHIOKe1U/rFCXKuPobok/EGYIzvq iJBSnPpVLCAgT9se5OAA0R5CVuQd2ALobBc7jRdr+sHx9+ge9TrWHDl49yVZjfHrKGMD 7eYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787596932; x=1788201732; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ZMHV6Hk2N+WQQfLCucQHiHvg+yo3kZaqddjw6yoje2M=; b=PRyuF+g9f+0E5IF0UPkS8/tu6cQmTXFlgocwEk9uWOp7GbXIkecZCZrpFp1O21Rw6r aEPX+T5J2aNP+ZzzS1kC5o68D8tcf84hPuUtpSH756LI/+Xdetdx4cc+eqYP6HU7/WTM dsXCKdC/Crfa4qqTkFBMmyVFiHTzqLQNZLXjwfA/bX065PxwqkYOuzYckS++n5T+a3Fr HVzuQ86SCbmFAbzSihoOyXJNteoJZQZYSt4yvVCWnrlU+qvEfcNrQdn+BnxgXccSVTZ8 r5PvcoV57qd8Qazs9UIl7//AJyLVboowe33UNP+GyAh94eJnDkjjwan4BDMdf3tFAyLX 7NnA== X-Forwarded-Encrypted: i=1; AHgh+RpG8ESkn+g0dWNMcZHy95Go6HIM2AfI+YMdyStTMSLRN1zxx7kKbo4fGp6KGK9GsXo8Sxwbq5nC7TkNvLk=@vger.kernel.org X-Gm-Message-State: AFuF++mhXikbIjD18DyDpkT380ncQ66iohGymbz+dqbsP4B/khAK4icR ENz2vM5oO+wglSSXCTjxOdcuGR30HACLiEcRFFrUgBAuIKSZtn/7xN3kzxmSaS+WnZo= X-Gm-Gg: AR+sD118IAWnWZol/kYCvP7bClYCWnYaDG2jT8Oo7THi1J+xsECHmfnfim6KUMrYVhl t1RfOjYcL6BOVEN2ZQD6bZZFh27GP1Nmum1eVG/hsb82DP5F9soZABwexBtdLSv8pojh564HzTj 6E0AWXAUARQKPXRDr4CFmu+HDqVmZI2ui8RZ2LdeUrpx1VhG30iW835VYkGR5lVLXA3yRVgNya1 ZIVFi3VUNd+Oi9z47M8DnHWdysVIek6OGElZH3NKb33sWL+GM9vNjjVifCoMD4ImtOmHT9zWQBd JYNSxhW6CP0MMM/Kizsr+gv53HCSlhoMNrqqAh1iook0vdAuB45Jjj5LZtwGI2X30XgztEHBvdq OXF8pMRXu6qtvwdC3UgSEuYxVGDX26jTX/6Ig+p1kI9xZS/U733vCpgnnB4rJ8OQ49zCF26wUoW GRWnwgXGBvJ2Aqau5teF7MvgUIsiCUuUW+YIv/o8u9OQCeRRCgh63dbvewsk4fCpBHZjpJCBc6T x7Gt9F4E0SDdlXZHuUoU5UaEbVbuQvbQxV0irvK122aFKV6MaunNUdHglVvviHB X-Received: by 2002:a17:906:fd83:b0:c12:5a0e:3e0 with SMTP id a640c23a62f3a-c246a651b90mr3141091166b.19.1787596931658; Mon, 24 Aug 2026 11:42:11 -0700 (PDT) Received: from raven.intern.cm-ag (p200300dc6f02b200023064fffe740809.dip0.t-ipconnect.de. [2003:dc:6f02:b200:230:64ff:fe74:809]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c249606a8fasm1533526066b.8.2026.08.24.11.42.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 11:42:11 -0700 (PDT) From: Max Kellermann To: idryomov@gmail.com, amarkuze@redhat.com, xiubo.li@clyso.com, ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Max Kellermann Subject: [PATCH v5 04/11] fs/ceph/super.h: convert ceph_cap_snap.writing fields to `bool` Date: Mon, 24 Aug 2026 20:41:52 +0200 Message-ID: <20260824184159.240821-5-max.kellermann@ionos.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260824184159.240821-1-max.kellermann@ionos.com> References: <20260824184159.240821-1-max.kellermann@ionos.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This will allow better struct packing. Signed-off-by: Max Kellermann --- fs/ceph/caps.c | 2 +- fs/ceph/snap.c | 4 ++-- fs/ceph/super.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c index d7283fb54cec..554343d612f7 100644 --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c @@ -3304,7 +3304,7 @@ static void __ceph_put_cap_refs(struct ceph_inode_info *ci, int had, struct ceph_cap_snap, ci_item); - capsnap->writing = 0; + capsnap->writing = false; if (ceph_try_drop_cap_snap(ci, capsnap)) /* put the ref held by ceph_queue_cap_snap() */ put++; diff --git a/fs/ceph/snap.c b/fs/ceph/snap.c index 9b79a5eaca93..94964e0952bd 100644 --- a/fs/ceph/snap.c +++ b/fs/ceph/snap.c @@ -521,7 +521,7 @@ static bool has_new_snaps(struct ceph_snap_context *o, * However, if a (sync) write is currently in-progress when we apply * the snapshot, we have to wait until the write succeeds or fails * (and a final size/mtime is known). In this case the - * cap_snap->writing = 1, and is said to be "pending." When the write + * cap_snap->writing = true, and is said to be "pending." When the write * finishes, we __ceph_finish_cap_snap(). * * Caller must hold snap_rwsem for read (i.e., the realm topology won't @@ -627,7 +627,7 @@ static void ceph_queue_cap_snap(struct ceph_inode_info *ci, doutc(cl, "%p %llx.%llx cap_snap %p snapc %p seq %llu used WR," " now pending\n", inode, ceph_vinop(inode), capsnap, old_snapc, old_snapc->seq); - capsnap->writing = 1; + capsnap->writing = true; } else { /* note mtime, size NOW. */ __ceph_finish_cap_snap(ci, capsnap); diff --git a/fs/ceph/super.h b/fs/ceph/super.h index a3dae2c0bbee..0d3363b0a33b 100644 --- a/fs/ceph/super.h +++ b/fs/ceph/super.h @@ -271,7 +271,7 @@ struct ceph_cap_snap { u64 time_warp_seq; u64 truncate_size; u32 truncate_seq; - int writing; /* a sync write is still in progress */ + bool writing; /* a sync write is still in progress */ int dirty_pages; /* dirty pages awaiting writeback */ bool inline_data; bool need_flush; -- 2.47.3