From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EB64384CE2 for ; Mon, 24 Aug 2026 19:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787601566; cv=none; b=jQPr/iz6MKDRYUaSlwXC/jiOfRV7XbEiVdtCxtnCc0GaVGr9T2f+BMUT3CDqwQLF5AIYh0KQQjU4Xa5k7q4Et1800z+YjDdhwCiYX/5FxoenQnzp7cDc0RFqlYHblemBRw3mNdnnAzW/4wRGHEGqszINz7cgNiGty8p/DsOLNCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787601566; c=relaxed/simple; bh=IHJK93E8EnQzMr2uJwMOdIkkWxDVhFJxIHhUq2Ja39Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Le0kMRuthtQZ0UtPabvW8w963WwOeaDeAYwEBEyw+RRfqL0m3xIRTLfc1ikzY1mfgKdb1w6Mv1ECyivJ0Xqhb/bo3vVg7E/jvx1dShrCQZoeM8amp2XqaaRC4A+q6uDdNYAY7PYneS25QX7OwLju9pmmdou/XbUJ5KKcAD7ANDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=F68T1fzt; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="F68T1fzt" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-52d7ef16f91so18249441cf.3 for ; Mon, 24 Aug 2026 12:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1787601562; x=1788206362; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=iOiJInovljZCEmW5jxkHPX3bxzoPTur/8CMS8PTws9Q=; b=F68T1fztwD3ZKgfdnNPGH/JmM1lx+zcrxbMIZE7kGrmIkJwTk/GqXO94D6RACBMTB8 ZMrJ2MAlmmrfTJyyobuFeaVuSY/HmvqKlUm6sEcbrQ2iXL1yyPShkWGnKCtzoVHGP7K2 6zG1cG4eBJtO3OTA3XrA7KxegevtKpvRaa/dag9uc1nrUGoYmkwWcpGg7y4BMbO782V2 BrBcrFFTm4l3JyCaXH8sFPhr6+Sa77gy9L3Qxv8QPfk4G9mlsXNfrlgkhwKZw8FyF6Y5 WnnNpAJDKhB1VNB9onqq6h+/YCMctBVPQywEvPO1SHIyeEBOK3RwaS/13796rNF+8baE IZLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787601562; x=1788206362; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iOiJInovljZCEmW5jxkHPX3bxzoPTur/8CMS8PTws9Q=; b=Fcn3c83Rk3FBOtT/S9IGrcy/7wRR7YrD5EuxvLah+bdgGxPlRqlaUQJGpVGxUHUz1u ieiZmOZn2IgwtAj3u0GsCEEs2g1p8zW8lSGLlDeUjRxZXwK+8AldTnXnvu5owFdCV5ye bfRWD/hdtBEcO6pH+y/vSFzLcUvPk7XCQbZ1xbKt6Hz5ySBNGDaUMFt+fMMyhVav9M6F xOBYgp2VO4ztHhVnb1j/9S0WJuUNIGBzXfBnDx93W7X/4bixWGkGfxh8tzc/PF0+cgPH NXNUDPRowqwyN19cVd3eU0mw8yRD8ME5/OVgS6184XT0Kw5FPrmDAhlcJPmlDotj0En4 LAMQ== X-Forwarded-Encrypted: i=1; AHgh+Rqkvm9ervCGnjtJ6bdddWpuofdvEmXaTpP0QVDopbhKkGYkyOHTT8XykxyJUQpY4XvQTEAWIr8jbPqe1bI=@vger.kernel.org X-Gm-Message-State: AFuF++mKhk46JSrVfXjRRyzOVig+VrfRJ5yl+v6gRXD78vv+95WxBICS +kXXyHZSHbR90C4G9L51upngfDk8kGunqtef0Vem/NrnP+ZYBYeUTykH+0x5nIQ/+aM= X-Gm-Gg: AR+sD11IOzqGTUjIdqS3qjpV/b/Hgze56xPbLXWFVYOzPlxI3qQ34XJnJLs0QTzrRO/ P+Q3yEkUzj7ovNQTa4vpngiG9LoiizeNvoRUwA6l/f5wMkedAYI1PBL7rd5DjsE+VLjrLB58Sw8 yDZyALlaOE1WgPLtaCMVn46tX1funWpMD85B6uWHuFJTfzqJJeJdntoWqD4GhGFxD/Npyf+t+Ek xjI/L56pIuaZZaG5mpGLIKQQFM31XgSEM+bs2q+kZIbY12SRNl/iSLMDRXzvFtsmgOQRGjbPUHt yn3nrcJKwYRGxuQQl8tuXKZHaGDrRRME9uV79D0qtBKYCUhFLo9ahODwsCVAmbzmZFXRgSD4yFe gay0DY1KqrPJwA5IKLxY6fKYd9QsGbIWROB2YbI6AhMCluSLS12oDABHKz0sYLWhmesrbD6CY1B YzVxzkvO6CPEBOmPIzo4V7U6UMIh5lakstfibMTJDDiO/zpuP8EmPOLMK5tsIuXtXXPIQlUTc= X-Received: by 2002:a05:622a:2587:b0:528:17d9:2d99 with SMTP id d75a77b69052e-52e09d05552mr217305401cf.43.1787601562286; Mon, 24 Aug 2026 12:59:22 -0700 (PDT) Received: from localhost ([2600:382:8b2b:357c:c834:fad7:4274:2299]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52e099ad287sm54058141cf.10.2026.08.24.12.59.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 12:59:21 -0700 (PDT) Date: Mon, 24 Aug 2026 15:59:17 -0400 From: Johannes Weiner To: Enlin Mu Cc: akpm@linux-foundation.org, kasong@tencent.com, qi.zheng@linux.dev, shakeel.butt@linux.dev, baohua@kernel.org, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, david@kernel.org, mhocko@kernel.org, ljs@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, enlin.mu@unisoc.com Subject: Re: [PATCH v2] mm/vmscan: fix comment logic in balance_pgdat Message-ID: <20260824195917.GB863036@cmpxchg.org> References: <20260821064057.4081-1-enlin.mu@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260821064057.4081-1-enlin.mu@linux.dev> On Fri, Aug 21, 2026 at 02:40:57PM +0800, Enlin Mu wrote: > In balance_pgdat(), when the low watermark is met, processes sleeping on > pfmemalloc_wait are woken up because they are able to safely make forward > progress. > > However, the comment incorrectly states "they should not be able", > which contradicts the actual code behavior. Fix this typo to accurately > reflect the logic. > > No functional changes are introduced. > > Signed-off-by: Enlin Mu > Signed-off-by: Enlin Mu Looks good, thanks for updating the patch. Acked-by: Johannes Weiner