From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AA29C2EA for ; Tue, 25 Aug 2026 00:36:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787618205; cv=none; b=MHJ91A92ruqyvsvZKV5S+Zx53S4U0YTrWwJIA54WoxUdMKqkAtYwmo3POrO3R0dTZ4pv31HlzvKhTRV0L1s9fgGs1VUPmEjxHPjUIG+n/OBp/ArFvnep0lQ4trPrQPsG7/rN/rt/gw4iCDQRnKSC1BJhgukqK+LNkr6H5rf1SgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787618205; c=relaxed/simple; bh=V6d87ZtRRtAfDEKtAi0N/RHutqGxulOAQ8CJmnxCGcI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fVtRkqDyyjpTY8AI9FoMVxsQZEGpJIVfiXP9vCEbrf3eWww3TVNi2qhpZnsWjJcw0ZVNL7aCEgc1id2w6RDVXgYpsIU7KYNfPc+3DNqyChFBMMyM+vyU9xWGLwhfu2rVdcoceh0qGRKnk8jrUBHngQ9iMTkj6Mbcj8kGz906jio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=du+f6jXU; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="du+f6jXU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 914DC1F000E9; Tue, 25 Aug 2026 00:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787618203; bh=Ab1UodHqZ0psLkPHCdL1OHmoVYc553o8DprxmCFPjIM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=du+f6jXUdQG6lbmi9rUqAwNBEn93JpEo+J78Nrmhi+NekoRRV2o2o3NCV5BuD47oF 6pz2/z77qdb2q5duCsWSMK79pm8V+VrPQxl50FIv6Ya3/X+KqWlt1z7wTvTkEJ10uu 1rfqQQ2HR3usiQWOH2eMB4uDWNL//zyp0CFjhoJyw1v7JdQo/xkqi2uMzA8YwckP3l aXU8naTTAUusmf5cfATQz1iCnZSzyEeKAEcsUlPoD08KGOcwk/GE+n+LjtBg+cGvav BgECvw08tMGh4THaI2LcFm3Vomj7tiaq5U7x3b5cHr7J8UmgBSg+qUB9+fOs/WIquX sXPLhOXJSZoHg== Date: Mon, 24 Aug 2026 19:36:39 -0500 From: Rob Herring To: Tomeu Vizoso Cc: Tomeu Vizoso , Oded Gabbay , Thomas Zimmermann , Frank Li , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] accel: ethosu: Don't read the U65 rounding mode as a storage mode Message-ID: <20260825003639.GE50486-robh@kernel.org> References: <20260824152612.751007-1-tomeu@tomeuvizoso.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260824152612.751007-1-tomeu@tomeuvizoso.net> On Mon, Aug 24, 2026 at 05:26:11PM +0200, Tomeu Vizoso wrote: > Bits 15:14 of NPU_SET_{IFM,OFM}_PRECISION select the activation storage > mode on U85 only. On U65 the same field holds the rounding mode, and the > command stream parser has read it as a storage mode since the driver was > added. > > That went unnoticed while unknown values fell through the switch, but > now that they are rejected, every U65 command stream that asks for > natural rounding (2) fails CMDSTREAM_BO_CREATE with -EINVAL. Mesa emits > it for average pooling, concatenation, split, unpack, strided slice, LUT > and argmax, which is 72 failures of the Teflon test suite on an i.MX93. > Truncating rounding (1) is misread as well: it picks the two-tile > address path and computes a bogus feature map size from tile bases the > command stream never set. > > Read the field as a storage mode only on the hardware where it is one. > > Fixes: 5a5e9c0228e6 ("accel: Add Arm Ethos-U NPU driver") > Fixes: 6b7e0066294d ("accel: ethosu: Handle U85 internal chaining buffer") > Assisted-by: Claude:claude-opus-5 > Signed-off-by: Tomeu Vizoso > --- > drivers/accel/ethosu/ethosu_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied. I guess I failed to update the i.MX93 kernel with my fix. Sorry about that. Rob