From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 512ED331EB3 for ; Tue, 25 Aug 2026 01:56:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787623019; cv=none; b=JpjzO4ZC6kFXuxaUrl8ZMcbHuRTm7JoOY+IVAXO8B+0WlRoA0FGyppFveJPbNmF/fc6CTuakPStk8z9Nrghv3vYWozruXAJlA16Bc5AXB5Z6PG/4dZpSRcsXGT8MTpOTiw908+09kW5ktZhD9Iy1SJyBkUUv4z3GB35Q2Fw2CwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787623019; c=relaxed/simple; bh=+Oo8NDm9dvwfDBbQ2Wad7p0r2TT4On7jjKPyUzxLsDc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qEhcykF2m8qZjAj+NZ5moDaYF3SkNVA+89+mr08Pbr9bCJJb7D2b0feU3sSCdnS7Qr2YrMpt2mvc3VAaFnC9VGVpsbqn0E/aRxz2j/emTHlSVvA+Gh6XioozCpJDv+nxXgrboXbNHQmxMIIeJFfzu2YFzIcsePKNmZQPaWr8tts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=q7Uznf+T; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q7Uznf+T" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-383cb94f742so4398484a91.3 for ; Mon, 24 Aug 2026 18:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787623017; x=1788227817; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+Oo8NDm9dvwfDBbQ2Wad7p0r2TT4On7jjKPyUzxLsDc=; b=q7Uznf+TWlXTJ00bdUos2sntDsERjUOyko40zmGsue10Xp56okk3VFE2c6aOEoOPc9 +4LZ0CZgJkoZfMo23YM6KtjbEmV8J2PEYrOJhcsER3Li4DykHIYPH20i7kx5USLLV6YL vMBhw9hQIPj8LBK0vGCveEqq766MREdWm72za+Y2AgJiDb/blAQ0b4x5587nxbAjrvDG lzInRQiFjpihalDJtMvMhcmuxCXEsEZaY/xULWU8NvOUrj0kph3KbAYlxNJoe5WiNQAN G9bREpnHORceCm+3Is+ZBBMxNYuPU3W0qGXYc6BMIA/juyIL95Y67/TaZR4pAfm0077i U17g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787623017; x=1788227817; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+Oo8NDm9dvwfDBbQ2Wad7p0r2TT4On7jjKPyUzxLsDc=; b=IKLHbh7dnlqpo1VfBDQ0fYZDFhZYsNEO5wSjwy9+4W8sZgZq5PT9x5qkR4CYuwPU3x Q3DXWZFoaKWTKDMmrGrsxWi2JeseAynooiYCV7TC9iHBCoD+d729EJ/SIK0IUojweepp PwZbzrBtfXXg3JEms+vkN32QZrHnMXU9Bduy2npKthsIyVc6oGfmQFH4Ak4E2roS23iU O3+l0a+DvXHKRxohuVKrEew653v3f0NctBtODrPDZ18c7hfbtuFsInjkGZFfHIKL1l98 S3VIdPfB0JlubDjjIO6updcSMhQjnsBJLYmO+WpGij2EhVtjs3jIA33h0sqRrFO6o70M ogZA== X-Forwarded-Encrypted: i=1; AHgh+RqGkXimcT7BPRd1yFl5AQD9Cp0Vf9QleEMejHV0GhTWJRSqtUp9zhU7KGKvWnf688pKnaNVXyjhYppGQAM=@vger.kernel.org X-Gm-Message-State: AFuF++npK7wdOZJXsMPM81E2Cq2oGpw/rRo5LfwgqSZZahDEp+mcML1t DWxcJEmNv3M+LPpRUMtUCDUL8RxYUeWmxkm+J8kO0sB0wYDiBCeTdKScU4wYZw== X-Gm-Gg: AR+sD13hFfApZwV7mFWyaj8TPM83cp9UMhs5zO+/0btqX4B9ReAs9dUJN/7PsSfzWAG EM0EU3Ubv42y83+ZlWpayprfDzXPzwEk0snMOgVRfEP3TR5Qroww6riejcZUwV2kMhkQ/gsSk7Q u/z2Vwh0xBDpKVGxrJcqR8do1aJ12pkIGKC5nahAS7VhRVimkWlTSm/1UgeYpBsbS/q0S2GJIaT walWpeEWm++4aPlupzpCZ/+d/rAq1LnUxkYU/DNYsvjfillzR3Gm1vkRNL8FGgmlzWq37BKITKZ Cty5xZO3i33dHlch1J4j0dCD+yToe4MG60EyzxULSv5TVEC11nWVNrBG5cn3AIqzccU0ladfku0 +Ml5LdYxVswyKXinCMI7+Q8rlI/huOlewu/bYOPQ+ZqAMZ1CUOrpkXvV+Vhh/Nsi8hH9M+CgKfd /Xdya3gv4VUss7uu6bV/TFUTaW8NJOmj3pYHiRmgmtq2ywuuVu9wer0hlWdolhoZT24iXFISsn2 zfy+NnpmSZw4AHIkhM= X-Received: by 2002:a17:90b:5485:b0:38e:11ba:992c with SMTP id 98e67ed59e1d1-395df6080e0mr45204432a91.12.1787623017392; Mon, 24 Aug 2026 18:56:57 -0700 (PDT) Received: from PC-2B0BA31200898.company.local ([122.11.210.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-396433a54cesm604819a91.4.2026.08.24.18.56.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 18:56:56 -0700 (PDT) From: Meijing Zhao To: Mike Rapoport Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wandun Chen Subject: Re: [PATCH v2 RESEND 2/3] mm: memblock: show all region flags in debugfs Date: Tue, 25 Aug 2026 09:56:50 +0800 Message-Id: <20260825015650.205656-1-zhaomeijing100@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sun, Aug 23, 2026, Mike Rapoport wrote: > first and flags can be declared here. Agreed. I'll move them into the reg->flags block. > Can we really have both j < count and !flagname[j]? No. All currently defined memblock flag bits are contiguous and every entry in flagname[] is initialized. I'll remove the redundant NULL check. > No need to change this Agreed. I'll keep the existing code unchanged. Thanks for the review.