From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from r3-20.sinamail.sina.com.cn (r3-20.sinamail.sina.com.cn [202.108.3.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3E8C331ECD for ; Tue, 25 Aug 2026 06:45:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.108.3.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787640331; cv=none; b=JHO5sssmQOR8kefGgQyaTYoOcwZdIWhxd4LF2rr78c7SQlUa1myIi7bPtDxAJI8r3VLw/3OML62biONdx4Fs0gT57y8KqyaSw6sgQAwJtm6Z56r4Mj4yHz0gxIZaQ4GwrxwmeZ3Zvji71DpsAPLxeeOvlTqP08bYFIgrtolv8/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787640331; c=relaxed/simple; bh=Mpet5v8PbkmOMB57V+GBl9/w1eFNgPSqTrZ+a/7/y7Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dEkD5oZC4AzWUGD0TtOWw51KQi7OwHeaP1749PhWyzvWcgj+YctnX//5Ov7/oqegjB7nmdlKk9U5Yk9pXAzy2rveIzbMG3u3z/oCaXqKZkduZl5Ysly42KZFZbfqYVB/N8MQoNaXNfw2U+W2VudUIFh749QLa53XKgYdhUXEENE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b=rfytPOd9; arc=none smtp.client-ip=202.108.3.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b="rfytPOd9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sina.com; s=201208; t=1787640327; bh=Mpet5v8PbkmOMB57V+GBl9/w1eFNgPSqTrZ+a/7/y7Q=; h=From:Subject:Date:Message-ID; b=rfytPOd9OA11ZMdMjr2OZa2JGUR8rlTYaHUREVwxVB7nygC5rcBffeTdfZHXB7t8B zgJpD4rWdRM0kX3/M4TX7CceaGfUqK4ac8D9nksVDQV1mxIg6enGJdPVH+sN1X8904 gsdz+0uGaMjWZ2gay2Mk/ekUgzumJZWG7pMwpYK0= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([114.249.62.194]) by sina.com (10.54.253.32) with ESMTP id 6A8D39FC00007A0A; Tue, 25 Aug 2026 14:45:22 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 4797094457020 X-SMAIL-UIID: 220ED35ACA1B48AFA97EF5A114D90D3F-20260825-144522-1 From: Hillf Danton To: Shin'ichiro Kawasaki Cc: Eric Dumazet , syzbot , Nilay Shroff , Keith Busch , boqun@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, peterz@infradead.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [net?] WARNING: locking bug in tcp_tsq_handler Date: Tue, 25 Aug 2026 14:45:06 +0800 Message-ID: <20260825064507.1499-1-hdanton@sina.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 25 Aug 2026 14:44:35 +0900 Shin'ichiro Kawasaki wrote: > On Aug 25, 2026 / 03:50, Eric Dumazet wrote: > > > > I think 19bdb70c77d3 should be reverted. > > Just reverting the commit will reintroduce the other lockdep WARN that the > commit addressed. I hope to have another fix to avoid the WARN. > I do not think you know the root cause of that lockdep warn, so reverting 19bdb70c77d3 is the right thing to do because of [11, 12]. [11] ffa1e7ada456 ("block: Make request_queue lockdep splats show up earlier") [12] Subject: Re: [PATCH] nbd: don't warn when reclassifying a busy socket lock https://lore.kernel.org/lkml/20260816014906.1149-1-hdanton@sina.com/