From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 202BC3EAC6D for ; Tue, 25 Aug 2026 08:52:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787647943; cv=none; b=KxHA3jK9xR7Wy3K2l2Jv8K459su4pm6SDPD4LYj6oC9i2459CHEdGC+wAQ1yqDSdSvaqDFf3ySnP1R5lamwjUO8GvIrO0NToQu97ElwkXIE/Nh+jx2hF5Gkmui2kp3/U9tytQ8v8jBhlwBBoK0lSH/UEZoqVa3i+L8UnijyQQjY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787647943; c=relaxed/simple; bh=TZ0Tk02P9YLuRvbKHnx8xQeRXeHOdPj+cyqR0h2JZfI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dNRsq564L9G3Q8zhnrELZE6MlVUW9v3xYFv+BaFmKvol2UTu4KCVmZm+pT9MBoMZxpU6kVynfqjTu3+YMsOb8jYNjb1tHpc46BWzD0oXruKvpcD3CVwPtBGUtrMevmsiA13rrNCzf6ZfMAVQ414rYrORhy9guQGJ4m6ZwJj8pCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PK42kcs9; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PK42kcs9" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-8485ef63b68so4455744b3a.1 for ; Tue, 25 Aug 2026 01:52:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787647941; x=1788252741; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Gu7Nc99xk/nLbpeUOexaTxz8Q5kk/2EyCmw8FRDGVrU=; b=PK42kcs9HGikPZT9TW5bh3Fpu4VX7Zkub0R5/TVpgXPUMXFHEBOZ7b0hPPIRZcS6tT c6cZ/VkE2z1eubGas8F7Prz6MNfB4kiUb6PG4UX+wjRWZ0oAu/dEmJzqkTXmb5TU+tEC yCSfA9539z00hEValD1afhjvCPnUPb7MNvMkM8FVRXWEDFm2xZX5OEcQECfLtHvQscSM sXvnKbgAXuI46jpAZJz/8g2Qop1J+UUcB4QgrZSkK6OPWbxLoONgviYDm+Vm9ffTTQoP jsgEae4tY0j7iG2QkgPFQvp1DMIJULVFt2fPajtbjcgl6e/MdSFGpl9W5F7Da68HFLck 2K1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787647941; x=1788252741; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Gu7Nc99xk/nLbpeUOexaTxz8Q5kk/2EyCmw8FRDGVrU=; b=EzmB0mriZQfNTq3QE1Z78RtCFgnwFv2jyh4O+5ge65JN+JczFUZyR+iJloUE/wAdZi i2TRCeggxG0J3+juFna3IE2AvDhLH3Zg4Rf/1iUaHz8BUdT+pLWq1gWBbu0bjqennOn0 19jQH96whOX2Jk61EKnNiD+z+IRkqNBgqTIGG00W/MeOW20J191dJC1Bcu/PiGLq5WLD ks8JtD69uu98evDuRdnPyNUb3N1Av/Y029adKRniWs0G3b/dZgnNHGtNuM8qXGJxrGez pmhTAAcoAX1XUgaK6PNXGOLQi7mOLrMc5tpq5UIWF82Vm+RmfKEzRHjY8rQ6Gwo7lhCh HsIQ== X-Forwarded-Encrypted: i=1; AHgh+RrdXVTr7OKLUs1MIdz5civ4caBkYV8slSdawDqVBxhKmVuFVHcBFpVDN6IRcrnCq3RaOlVF1giHHF54waA=@vger.kernel.org X-Gm-Message-State: AFuF++nhMPokdVJgyg7Dgvkt/zh7+Lm5BZD0nPGVnqYsNUWrmr2nTfZX Lz9Ypzk24i8FnsT0bEtvRD8Y6xkLo/cbV+vTgcfNcQgdXU/OOkhLn9X5 X-Gm-Gg: AR+sD10w29gmSvr+bjOOv74kAb1rJq0owPBOPN/SIxHlXe70o9gR0bqv+6SBoIpprdV GAxPVdMFuWZhRLjvwwJTDZd+YXtrLsnWe8hI6SvETi2w5dKXl03mwSNpjDLlbOaJ0fXzFe0geyA SlDw9vlK5SS4L+bpXcXncU1SkcCMNXENnJIM+PahkxuE6zzeRRUHGaD5sNCjRaxwJfDLLtu6QKR +ya8UKHfFyH1Cw5FgKpEM27HSChEc+oYQR4jNSUdCBozmkY3myLwPeLTyDUFh195NfJGa0NyCjK kQNW/NlK7iIFe6OccUG6ngCwhUeSJItO53e045vaT3LaIMOXmVCnFUIaxpyMBmzQivQVqwZ0KDO 5k/hmMK9vlleXsEVmYYbr98yO3MZmpY9n1MO6LdAP37hqSq1KFckwCFPtkMvTbX3k+svwklVWmy gCqCMVeYHdym5hWiWEenS5Uh20c+SpMo6brXTFOxtPgk8TW41N/5I12X6W/F80f9eEHe2R X-Received: by 2002:a05:6a21:6010:b0:3c3:f371:1ea9 with SMTP id adf61e73a8af0-3cd3009ca00mr63740804637.10.1787647941193; Tue, 25 Aug 2026 01:52:21 -0700 (PDT) Received: from shrey-Mi.local ([106.51.251.74]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327f90c0a59sm42032202eec.9.2026.08.25.01.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 01:52:20 -0700 (PDT) From: Yash Suthar To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, andriy.shevchenko@intel.com, grondon@gmail.com, linusw@kernel.org, hexlabsecurity@proton.me, sakari.ailus@linux.intel.com, srinivas.pandruvada@linux.intel.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Yash Suthar Subject: [PATCH v3 1/3] iio: accel: bmc150: use aligned scan buffer for both trigger and fifo Date: Tue, 25 Aug 2026 14:21:54 +0530 Message-ID: <20260825085156.212042-2-yashsuthar983@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260825085156.212042-1-yashsuthar983@gmail.com> References: <20260825085156.212042-1-yashsuthar983@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Drop buffer as duplicate and s16 is not correct we needed __le16 as little endian, keep scan at the end of the bmc150_accel_data struct with IIO_DMA_MINALIGN, and use it for both paths. In trigger handle, replaced AXIS_MAX with sizeof(data->scan.channels). Additionally, ensure mutex is held across both read and push to get DMA safety for the scan buffer. Fixes: bd7fe5b71918 ("iio: accel: BMC150 accel support") Suggested-by: Jonathan Cameron Signed-off-by: Yash Suthar --- drivers/iio/accel/bmc150-accel-core.c | 8 ++++---- drivers/iio/accel/bmc150-accel.h | 14 +++++--------- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c index dc8a6285cf3d..1472e0d1ef65 100644 --- a/drivers/iio/accel/bmc150-accel-core.c +++ b/drivers/iio/accel/bmc150-accel-core.c @@ -131,7 +131,6 @@ enum bmc150_accel_axis { AXIS_X, AXIS_Y, AXIS_Z, - AXIS_MAX, }; enum bmc150_power_modes { @@ -1191,14 +1190,15 @@ static irqreturn_t bmc150_accel_trigger_handler(int irq, void *p) mutex_lock(&data->mutex); ret = regmap_bulk_read(data->regmap, BMC150_ACCEL_REG_XOUT_L, - data->buffer, AXIS_MAX * 2); - mutex_unlock(&data->mutex); + data->scan.channels, + sizeof(data->scan.channels)); if (ret < 0) goto err_read; - iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, + iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, pf->timestamp); err_read: + mutex_unlock(&data->mutex); iio_trigger_notify_done(indio_dev->trig); return IRQ_HANDLED; diff --git a/drivers/iio/accel/bmc150-accel.h b/drivers/iio/accel/bmc150-accel.h index e8f26198359f..9deff256aed5 100644 --- a/drivers/iio/accel/bmc150-accel.h +++ b/drivers/iio/accel/bmc150-accel.h @@ -64,15 +64,6 @@ struct bmc150_accel_data { struct bmc150_accel_trigger triggers[BMC150_ACCEL_TRIGGERS]; struct mutex mutex; u8 fifo_mode, watermark; - s16 buffer[8]; - /* - * Ensure there is sufficient space and correct alignment for - * the timestamp if enabled - */ - struct { - __le16 channels[3]; - aligned_s64 ts; - } scan; u8 bw_bits; u32 slope_dur; u32 slope_thres; @@ -85,6 +76,11 @@ struct bmc150_accel_data { void (*resume_callback)(struct device *dev); struct delayed_work resume_work; struct iio_mount_matrix orientation; + /* Ensure correct alignment of timestamp and DMA safety */ + struct { + __le16 channels[3]; + aligned_s64 ts; + } scan __aligned(IIO_DMA_MINALIGN); }; int bmc150_accel_core_probe(struct device *dev, struct regmap *regmap, int irq, -- 2.43.0