From: Hugo Villeneuve <hugo@hugovil.com>
To: Luca Fresi <luca.fresi@bithiatec.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Tomasz Moń" <tomasz.mon@camlingroup.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] serial: sc16is7xx: enable THRI before filling TX FIFO
Date: Tue, 25 Aug 2026 09:21:54 -0400 [thread overview]
Message-ID: <20260825092154.87372afd883ff787b304caf9@hugovil.com> (raw)
In-Reply-To: <20260721222404.204746-1-luca.fresi@bithiatec.com>
Hi Luca,
On Wed, 22 Jul 2026 00:24:04 +0200
Luca Fresi <luca.fresi@bithiatec.com> wrote:
> sc16is7xx_handle_tx() currently requests the THRI enable only after it has
> filled the TX FIFO. The request is asynchronous because the IER update is
> performed later by reg_work.
>
> The SC16IS7xx generates a THRI interrupt when the TX FIFO crosses its
> trigger level. If the FIFO drains past that level before reg_work enables
> THRI, the chip does not generate a new interrupt. Characters remain queued
> indefinitely even though the hardware FIFO is empty.
>
> This was observed on an SC16IS752 while both UART channels were active.
> During the stall the software TX buffer remained non-empty while TXLVL
> reported 64 bytes free, LSR reported THR and transmitter empty, IER had
> THRI enabled, and IIR reported no interrupt pending.
>
> Enable THRI synchronously before filling the FIFO so the threshold crossing
> cannot be missed.
>
> Fixes: cc4c1d05eb10 ("sc16is7xx: Properly resume TX after stop")
> Cc: stable@vger.kernel.org
> Signed-off-by: Luca Fresi <luca.fresi@bithiatec.com>
> ---
> drivers/tty/serial/sc16is7xx.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index daebd92f32c7..a1bd175e2feb 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -827,6 +827,9 @@ static void sc16is7xx_tx_proc(struct kthread_work *ws)
> msleep(port->rs485.delay_rts_before_send);
>
> guard(mutex)(&one->lock);
> + sc16is7xx_port_update(port, SC16IS7XX_IER_REG,
> + SC16IS7XX_IER_THRI_BIT,
> + SC16IS7XX_IER_THRI_BIT);
You can combine the last two lines on a single line.
Also, now that arming is done with your patch in tx_proc(), you can
probably remove in handle_tx():
else
sc16is7xx_ier_set(port, SC16IS7XX_IER_THRI_BIT);
since the only other caller of handle_tx() will be
from the port_irq() when THRI fires, so it is already enabled.
Also it seems that for some cases, the THRI will be enabled for nothing
and then immediately disabled, causing useless I2C/SPI bus
transactions...
Also for x_char, empty kfifo or tx_stopped, THRI will be set, as before
it was not.
> sc16is7xx_handle_tx(port);
> }
>
> --
> 2.34.1
>
>
--
Hugo Villeneuve
prev parent reply other threads:[~2026-08-25 13:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 22:24 Luca Fresi
2026-08-25 13:21 ` Hugo Villeneuve [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825092154.87372afd883ff787b304caf9@hugovil.com \
--to=hugo@hugovil.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=luca.fresi@bithiatec.com \
--cc=stable@vger.kernel.org \
--cc=tomasz.mon@camlingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®