From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3A7D3F58CA for ; Tue, 25 Aug 2026 11:32:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787657554; cv=none; b=I3JVRjNf36RpQ7c71UlwXSjbxB1THdAT3vpuiajB6/HSYunNx5tCrnuG1AjAfcY4xg6nfyjT1yjfoleggJVZx6Za/U/1N6H6Ivhp8PCRizjfsooJ0opZNR2Qu+tlcHCgL6DSce4gT7EwJzCIOZH3m0q3ewCj9QKXfPko3U1tefc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787657554; c=relaxed/simple; bh=77FV4gAwZHhe5VsNEn+/kHl0xzti0KlAzAXbsklLkdo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=orYj25c8qL8jKJ1LqxbGf9JOv/ShsEy8wTXxwUimRu4zDMdd9xfsBg6a/ZeQDJi9JbkuQ9en4f9c3z8wlttmJhRF/dSknI+uyXqds3BT0q2P55P08WKzChebgv0SVHfn9g8+NruNrC2q/yKar3BIX2bWGSxQpYk12ZrJ2skzIu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=SYVgCl/2; arc=none smtp.client-ip=209.85.219.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="SYVgCl/2" Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-8efbafa1bacso26704676d6.1 for ; Tue, 25 Aug 2026 04:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1787657550; x=1788262350; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=vVQT3N6kOOE5myTvrMMJJrC2le/iHw4etRZgWkc2XyQ=; b=SYVgCl/26xBUc20Zv7u7cEi1TkY3z7PwKIBI7Z5gooaQp1hnHCpr9G1bLmsDk661x4 r3T9NDuGGgcUdzAE291B9LX/HVBJkpWIybF7QBhRvoZdQgTHiTk7+eSYndvDHc9jUYzC 1l7TQgoNePn6j58gqAvNVFk5cNrUqsHk6L/2piGQDwi7Lwkse1RcEVt4KIQ+FDq7j1sk PBdmUFU24xZKsP2hq4FTPf7mF0qzqaH0gjNtXXDoRwFIQjl3moJW/V3m3EYNSI5P6D/g 2xEPsyX4dtmQ0doTaV85eOOnxt+TqjpEGyaWW5YvHmNXo11kdiCTe+iSkQY3MIiYHBWj 1y6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787657550; x=1788262350; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vVQT3N6kOOE5myTvrMMJJrC2le/iHw4etRZgWkc2XyQ=; b=h0/tC6bzimUKiPWcXq8bVOI69C+sP2i3bS3Yafs1kM/MIt10ViRbsTjeyayaqlXIeu 14HlOsQZzPL5NKQOBORLXOezkWDnxWu+/NnrI3zD14HxrSIEW6+pJrmr4y2lMB3hyrnn flw0xR7j09bNkFe+NpyFzmQJwI4IS7Ela7dpXgb+UcGnd4voKVjpmBrnIYjjP9npeJLE HvmZHCcMPMm9kQIDnNEwYnd20JrsG8CufZiB2wq9mpa3L40AdnL/ulwcJICCuGrXST7Z AuDTM0NMskZ4zoPkS1af8h9as12SH807VUGlSL33xudXpUjUR/81+vrL7SsfGUo0PU8b eF0g== X-Forwarded-Encrypted: i=1; AHgh+Ro3IN8rmUVYR3mAXmNXV/E8C1hb0pMONY4po+pCt5PDkANo4H0E2LGSjhcRteUgGwdcvlzBqQTRvmMRzgw=@vger.kernel.org X-Gm-Message-State: AFuF++ksIW2KBlNGLXqizBuNreqcW5+F9xCoX3HMno8jhjkJq68PL7QR Hv5q9fO7xBL3dsNx38sCpV6Jra0xExGvBdDVRSiVNu9OrMW7YvUZ9Hsbbggp4EU3WD8= X-Gm-Gg: AR+sD12/wcip2j1XQLE+llq0eh+VkqKCWzINyeUMz80WHwqvjUmcvZ/nFR9F8Yl+VMf h9UK3U8uudnMyZMb3Ou9NlRnn+HpR0YxDTjDxQrIe7AD+WOKhp7N2WsCt9mv7A+lvCfevv+TmBv w5jmHVaoWf/nqGq2SubrCeU9A/722sp00PvXCSo/2ZjCb80+ZhVtpexygjLxvLoMPo2fTDX5XcG F48PEGOeTKA2dibiq+RN8ky2UXS7S5RELrM/McQW3TGJpdLcibqliQ0FjgOEiUnOY2MUJ/ixLcl IDMdxW3oKUROLEqv+NNL7ovmXTgbXln0wQRWMXwoZD3dOKtw6wjscnT7kGXNQ/RkqSevXngGcVc Pq7/HEI0diqRfrSkVEFPThjF2MRc1gwIsI+qjfnaghqrNCQ3NOm1vxacNkp7ShB0d7taMtYxBbk xC7VuxAMdWhyotj7gLlGYzjpYc63CDKdCC07pn9vb8u0/HtWqY+6ldW5vd6dBN9MNkqGG6cjBxg YzUX297Llsn524TQUfnbD1YUtmjlpSlun9+QlFg94XbzQ== X-Received: by 2002:a05:6214:5018:b0:8be:7779:d1b1 with SMTP id 6a1803df08f44-90c8fa906bbmr219810756d6.30.1787657550233; Tue, 25 Aug 2026 04:32:30 -0700 (PDT) Received: from ziepe.ca (hlfxns010zw-159-2-239-150.pppoe-dynamic.high-speed.ns.bellaliant.net. [159.2.239.150]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90cbbb90726sm12891346d6.2.2026.08.25.04.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 04:32:29 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wypOG-0000000DpSk-3lDg; Tue, 25 Aug 2026 08:32:28 -0300 Date: Tue, 25 Aug 2026 08:32:28 -0300 From: Jason Gunthorpe To: Zhenzhong Duan Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, dwmw2@infradead.org, baolu.lu@linux.intel.com, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com, Joerg Roedel Subject: Re: [PATCH] iommu/vt-d: Fix page table level calculation in compute_vasz_lg2_ss() Message-ID: <20260825113228.GD1449020@ziepe.ca> References: <20260825080002.117412-1-zhenzhong.duan@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260825080002.117412-1-zhenzhong.duan@intel.com> On Tue, Aug 25, 2026 at 04:00:02PM +0800, Zhenzhong Duan wrote: > compute_vasz_lg2_ss() finds the optimal Second-Stage page table level by > intersecting the maximum guest address width (mgaw) with the hardware's > SAGAW capability register. > > The VT-d spec maps the SAGAW bit field positions as: > - Bit 1: 39-bit AGAW (3-level page table, top_level = 2) > - Bit 2: 48-bit AGAW (4-level page table, top_level = 3) > - Bit 3: 57-bit AGAW (5-level page table, top_level = 4) > > The fallback paths use bit shifts that are one position too large, > causing ffs() to select a deeper page table level than the mgaw window > requires: > > - mgaw > 39: "3 + ffs(sagaw >> 3)" evaluates to top_level = 4 (5-level) > instead of top_level = 3 (4-level) when hardware supports both > 48-bit (Bit 2) and 57-bit (Bit 3) AGAW. > - mgaw > 30: "2 + ffs(sagaw >> 2)" evaluates to top_level = 3 (4-level) > instead of top_level = 2 (3-level) when hardware supports both > 39-bit (Bit 1) and 48-bit (Bit 2) AGAW. > > In both cases the selected level is still one that the hardware advertises > in its SAGAW capability, so IOVA translation remains functionally correct. > However, an unnecessarily deep page table may be selected, adding an extra > level of page walk overhead and reducing TLB and cache efficiency without > providing any increase in addressable IOVA space beyond what the mgaw > window already caps. > > Fix by decreasing the shift offset by one in each fallback case, ensuring > ffs() targets the correct SAGAW bit position and selects the smallest > page table level that fully covers the mgaw range: > > - mgaw > 39: "2 + ffs(sagaw >> 2)" correctly yields top_level = 3 > - mgaw > 30: "1 + ffs(sagaw >> 1)" correctly yields top_level = 2 > > Fixes: d856f9d27885 ("iommupt/vtd: Allow VT-d to have a larger table top than the vasz requires") > Signed-off-by: Zhenzhong Duan > --- > drivers/iommu/intel/iommu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Jason Gunthorpe Jason