From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20A93373BFE for ; Tue, 25 Aug 2026 09:40:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787650804; cv=none; b=c/IJsVOZw9d41c/jEoJYaC0ORk3F1ZE959RAbEwdfj6lgQSTFtNQvDI5qOl+4PMNp6isDHLoYNvDTRNLWRoaOcqrepWbrnAzMbChUlZ5MYlhILiRxYU2PjXVIGvDq1WTS2SRj/eTw1KPLGdgu7/kqtsSgL6nadLMwt6DUPK3rVs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787650804; c=relaxed/simple; bh=9wJZiSmpJkaWQYC5Sfiwp3fgYQo5ibADA/Ym5bAdoUg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Q9HfyDJAZYZKPFewuBkRt6cQsLJFi/7NbTpEHFTlfw4bKWejMZkS/YDE/S5H5hs2McSQgALny1VHih24+xqq6j00dkmuti5tvmko5Jwc3KhDH48CR0eIvtM1BlZ2hKn82MHsVAkBLDCI+6jFyhButL+r0ZiCppL8/KRyCuicyz4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YogIfKM+; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YogIfKM+" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-6a3fda88184so6905102a12.3 for ; Tue, 25 Aug 2026 02:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787650800; x=1788255600; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=9wJZiSmpJkaWQYC5Sfiwp3fgYQo5ibADA/Ym5bAdoUg=; b=YogIfKM+15Dzg2YCI254Q2GLk2kXGzirtzYQyX7r32WqgLDsFvASSJ0KwNHLyeGUkI sJFL3A3Al+tFUmD5bckn7MQJ7q12QTc5rfaQ6hb7UGVUs1BF1GMbMX8g25cl/bW5pFHr c8j44xqc2Gugl+zkTa7cuBjT+NNo+923pppSHuuI1CmjUlw3f5qJhrk4vZ4S6e1+wm6a zG9KhPOI3t/YNiz65IQTSdwGnx0xOTsGL07TQEeAPHrRiLondHcWwdDd1siEoX8YMwaQ BY/tJudSR/KIs5uCT6mWjRx3/UO6r9uXWuQhsnWDahmlh+kIhGD1386BLsf93B/lkH0U RwGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787650800; x=1788255600; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9wJZiSmpJkaWQYC5Sfiwp3fgYQo5ibADA/Ym5bAdoUg=; b=UUnCbkK+kf3Cd3dyTD9XYyhjV8YtvVkeQldx/T+zgafaM5t8wICGvWreoSo8c1SVtQ 56sgfceoDD12rdkVT0JSEtgE4ZH8oSz5+k/n4ZgQKJqUOyq/g8RwCSgv0E1s30HumOxM hDyXnkhvxqsvVTAbvEvU+bhxFgeB6IuWHjWH35hIGxkXy6+afomkD7Vgpthg0xtzEER9 euhXqTqR5XOnXVgN2UzUMJt+m795QDQGifSJ85H8W/q1JVW9a50zPGNohwR6rz2nUGub ZKbL5Dsl8iXfLaY64SlUss3tHzi6SDhGHgOiJq3vBP6I2NSiC9mIPCs6kByNIyAKQ50e qHww== X-Forwarded-Encrypted: i=1; AHgh+Rr0kLTcW4qzaNdd2fi7DICchEkM2qSguDCF6MRcV3sGcvZdCu4Qay5M6jkgn+yHc2Q4w0Xza0j+0TWiFfA=@vger.kernel.org X-Gm-Message-State: AFuF++kbgZIAbtioIrtH1os7O+5xNHrjbuZILmQ8BtDD1p+0WfcqAN4a erbw/SzxX+6A6+RfwVO+z0tVLY+HoD3mQ2gm2nDQJBR23ODcaEbrup8Np3/L+1loAq4= X-Gm-Gg: AR+sD10CrA+43b1sxIrwu26mO4ndkzUMsrrQ1zOJBS5IRJJ5I6RwOjMNYCvWgyKm1qC lKFG5F7p4XWvFCjfLqNyLVkOffk8u+VXuuaevKyS/0tNhl2RR13CRvnaSLjympERSc+mAFfrsRW 4sw6BKGmEqV7NOz8vf8IkzelKp/zWYvUe8vj6YPYetHi/sTdeViWzEbaP+cuXalO/4CgQE+9oMH ipFBZaSyyCXXEZ+oFMv4FsMNJhx78qEQmnNCFu8BmJ28bCumgHi62miJhZpT1BQSsxc/9ybxxjx 9S9Hj8xyR7vS/QdW26iPVCzcuIkVdjf7Rvbnof/OWRWIlxYJ/FG5A6A8vFIRO9uUwHKNANlX8RL /0vnrZuKfqcIJOUGN/xQGTjgNRE6PqIi8PthZfFEj1cLhFUh+Bnj1I9wxQRfziczjGVYbYqQ+VW My4Y0oT/rONhq/62CKt/d0+gKDTAxG3lFLL9cBgff6XQfur6gGidIfIfUM8PehVj09f/f7OOWcG xNr41waEL0AeENrWRFGy6oL7qkHhcq1YI/qyVZExXO5e+eiME8EtEBc77eBVLjPWKDQ5pw2s5y8 EhNkqtVrx5KRS1noBpb9tCwa7hBAS0Opit2pwfDjliWf3CcMNGPWjwIFnUew12yV/gBP+7WrsuJ omoYtuL9HztQkwBwbnHR8/tXoA3tDeicxN/OHErCYBPhE6wrzap6+xyieB6ERFjAlEMcBLg== X-Received: by 2002:a17:907:7241:b0:c16:6a42:c7d6 with SMTP id a640c23a62f3a-c24e589b49dmr532567266b.9.1787650800013; Tue, 25 Aug 2026 02:40:00 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2496297189sm1641420266b.22.2026.08.25.02.39.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 02:39:59 -0700 (PDT) Date: Tue, 25 Aug 2026 11:39:58 +0200 From: Joshua Crofts To: Yang Zi <2959243019@qq.com> Cc: lorenzo@kernel.org, jic23@kernel.org, linux-iio@vger.kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: humidity: hts221: fix division by zero in calibration data parsing Message-ID: <20260825113958.000038b8@gmail.com> In-Reply-To: References: X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Tue, 25 Aug 2026 17:21:10 +0800 Yang Zi <2959243019@qq.com> wrote: > hts221_parse_temp_caldata() and hts221_parse_rh_caldata() compute the > sensor slope as ((cal_y1 - cal_y0) * 8000) / (cal_x1 - cal_x0). If the > device reports cal_x1 =3D=3D cal_x0 the division causes a divide-by-zero > error. >=20 > Return -EINVAL when cal_x1 =3D=3D cal_x0 in both functions before perform= ing > the division. >=20 > Signed-off-by: Yang Zi <2959243019@qq.com> > --- > diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/ht= s221_core.c > index bfeb0a60d3af..7d1f04951d8b 100644 > --- a/drivers/iio/humidity/hts221_core.c > +++ b/drivers/iio/humidity/hts221_core.c > @@ -288,6 +288,9 @@ static int hts221_parse_temp_caldata(struct hts221_hw= *hw) > =A0 =A0 =A0 =A0 =A0return err; > =A0 =A0 =A0cal_x1 =3D le16_to_cpu(val); > =A0 > +=A0 =A0 if (cal_x1 =3D=3D cal_x0) > +=A0 =A0 =A0 =A0 return -EINVAL; > + > =A0 =A0 =A0slope =3D &hw->sensors[HTS221_SENSOR_T].slope; > =A0 =A0 =A0b_gen =3D &hw->sensors[HTS221_SENSOR_T].b_gen; > =A0 > @@ -327,6 +330,9 @@ static int hts221_parse_rh_caldata(struct hts221_hw *= hw) > =A0 =A0 =A0 =A0 =A0return err; > =A0 =A0 =A0cal_x1 =3D le16_to_cpu(val); > =A0 > +=A0 =A0 if (cal_x1 =3D=3D cal_x0) > +=A0 =A0 =A0 =A0 return -EINVAL; > + > =A0 =A0 =A0slope =3D &hw->sensors[HTS221_SENSOR_H].slope; > =A0 =A0 =A0b_gen =3D &hw->sensors[HTS221_SENSOR_H].b_gen; > =A0 >=20 >=20 This definitely needs a Fixes: tag, otherwise LGTM. Feel free to carry my review tag. Reviewed-by: Joshua Crofts PS, a bit of process info: I noticed Sashiko (sashiko.dev) failed to apply = your patches. To prevent this from happening in the future, please use the `--ba= se` flag when running `git format-patch` to specify which commit it should be applie= d onto. --=20 Kind regards, Joshua Crofts