From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B64F3F12DE for ; Tue, 25 Aug 2026 10:23:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787653388; cv=none; b=HRJ9+aLTEPut1hFZYV5KovkJ3qq6698Y41DbvsNKyWcy88DNpMLtkQdkDpYuYncqJQLAbl+zh/5LyUBcdS/d6rcmDeWrwNiegwBq30QDfnaG4NXA8m/gwAX5YjiAF5ARrpvg80O/Q/olPEFSZY0mQ/hrEwb/tijRNDOJClCTDUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787653388; c=relaxed/simple; bh=5x+8HPjpXqhgvYAk50e7uP9DNSJ3/TXNvQ39Lw8wTOA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gF3CMd9V9CFygGrDQZZ2WIaSo6DH1QbbAPNnhZJy4UJKYXxAdGWIuXK4Wi6njpWix8YnQKEDngC0SIohDm+sgwczEUjuv2ZXJHBLpjT2/B0+0X7g7r1EIt9cKp4YXd0Z3f9vjVnMaOAToW+eHR2rDYk4ZVoimi5vbv7QoDg1bj4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BpjovjF1; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BpjovjF1" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-c15e592da74so633255466b.1 for ; Tue, 25 Aug 2026 03:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787653383; x=1788258183; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Y4eJ3nmbGLFNyyQbwsnCHRPDBdQQucCu/IaTUqHFSaw=; b=BpjovjF1Xth5CIN/kg9NWMefP342vj56Wmri29jTjypi3oN9gohT2xRfn0jmxvnvwG 3YWSt+B6dBGZrKcxdAzbV+GdxHTVww59xm4vVqUodQNwHmmZfRNrNxr3rMJw1qQOgvKX 4eD2MMS7aXeE0C86gxlRl7qnXiIscgN3U9CR8FvwPwLPuC3qg/T/8yQD6P/3MAujZRRY F1o1KzbbVmNN1y+hRyClVRq3t6OG+QKkGbQuWC4afWRtCs2IuD1Lw/CBeDZ/JKVTGOuK bsZzQdNC614HUST1LLsycYOrFDfXKZnXF6NF2Fd1pz/XnXSe4xdDTnNfAoHJrRFXTEzI 54vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787653383; x=1788258183; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Y4eJ3nmbGLFNyyQbwsnCHRPDBdQQucCu/IaTUqHFSaw=; b=cl/BmMWoraZ6jxxRyJi8RZWEIp6Jetbn+UDbJmoOpRFzUT45cDOkpXW3o5iKdrEam7 EjR0zfE0Vy4jKzsq5Ra8Tr5W9FduNxt49nGBtT6PRi8pivB15AGglrkQcZT42ioAiYTQ 0dMvxd7arbNYOe8gPPTQXVROKK+LtjBhgfQrl+xgKUkBR6mZIy5DFHruVugM4Y6s57jN K374Pov3/4cF1sFwgsxBb8gzymK3Q07A2MiBG+0jRpiR+CBx2hfERgpEN04/7pMQTN1Y P1lKRZZSwqxTpXRwIkKHfM4tCDxZxbuXgncNfKG6ci+R71loqdrfndxBNV/Vyu6llnYK Ouzw== X-Forwarded-Encrypted: i=1; AHgh+Rr4IiKh72/MByaCFwi4coFrBMQ8qkJjwWVPsfHnmkKi9FOxl/0Wr8Tn/9u4dwRM7rnmQHOElp2JecWbhj8=@vger.kernel.org X-Gm-Message-State: AFuF++mjZ2qX9Qjk2N5lY37TG69/jsUBCAcrPymViFvhr7VUdjhYF5oI I1S9MAVmb663T4/MdH6bvsg4wQ+BemjaM6fCF35qDvS4rcZb4fyO1E66 X-Gm-Gg: AR+sD12DyRC1TzwW0isihRZWv6XyQkYPI3Vbxxe7F1W2de+AzaAESwJg/XWr2RNiqwn 8xFdDDLP6n1K+7fckGUZInIw0i7D+HrCcrCsmVbuxk5KtXxbi6KJF7xq+pyHSLgn0nRF4NYX2b7 JTBOBlAhHtqvhsmx1JhQ52J599E0vFzcmLZnn+a1zQej68EQY+zpBtF0o/YHFG/RTK1+B/R40KL WJCxe16wR9n9bZZpGc9unIfJNI92nQ581985C4vbsZObq6Oa4QoH3JKyWfR9N/RnG0W9ZwxW0fm vtcGBQaxhCykwR00UtMl4o2WUeRikZFUpX4AwiYtluObK49wSWcdk0JbjkTFfF8M8KCyVudWPfl zJkzIUpHZX8Mrz9dJU+1lf+jsP/7IlBkSPhDJdlqTfzEaVjVrmDz7MqjbxYrBCJOms2Hsd9FFNA CI97ESHkrlzhPnk3cE6ukuJatDXr9JWuQbZuu3I//tw2pzv72CcgYIcWwv7rFgOcJhhuZkyY9u6 /V6E2M93C71DPXzPS1vq+E6hggJy1+hZt7rz9BrV1fqVzHb/41DNKMuFdhzoL3c0iYM4ni5aD7G oZLP/cqLsUbBxvm+D4Z8IHcJV7KuqABIkJldojzWPRaOISjihf9bBBa6pPtJ8PyNNCi3QZVJIgP 4E6bdw4eWk3n8fk8Ak9TmwwmcCPmNJDw9X246pyP5d9pMdTzp5/xVD1B4SqNORzsWhx3EJWw= X-Received: by 2002:a17:907:a089:b0:c21:450d:cd88 with SMTP id a640c23a62f3a-c24924b8000mr2775291266b.6.1787653383180; Tue, 25 Aug 2026 03:23:03 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24966f6b48sm1773503266b.33.2026.08.25.03.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 03:23:03 -0700 (PDT) Date: Tue, 25 Aug 2026 12:23:01 +0200 From: Joshua Crofts To: Esben Haabendal Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Martin Kepplinger , Sean Nyekjaer , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Martin Kepplinger , Christoph Muellner , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 9/9] iio: accel: mma8452: Use proper error code when missing device model Message-ID: <20260825122301.0000531e@gmail.com> In-Reply-To: <20260825-mma8452-open-drain-v6-9-9b252804ee80@geanix.com> References: <20260825-mma8452-open-drain-v6-0-9b252804ee80@geanix.com> <20260825-mma8452-open-drain-v6-9-9b252804ee80@geanix.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 25 Aug 2026 10:27:47 +0200 Esben Haabendal wrote: > The device is there, but we don't have data describing how to use it. A bit of a weird commit message IMO, I'd do Switch -ENODEV error on i2c_get_match_data() failure to -ENODATA to satisfy the IIO coding style. (but this is only my opinion). (We recently had a few conversations about -ENODEV vs. -ENODATA and while there are a lot of uses of -ENODEV in IIO they should be replaced with -ENODATA when checking *_get_match_data() results). > > Signed-off-by: Esben Haabendal > --- > drivers/iio/accel/mma8452.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index 4a1eb196589a..42e3371cdb1d 100644 > --- a/drivers/iio/accel/mma8452.c > +++ b/drivers/iio/accel/mma8452.c > @@ -1595,7 +1595,7 @@ static int mma8452_probe(struct i2c_client *client) > > data->chip_info = i2c_get_match_data(client); > if (!data->chip_info) > - return dev_err_probe(dev, -ENODEV, "unknown device model\n"); > + return dev_err_probe(dev, -ENODATA, "unknown device model\n"); > > ret = iio_read_mount_matrix(dev, &data->orientation); > if (ret) > Reviewed-by: Joshua Crofts -- Kind regards, Joshua Crofts