From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender5-op-o11.zoho.com (sender5-op-o11.zoho.com [165.173.182.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 665DA480357 for ; Wed, 26 Aug 2026 21:19:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.182.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787779186; cv=pass; b=XKicWw1yyjPBEXbxWm3eP3evdHYJqo+XbiF/buam/GA8GcEW55OZ7nhlE55bcjQrYrSnGqpa7KPtbN37VCcVk/HUy/59E6MlwvDrfvpxYflkk7/UijxbL21QLHbTcNbwUpQTDmpe4QAYwoihg6FHU5t1p1F8KgGHeGjOUpgxmmg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787779186; c=relaxed/simple; bh=agRP0RpRtCDjA7QtcvATBit6UJ45pRR68pISHX2erxE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YnJuWHbRITZuR5Rzoa28OICqGM0OVaIhi8Cr9UE5x0Y5tCu56w3hh4A/t1FKivUTqjyEJS90UktP/Yhjhlz/repLd9bpGCkMAN6EF9kQr5q5RkgqIoKrryJC9Lcz/wFvgwrN6BSSvWN1dKwlHum1AEUziUdmran8S1CHumwuLZo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=EbF07MB3; arc=pass smtp.client-ip=165.173.182.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="EbF07MB3" ARC-Seal: i=1; a=rsa-sha256; t=1787779150; cv=none; d=zohomail.com; s=zohoarc; b=Oj89sstpMjcchaxG4fI1/r/ujbU2l9yMcqtiXa8kKgO0x0i4yfClwInmFZEAkScqVhe3fWNBhSbBeePPKK1kq+XP6G3LIQjAf3qKWckAhCVMEomZ/oJvFkbXuNmhsmz89VOEQz6vULAj32fS52RHsm1wa/eGKzoYJA4gcAxBtZo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787779150; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=mL/t6AtBgho5ZUgG0J1sVf7T2HPplYZioEmnXUNCwoI=; b=LOn8kEeRUfiLMM7jnPpVb857cufSvXIEqPg+FhI0I4UxbqVKWFANYO14bxQTJ2F3LhTN2ALEi7gCdl5ZtZP5LhygWykV/9gqEfZHQWylCZeUoMdm/Z2jmDXDFfA7CBUznnE8bjQvOHnsn6864dkVgwi5xK+z0+NBOVloibcZn4Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1787779150; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=mL/t6AtBgho5ZUgG0J1sVf7T2HPplYZioEmnXUNCwoI=; b=EbF07MB3zDJ3QDEYdie4LlCKU7pyx9yPdwWKBkntfeL8V9wIJfbpM7xhVn+JrZVO MCnWodfMxEi1kiQ7o+5I1DGUjtsmUvV3WmXTdPAio3t/ORuzurIZbNDX7OZUxeSagM3 FPfO68wT7hQNO4+AfSvxcTxoBroVgy0lc35BRWpI= Received: by mx.zohomail.com with SMTPS id 1787779149171241.2427339605357; Wed, 26 Aug 2026 14:19:09 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Wed, 26 Aug 2026 22:18:11 +0100 Subject: [PATCH v6 09/16] drm/panfrost: Add warning messages to fatal error conditions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260826-claude-fixes-v6-9-78119af409e7@collabora.com> References: <20260826-claude-fixes-v6-0-78119af409e7@collabora.com> In-Reply-To: <20260826-claude-fixes-v6-0-78119af409e7@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1551; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=agRP0RpRtCDjA7QtcvATBit6UJ45pRR68pISHX2erxE=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqj1gMrQr6lFPoC+vpxQiWomb5BTbIcGfJky9/h nn5hY76YwqJAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCao9YDAAKCRAOJn5M7lND PVRQC/kBmemrgp09dv8de8omyyEJq+btguQdF99PkRTLpAXGUeg6e1tuCAf1327Hg1KUWR1gBJD GXf5jkdR2gibbLXJZVSlJozliz0HBby3+ntRaVB46ob9JjtXVzD/gJC8/ziR5nmlVBzlGP81RxW p2Ywpsb5p9s2f/IKIb95JNypzjT89c9MnK5vntSENGJ328VMPOuxDeczONAhftxIatsuVb8vA8G w3UJZ2WYqH00cwiwpAFTh1rERXlzjFDc0jvOoavblyp0zeKYGZgfSeq7Gm2GdptbfZmrshOnQ9L YmguzxKygEuH+zIYMF6iRtocwUTsTMIA9blAB2azK4wFBP1RSdJxFba7pTEjkxT1hmgXw2NLE5N olnqMzKeze9nN6YeTu9Cdsz9/BZ0RCDYM925M1UaBD1ssFOkTnJ9KkPVIhl0MeyTksG0Sjf6Ask t5JplfYTOiincGgCksRe+Q2cAWlatFCa4pZZmjlbFeI1v5w0US3WXf+G5fB64IgdOSmRE= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D Rather than just failing silently, let's warn the user of device remove not being able to take an PM reference or the PM suspend path still reporting inflight jobs. Neither situation should ever happen. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c index f6066aef4766..ee4c468b882d 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -9,6 +9,7 @@ #include #include #include +#include #include "panfrost_device.h" #include "panfrost_devfreq.h" @@ -367,7 +368,7 @@ int panfrost_device_init(struct panfrost_device *pfdev) void panfrost_device_fini(struct panfrost_device *pfdev) { - pm_runtime_get_sync(pfdev->base.dev); + drm_WARN_ON(&pfdev->base, pm_runtime_get_sync(pfdev->base.dev) < 0); pm_runtime_dont_use_autosuspend(pfdev->base.dev); pm_runtime_put_noidle(pfdev->base.dev); pm_runtime_disable(pfdev->base.dev); @@ -516,7 +517,7 @@ static int panfrost_device_runtime_suspend(struct device *dev) { struct panfrost_device *pfdev = dev_get_drvdata(dev); - if (!panfrost_jm_is_idle(pfdev)) + if (drm_WARN_ON(&pfdev->base, !panfrost_jm_is_idle(pfdev))) return -EBUSY; panfrost_device_disable_hw(pfdev); -- 2.55.0