Re: [PATCH 1/3] dt-bindings: media: i2c: Add OmniVision OV32C4

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

On Wed, Aug 26, 2026 at 08:34:01PM +0200, Róbert Božik wrote:
> Hi Conor,
> 
> > Where do this name and frequency come from? pin name I presume for the
> > former? Is 19.2 MHz a mandatory frequency?

Please do normal inline replies, instead of this which removes some
context.

> The name is the sensor's input clock pin (XVCLK), as in the other
> OmniVision bindings. 19.2 MHz is not a requirement of the sensor but of
> the driver: it comes from the platform (the ACPI SSDB of the laptop this
> was developed on provides 19.2 MHz) and the register tables in the
> driver are computed for it (the internal 96 MHz clock the timing
> registers count in is 5 x 19.2 MHz). The driver refuses other rates
> because I have no verified PLL settings for them. I'll drop the
> frequency from the description and keep it only in the example and in
> the driver. I've also dropped the sentence about what the driver
> supports from the description, that doesn't describe the hardware.

Great, sounds good to me. Thanks.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]