From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75F6E3382E5 for ; Wed, 26 Aug 2026 05:21:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787721673; cv=none; b=RVhxmDExZ5LGkJ4JbZtJnFTXYbB+U04EVOvwPeN7NdvO71j/bwM+NirhnPhhlVAP2DvXWQAtBi3IQcQrBYqyTQ0EanPbmOsmBq7FajSqAkGQML61jcfs7Y2JVRjbobpggSe9uxnf8aWO9txuYNjUCW7ZshqPJd8lrz/ETOWj0ms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787721673; c=relaxed/simple; bh=w5KSPtKV0YgCLci4joYya/6i/uT9GHt+Vm6dHfbUJgM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VqwM/cSkV9wzUz3D21HnFbz0Ej6EjQGsCdP7FtPjZtk+fPfP8lfBPRr3xx2/XvKDVBZ09zfM/hEbV5UktXSNuLhWJLqLZXDDO0HZHeOT0SXmbOoBugApd6OiXkDgxsiw3QBhumdiP6k7i2wonKu0uqMk6j9Br4YGoBNoQ2mf/+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dxh0xi1e; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dxh0xi1e" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-cc1c9879395so66705a12.1 for ; Tue, 25 Aug 2026 22:21:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787721671; x=1788326471; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=zNJ3kg/OSSC9Faib6mXlgA6wYEseQ+hAgHk+fzn3jtA=; b=Dxh0xi1eFGUDIzk6T0bCdhE7cHJB20gfbFVAF4pljQfix3uc4XktLI2W7Uh6jqyC1l mjLDub0fdbwN7Q0E1M6h3d4YUse9K1k3l1fu7npPcs++tcNJcskdBovSQmbrtNJpcNkg dzQQDjJWcVEcvviGThLVm84IuGh84bwr1ArLAOSBs84iCRabLxv74e5M9VVxnmxsYCQs VkCXH9iN0WsgKIVL/dQ6r9XMxM5JFfuDhctE066hgmzOSGbUJXUigZ4OoyAmSaplo9Ds dcG3y6eHWOhlxyfrVcTrJf1VziGm++1gSMb09tioWDtmiJxbl/44qqfwdv9U4Jn2zucq Sxpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787721671; x=1788326471; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zNJ3kg/OSSC9Faib6mXlgA6wYEseQ+hAgHk+fzn3jtA=; b=MeMUmCUFkPaV0jSYXsnubeiKuyh3imEZhznCRIh2RfIeNRQm0ts2CSjSwWhUAiENKn 8tqSAcy6rfSnk5aWe56jB4ny1y5YsKw5oUM01qOzVVyQA5HIXOpv6pNlrrea14eO7TBs Hf/Q9cE4UGzjXX7nxoiiZeZ5zLnShuzFO4A+qBmFfwz4aiETOP/VYmBoXY7uQC6zWS5g ClNDqWF0h7iSRaFyxOldeqMfcauIz2MuKdPv7oLEqyy4kRmcDONFdXElTBxQZCnqy1EZ 1cClz5GE6csBwtc3ES6IAh8Dvo1jgEngIszWp8qVJ/ea1chVSzLTd41PuZr+6OyC6geQ vqWQ== X-Forwarded-Encrypted: i=1; AHgh+Rp9e9UDp67MctulxhORMGQ/u9+30xM3ADECS3EU8jffjA/9TS6JB7kQfu+rj6Gsl3zyWvctvQwya2mrAms=@vger.kernel.org X-Gm-Message-State: AFuF++kftIvZ7ZGH3MLbK1SmzadEpnT4BKhWG7949zawLHz+AuKyOYsD mjh+Kz3jNktZOKRnTNxl15wXMXek2I3Cet+m8n8t7IcHZoNY4GfTWGWt X-Gm-Gg: AR+sD10dmkpnkvsy+MsrRwJALtYLrdqvTpxYbGWC/txSwn8hEi9stSDgsg2MyIJL0pr c/ducEW2Nf8yMF8P3crMZBaRtQyHCl4EOfZyMLJk01Nq2XPTg5FCotC/wHisaEFr4WzqVG0l+f/ lMkXlCYFgWkPaQzX+BkvpN+jS5dK/8NluX5QbZiDVtPHibnnKoaB9mmaF1aD/yHZuvwRHahdc3f I1xCZ+H1jmBYO1kLDEaOvsTCGcO5kjyafa2sSC4lL4xjSKMU+D5RjJbWncqEijeYxuIMNU9rESC MkXPvBFKbFV3CMS9PpW4f896lcJa9/b5X8jBHOtTxevNVOVHUkvY7mlSAm0YxHAeAJEhRSvdCkO 1OK0FbUKEbi2THm0/zB7zpeO1nThScPRsgRzygBOT4Y0kfL/0VeQVqiSMAm20Ivtj2W/KNzxRqo kiiGoy1f9jhBh2CJRgS4PeayxZbEL5ZcmGWSsGj4M15luTONg3CKRcrI2omjpzNmO1KtHNHyvJs cAaQg3Seo0scgNyC6N+C9n7bb//84MhZosJnq0p6KjarAvLaSEE7MTBzlCxZxJ3MzAy2weC9d3M efheHoxr6nGuD8U= X-Received: by 2002:a05:6a00:6c8a:b0:835:6388:655d with SMTP id d2e1a72fcca58-853752c58eemr7806183b3a.14.1787721671319; Tue, 25 Aug 2026 22:21:11 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8535d344602sm521443b3a.58.2026.08.25.22.21.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 22:21:10 -0700 (PDT) From: phucduc.bui@gmail.com To: Alexander Viro , Christian Brauner , Jan Kara Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH] chardev: check return value of kobject_set_name() in __register_chrdev() Date: Wed, 26 Aug 2026 12:20:55 +0700 Message-ID: <20260826052055.19201-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The kobject_set_name() function can fail and return -ENOMEM if memory allocation fails. While all other functions called inside __register_chrdev() are properly checked for errors, kobject_set_name() was missing this check. Add the error check for kobject_set_name() and jump to the 'out' label on failure to maintain consistency and ensure proper error handling. Found by manual code inspection. Signed-off-by: bui duc phuc --- fs/char_dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/char_dev.c b/fs/char_dev.c index 00229e25c10f..5ce5423f6c99 100644 --- a/fs/char_dev.c +++ b/fs/char_dev.c @@ -280,7 +280,9 @@ int __register_chrdev(unsigned int major, unsigned int baseminor, cdev->owner = fops->owner; cdev->ops = fops; - kobject_set_name(&cdev->kobj, "%s", name); + err = kobject_set_name(&cdev->kobj, "%s", name); + if (err) + goto out; err = cdev_add(cdev, MKDEV(cd->major, baseminor), count); if (err) -- 2.43.0