From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FB9F3803F7 for ; Wed, 26 Aug 2026 06:42:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787726560; cv=none; b=CdL87xFdlB8N2DFqA91f5kvM225P3300fBxkFnVQsZeBCnaBhVjFnScF2i8XwD6OzfHaEZe+SA4LNWUSQCIcYNVNbYZh8K687p7X4AcnxFH82C8Ji0ov4jog45J4vmMlHumjiESxJazeetX/XUctA4qKnN6a2rTpETA1ymO2z3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787726560; c=relaxed/simple; bh=UUWuO0QwoebqATJxWaCtzKnjbyKj32irOZFH/34tJ7Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=fIP6EEGmbkwlJfLhE4Ej9b3DkiiEulvtuPSTIg7tgVgLXHjTVkdth6vs9hUxFM3nKApgQRxprYnismZrI9j9J5a6h682J8omLSm/PqVmg4B2BryHzpabaCwgIlAzjoRmsg4XnetwIRN3X/pPukpLtmO+iDIWWxVcCNHqqu51vJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pvbVP870; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pvbVP870" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cf50c6f235so4288545ad.0 for ; Tue, 25 Aug 2026 23:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787726559; x=1788331359; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=UUWuO0QwoebqATJxWaCtzKnjbyKj32irOZFH/34tJ7Q=; b=pvbVP870GHITDsawvgcV4sKCGZB2UNbXZq5czxR2QOpYQhPIR+CiTrVhqT79GwmoBg K+5FbXvwKVSL/tOdMPETnBIcxA1dWgZxjU9Z2+Qic9dyX6x3iVuoMbm7qRxa3oagCQsn kQdUR7eBv8z8QGBlrO5jU/hAjzmt/XqmOF7OPRBITFfMjJXunsS6FXruKbWkMQ3/gLoR Ivl9J28HlRTdwIAhh+bloxMQkEV5qxTR4V7sfe/C2X4KTnTEkamqYJhnZchbbTLkL1c8 waEKRGSg5m9J4KzBBg5eyYtyG1GcHfCsC4sgfv0iNGSQZBoWs2garN/Qq5ofoIxf67Ay zUxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787726559; x=1788331359; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UUWuO0QwoebqATJxWaCtzKnjbyKj32irOZFH/34tJ7Q=; b=AuEuQKBVAHFu/dLifoWLjbpdsSFcg5blKLw6IZzgwkH5G2wZ5rus+XpoXBiGR2dXgH Bncuw/MQ/HZ6QRqMHvK93CzMRHhsvH8aTiqmiVA6tbs4SZq/zqdwzNLRgeEEiSQ/IbRK D0AmLLu56H5zuX0KH/PkO1G2T2FZaUJsrGoglaDdRgyNtbq6BKcOHoTd0k1dyqNiQ7tL BGOMUW5y9UE3DKHQRQUn0OGV2P1KRhSLUdjgRWl4RXamE31F2FbuCCFv3ELDN5u6bNvz kkRNS1+ZKI8wCNNWCQZIM2ur4AIADa7o3SFz6LF8pld+h1P3uArtLpP0lIeWOUOvDiMa mw4A== X-Forwarded-Encrypted: i=1; AHgh+Rp9OhSx6N5kcPO8kT6t5e8a0B0cLQFzak/deQiZ2GlkGOKX3rh0iZtqWeCvmwyziAAPcUtFqO0QB7sE4j4=@vger.kernel.org X-Gm-Message-State: AFuF++kzG0rq5nqkx3OPW0BlApfRYDHuy4TGFHERHPOBeSlMYzNdbzst g7DzNHZQN67KAqpCJKoyZVwID2Cbr9Jkx8orPkayWJyOtMs6JXnCwMg/SiFgrg== X-Gm-Gg: AR+sD100AON5IcergsEE1Hy3mc1YN7G6a5nky5aLPAUpz7KaDbOkkV5DB4HUcLOBxp5 U17/MuWjTYsfmhpX6JBVSYw+LTw2g8VrQOh/Y/Ywf9mTUHJGuIS9U/jhpzzPcVNVIScdPACxEhZ RzWAWforLFHL/rTZKKsUYw85qYf7fHC74LGtWvFYqe0AJ+n2W/DgL+suL5nbpwXaldUZtPeELRB SyB8bzvNbkI55LFGP08tHvJ2Zb7O0ezSv/R+d5irFOg3a88NdVv+FPNeQ9VdHL/nXwFPC56j41e xDRAmobxHEsTsV7Q3SgBx+RbW+2MVQANgw41l0Zag9xgvQg1vzMpC2mtXK7syaCMpwTuP2yvfD0 f5tLUBkljHY2IQa+X3MHwiVDwt9Bmlz7hZMyv8QNhtMobnON5a+rUa4RKrtiSYBjVj80bD4rm6Y 9lN8UoNKjjQeflnWT7YwI2Kve6Z14F7KhqnzPwVAaKTc4FrjTP8GPcRm+E/ZpQez2w8l9IHo/qM K1lXjY/v2ePvjSN7ud38dyiDA== X-Received: by 2002:a17:902:fc85:b0:2cf:8131:75f4 with SMTP id d9443c01a7336-2d707bab9efmr70947645ad.11.1787726558635; Tue, 25 Aug 2026 23:42:38 -0700 (PDT) Received: from mi-ThinkStation-K.mioffice.cn ([43.224.245.235]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d704b9f73esm4284795ad.39.2026.08.25.23.42.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 23:42:38 -0700 (PDT) From: yewentian395 To: Oliver Hartkopp , Marc Kleine-Budde Cc: yewentian395 , linux-can@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: isotp: implement N_Ar timeout handling for FC transmission Date: Wed, 26 Aug 2026 14:42:33 +0800 Message-Id: <20260826064233.3248193-1-yewentian395@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 24.08.26 20:03, Oliver Hartkopp wrote:=0D > Nobody cares about so->frame_txtime and therefore I will not add any=0D > extra complexity to check for Ar/As timeouts which have no real world=0D > effect.=0D =0D Thanks for the detailed explanation. The simplified model makes sense=0D given that no real-world user depends on strict N_Ar confirmation.=0D =0D > Btw. while double-checking the code I have seen, that I was missing the=0D > addition of so->frame_txtime when starting the rxtimer above.=0D >=0D > I'll mention you with a Reported-by tag then.=0D =0D Thank you, appreciated.=0D =0D > Please also note that your patch would not apply on the latest upstream=0D > isotp code, which does not contain "*(u32 *)cf->data" anymore.=0D =0D Noted. I was working against an older tree. Will rebase to latest=0D upstream for any future submissions.=0D =0D Best regards,=0D wentian=0D