From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAD423C1992 for ; Wed, 26 Aug 2026 10:35:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787740528; cv=none; b=EiNg0U5as31eYGjEDKK7JGeV83kxyhOLcqQMg9D0NPRxXB5QtTanXQwEHtaO4WFtbVQRkvd7gzDGdXe5T1fJjwk/ZkTbJsCg1InQEZ0an1oMI3I4OtCjf9H4XpS67oyS1xYJU4UtzUx2de61aFD3iyiYyWRqaziHMvB0iY50TQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787740528; c=relaxed/simple; bh=y/qxAQMIW2CMYc/bzkgwh68GybbVe61ppJSHYTFLsDI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fe9eM3JYlLCNX3uFMsalZMD5ql4+hkERZ47ObO0Z8GzX8DqcIljzVIeuzyGHim1dqqy5yEY5HM5MzY88rn52bQxe69OeQyGvbiUWEjQZrtspg2D9mR6eXbMxEDAMPTbnyO64HuhHHY1rBsOJyzk6ui04SLjySTYOLpe3U6hAYOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HtOsLMjx; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HtOsLMjx" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-39266382df6so901803a91.3 for ; Wed, 26 Aug 2026 03:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787740526; x=1788345326; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=5X3ww+aTNIQSQQs0nmBvcYcUDlxPlN9HB4Ktt9oSZxg=; b=HtOsLMjxStDwUD9d75FjNBEmCyBBYq8irE8OROfVcCUOHIuNZIAYJ+ccXaoLbiIilK 3gi7ynORW8OpxVtaD1X5E/SynILXtBiTEbf15oEQdnYUyH2jNCsfbf8mtB26wQ0lIUpR xY+rLsRlHArwoF4U6TSqZDna10jQlsaTu8LB4HiDe+Est9a9qjEGHeO2OngfVGc10Gn5 JRcVWIR23/8iBI2TP6slne3iqqsSOp4a3RkmVjZ/hsnKEnTHg39Lo8tCTYi/Te4omGhx BJHL7qP98N0bIRoYqwcSmeVQBs0aSzlAafK9aEW6PNvKy53P/pQBNgtcLBIr1GRg/RV1 WVmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787740526; x=1788345326; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5X3ww+aTNIQSQQs0nmBvcYcUDlxPlN9HB4Ktt9oSZxg=; b=qWh6uhlTJIWBxHpzZj+3vTleAOuDAND98gcZR6sJSxVHBYLNfyeFGo37YYcMvUPRY5 3k/2Uqtjo2Wx3eEvbOlOrupoe0U33LHtlLH9+s3shqsJTEvryZYlhoK4CQeUODZS4efX 20RYqw9vk5srhE1jugypMjDGOCgYsxIte/GOtYHFbSmTsuIMivfJ3EAgu0we6CfmfHAO yE0d4R7CL2YpZIIurr7JLD3RE1XvFSfIGOzezGNUvY67H0noS9a5Flv2SoM2rusAvz40 YW7+fY55nio0AIJiboJSfIUCyzyqTAVH+H9jYxfJpqC4/A5IT3JI76Gqb649lG0QffGV gDFg== X-Forwarded-Encrypted: i=1; AHgh+RrVfjAOi/sVkwzsugWfeOmZF7zTnMNl9/CaeGFPjnCzG48vrjIbUGil9AXUpKYzIo7qn3ObQL1ZMZOhJiI=@vger.kernel.org X-Gm-Message-State: AFuF++nxNJ+f2DH/jWB9SM6FtpmCoXMtkf5LQiqLvkZ/6MoPLxz/koEL PWkqC7MbFU/mmouE4W7WKYIaejUfCAg+tYQDrcxcwBJr94BHUo58Uwb7 X-Gm-Gg: AR+sD12HT1kt2diOyqOEXlii9p0Uex9c9O+JwRGBJ73dQ8ysS4NzqwG0A832uDL2iHW TRS0+cJCT0dlzKJwR1Y5+cSCeEl7kCVweRYBA4sI+so9rcJM6Q6kjuT5QoZK9cJD/VeuPRiBlvu cVI9ulkdKxSYssnsHDaZAqOsocHs4y4UprGJxQqOZgULCgITrsNNSQCd8JXcK/b49rsYQVP3LhM PKi93ARsJK3j99tayhQqwjU8K6uT1LkG0qAQiiqTbZExJOk30UQTeRqb90D16YiZOTCiiibxkeN s3c89t10viYF1bQ6hWzRgH3pk0TEPIHvrgz2dC2gN3h4faZO6Vymv7lK26kP2zNxkElD8cOXwiz Ol1ac3+WDW0GDnB1If+4yEKxSeCTcghVebfACrN824PVPPa3+1grGG6GMPTcvW/2SSNk+mUKCnx 13V6gNImdlBFzXi2hrWKa1LCr0ULEC0T5ZkTj+lo4cTHSy5+wUDgv8sywhx5CA7fRZdsTv5HYLn QqbeFY011Bs6BOjRoRfw6sQzqBcV93gL1uU1kLL94xqfF6ORdcc+MRCcf6iRo5KxLeYwwJMRCCa frayEg== X-Received: by 2002:a17:90b:1649:b0:37f:fdc8:71b4 with SMTP id 98e67ed59e1d1-3966d3fe36bmr12075307a91.2.1787740525585; Wed, 26 Aug 2026 03:35:25 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3967591f49csm676654a91.3.2026.08.26.03.35.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2026 03:35:25 -0700 (PDT) From: phucduc.bui@gmail.com To: Wei Fang , Frank Li , Shenwei Wang Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , imx@lists.linux.dev, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bui duc phuc , Frank Li Subject: [PATCH net v2] net: fec: only stop PTP if it was initialized Date: Wed, 26 Aug 2026 17:34:28 +0700 Message-ID: <20260826103428.32807-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc fec_ptp_init() is only called when fep->bufdesc_ex is available. However, fec_probe() unconditionally calls fec_ptp_stop() on the failed_init path, and fec_drv_remove() unconditionally calls fec_ptp_stop() during device removal. Check fep->bufdesc_ex before calling fec_ptp_stop() in both paths to avoid stopping PTP when it was not initialized. Fixes: 32cba57ba74b ("net: fec: introduce fec_ptp_stop and use in probe fail path") Reviewed-by: Wei Fang Reviewed-by: Frank Li Signed-off-by: bui duc phuc --- Changes in v2: - Handle fec_drv_remove() as suggested in Sashiko's review. - Update the commit message. - Add the Reviewed-by tag. drivers/net/ethernet/freescale/fec_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index ced4dbf8cd90..794ec427b0ee 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -5457,7 +5457,8 @@ fec_probe(struct platform_device *pdev) failed_irq: fec_enet_deinit(ndev); failed_init: - fec_ptp_stop(pdev); + if (fep->bufdesc_ex) + fec_ptp_stop(pdev); failed_reset: pm_runtime_put_noidle(&pdev->dev); pm_runtime_disable(&pdev->dev); @@ -5499,7 +5500,8 @@ fec_drv_remove(struct platform_device *pdev) ERR_PTR(ret)); cancel_work_sync(&fep->tx_timeout_work); - fec_ptp_stop(pdev); + if (fep->bufdesc_ex) + fec_ptp_stop(pdev); unregister_netdev(ndev); fec_enet_mii_remove(fep); if (fep->reg_phy) -- 2.43.0