From: Zhan Xusheng <zhanxusheng1024@gmail.com>
To: liwanwu@kylinos.cn
Cc: tj@kernel.org, void@manifault.com, arighi@nvidia.com,
changwoo@igalia.com, linux-kernel@vger.kernel.org,
sched-ext@lists.linux.dev, zhanxusheng@xiaomi.com
Subject: Re: [PATCH] sched_ext: Fix several comment issues
Date: Thu, 27 Aug 2026 17:56:35 +0800 [thread overview]
Message-ID: <20260827095635.535908-1-zhanxusheng1024@gmail.com> (raw)
In-Reply-To: <20260827091411.973621-1-liwanwu@kylinos.cn>
From: Zhan Xusheng <zhanxusheng@xiaomi.com>
Grepping the tree for the old spellings turns up exactly the lines you
touch and nothing else, and the new names hold up against what the
comments around them claim: __setscheduler_class() does return a
sched_class (kernel/sched/core.c:7608), task_should_scx() is reached from
it at 7617 and from the sched_fork() path at 4862, and the @running
callback documented at internal.h:439 is the one set_next_task_scx()
triggers.
Reviewed-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
One thing for the changelog rather than the diff: it lists three renames
while the patch fixes four sites, because __setschduler_prio and
__setscheduler_prio are two spellings of the same stale name.
Thanks,
Zhan Xusheng
next prev parent reply other threads:[~2026-08-27 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 9:14 Wanwu Li
2026-08-27 9:56 ` Zhan Xusheng [this message]
2026-08-31 16:53 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827095635.535908-1-zhanxusheng1024@gmail.com \
--to=zhanxusheng1024@gmail.com \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liwanwu@kylinos.cn \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=void@manifault.com \
--cc=zhanxusheng@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®