From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46F563E3150 for ; Thu, 27 Aug 2026 08:30:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787819425; cv=none; b=Pmm0JCV1gXdLnNlqVzAIN0uh6byVdZJ9joGL/FV6aj+egb8tn5Vo1ZY1IqRO25TRcsKhjkeIRyC6Cpi0XsZzdglz0kqBXNnpj0uqkN7DbXCOPk03YYKvaMbo0qFlscqlb/VEFcfLQsUcgl2oa6XwVX7LUBrzKIJFFHbmdo5Xur4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787819425; c=relaxed/simple; bh=yJpyF+5Tc3G8tE31WpMqXfWM3y43ClMVTYl+eMZsTmI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=W0YwD5Bp/jtI9bAX+ulQTsAIIzWMvLmymKg4+gocJCIEtlXQRjKOQfmPA6jMZ/q6TQa095O8fdRmgAaiaNPRejJv4AdlEjwxLUQoFzpuY7s9WJfaZRKK5bHL0yU+ApoDwoAFLTVem7afILOuaZ2TXNbfTB3EHw0d77TrYShhISg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aJamGOWR; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aJamGOWR" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-482e257a23aso985816f8f.0 for ; Thu, 27 Aug 2026 01:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787819421; x=1788424221; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Gv10IZgS+I8/TcY7gcREpSsUvzMsxKqW3sbwG8Jb3QY=; b=aJamGOWR4RskmKAgdzroTT/6XZdn0jLXN4eI42AFneeGhUeKClD8v+xJHo6cd5//dR l+7TljvSWDuY2EkxK7lCpsSrJbgYwL9U7KqMIDJ4IH7QYhvaVE/3Gb/lzDwSVHjgr0pu nBm86C3Bg69rJtasMMPnQgTISlRCTkJ0O6l1sOvee7utl6ZiIrNh6LxGsqMaHE66u6rN AEPpTQoKZSnri660Aqi9iWkuaIVfG/kJwvOd7VKTc7Dic3OkMayKLuXFThQ4bCRN4qZf PNQcWp0xRtx18Z1Cs+wQAlxRcMFLCLMTQMnwQz5yukSyzYipkXQkcDT+XGnyPgSma9Zm BNGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787819421; x=1788424221; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Gv10IZgS+I8/TcY7gcREpSsUvzMsxKqW3sbwG8Jb3QY=; b=rjM6UtgqIclSP1GYeShJp9UrBAMmiUYee0TYKEyRUzBbUGIk9f+EzbyrhDyoqVyMke geaHPdg0Vh2hYz5kAIJV2s8H+VzW7uqWwmWCnsqwcbx1ntKKvW70I550d6Ruzhq5jmxM kyu1kn6PXuWlQPgkJhoRXfvMxTE+YjaI+gWRUvjShYLueu7TkvXKjeMOV5Ba+F9kZhVD rVQinC8U4gUTGQEkfU4lmBbWwEGLVUi+0EPK3oQXRVCpMevl+CWE4KIyoLWvSNzKXnWQ Yxr13LctRdFAGAdilCHt4qLZWD3OEjW5KmIE2ITlq6L/2yjl/hpCr+qhS4279+HE9Ufu Aksg== X-Forwarded-Encrypted: i=1; AHgh+RqAw/N6qaXkA3fngqsOr0wkmwIp7q1izhIaHpmfPTCi6oDZbHFS7+cOF80WOse6OIEthtV1kMkURVN+Z3U=@vger.kernel.org X-Gm-Message-State: AFuF++m7JSFo9tPwVD3kLTZ/JK1arCOVQVsBX7kHJUqTpP/gR2P+s5Rf 8gt6uo+BFdXr9dzhPP92n7+v5aPTKsG7KQvvLR3TQEbJsaMzkUlBW0s4 X-Gm-Gg: AR+sD13VSf1MDqY1CVB0mcBh3xmPRqMS0D428i4fzQBzvah8BOi0afUOAxk5Ycr3bOq fByVbHryJMcx2yfH28iAk9Au0UzOhzvZzCpqfLTXT+0UTH2KosEi9wTGKx2L+z/wHZloV1flQdi CzTX5IyFZhPdIuzn7hFYRvRAhVFL+dJP8n9jOPYn0pCXyk98C8PVl+TDSB8Rfc+pw6N+NYO4rLR 5bZg9GEfxqrmDMWUNaj/+4ny3oDTsrsL3i6+rxt7S++qTkdS4n/lmJAubkcShZVDtOxnXI/c4XU UHeF/c8RLMA4wxKsf6j8xcfnHBDAuZfN4e/VXFuYYe0yUTT75HkPC51BgaHCXM0pp1gMV/YwTA0 l8ohlYEUIWWUD2til3lx2zdcDE5smOHBt6Cudi2qS1RHe0Slh3Hyei8jS1Nevc3ki5eBDJudyBY lApX7SeLZJbvYnD4WklvgJIZdBRX47tTqHp5wCWawWnKjADkdY8pjNFphsI9bPKdmRCTvouOuZT iQOd6QAk6ORYlKDx9o4SXaXayJS61yQwmNV0tMqwOcqdvjQx0xdQFP1+ArqFyjpf1ArLNY7bStB PoaNvFR9U+pV5PG8vYPuAkbyGTT0A+Oy6S67nXK+CZjkb8OEZdPpkdS2Pe2ScAAY8sk4WRuKlpV PJWxgXHtMdcEIrsvRUv17xUU2EB7+fqsmXbW+zuCvyWlzHXUJD206qvIu1plGjPwyZjTGTn4H+5 uBMACB X-Received: by 2002:a05:600c:a0d:b0:499:bdf1:7578 with SMTP id 5b1f17b1804b1-499dc6e9b00mr152209385e9.3.1787819421205; Thu, 27 Aug 2026 01:30:21 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499dd56826bsm53438315e9.4.2026.08.27.01.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 01:30:20 -0700 (PDT) Date: Thu, 27 Aug 2026 10:30:19 +0200 From: Joshua Crofts To: Janani Sunil Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , "David Lechner" , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , "Jonathan Corbet" , Shuah Khan , Mark Brown , Marius Cristea , "Marcus Folkesson" , Kent Gustavsson , Conor Dooley , Daire McNamara , Paul Walmsley , "Palmer Dabbelt" , Albert Ou , "Alexandre Ghiti" , , , , , Janani Sunil , , Kent Gustavsson , Subject: Re: [PATCH v10 3/3] iio: dac: Add AD5529R DAC driver support Message-ID: <20260827103019.00002663@gmail.com> In-Reply-To: <20260827-ad5529r-driver-v10-3-38f2be07b824@analog.com> References: <20260827-ad5529r-driver-v10-0-38f2be07b824@analog.com> <20260827-ad5529r-driver-v10-3-38f2be07b824@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 27 Aug 2026 09:34:48 +0200 Janani Sunil wrote: > +#include > +#include > +#include > +#include > +#include > +#include > +#include IIO specific headers should go after the generic headers, it's just convention. > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + ... > +static int ad5529r_write_raw(struct iio_dev *indio_dev, > + struct iio_chan_spec const *chan, > + int val, int val2, long mask) > +{ > + struct ad5529r_state *st = iio_priv(indio_dev); > + unsigned int reg_addr; > + > + switch (mask) { > + case IIO_CHAN_INFO_RAW: > + if (val < 0 || val > GENMASK(st->model_data->resolution - 1, 0)) There is a function for this - in_range(), in linux/minmax.h. > + return -EINVAL; > + > + reg_addr = AD5529R_REG_DAC_INPUT_A(chan->channel); > + > + return regmap_write(st->regmap_16bit, reg_addr, val); > + default: > + return -EINVAL; > + } > +} > + -- Kind regards, Joshua Crofts