From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Subject: [PATCH] media: rcar-vin: Return unused buffers correctly
Date: Fri, 28 Aug 2026 12:37:44 +0200 [thread overview]
Message-ID: <20260828-vin-fix-vb2-v1-1-97eb1f4f75c9@ragnatech.se> (raw)
Unused VB2 buffers should be returned with state DONE not ERROR when
stopping.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
drivers/media/platform/renesas/rcar-vin/rcar-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
index 73cda0e2d45a..f3003dd61890 100644
--- a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
+++ b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
@@ -1449,7 +1449,7 @@ static void rvin_stop_streaming_vq(struct vb2_queue *vq)
dma_free_coherent(vin->dev, vin->format.sizeimage, vin->scratch,
vin->scratch_phys);
- return_unused_buffers(vin, VB2_BUF_STATE_ERROR);
+ return_unused_buffers(vin, VB2_BUF_STATE_DONE);
}
static const struct vb2_ops rvin_qops = {
---
base-commit: 4900cad020c0580dfb1be27776ff10a4ef110cfa
change-id: 20260828-vin-fix-vb2-28e1bb24a618
Best regards,
--
Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
next reply other threads:[~2026-08-28 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 10:37 Niklas Söderlund [this message]
2026-11-16 10:21 ` Jacopo Mondi
2026-11-21 8:38 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260828-vin-fix-vb2-v1-1-97eb1f4f75c9@ragnatech.se \
--to=niklas.soderlund+renesas@ragnatech.se \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®