From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3372038DC65 for ; Fri, 28 Aug 2026 05:06:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787893573; cv=none; b=Y8J1A4DOeSMVwXXyJYfNDI+RDl4q1p6kTaSiOodB/2bM0alQseRV1P1rnkGbG7hm8SFriVMmV3m7QOvbEzW2yVW+2mJyB3HInmZdJ5WidOceAWV4HDb0b7tN6JibRvCQaIoVQC/5o9bdscCjtVkW2HOQaf2Fw/QlyilQiKrAkhE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787893573; c=relaxed/simple; bh=3GhUN1YWxQu4bJXtiFoeLFL4w/RSX1buQvfT36CMNsY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZyOSOgdDHZme2T7kNRuDOWTOYATLympIChEqnXWToHhPghG5y1Hqgji8fjXNMThAjkZ0npyozUTtDpiWY8/W+pvhejbiOb0MZ8joy6ukM2p68Y0/xzJKyJ6NWhER3viNNuH9eL2Y3NgdL+P5uGla8XwVYyXBfPJtbRm28Mxf/QI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=noa2x3j/; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="noa2x3j/" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2d6e954afbdso4485935ad.2 for ; Thu, 27 Aug 2026 22:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787893571; x=1788498371; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=a4ksl9SsTnU1qraDN3sQ8M70vtHGdDPB0HKfqeC0tuc=; b=noa2x3j/O1wRwpqFuCIeimXuxdVUSQQJLIWDxpm7Jjw5WPlsT0PQKWOlaHwQwhivy9 4wZE0GvmNGnjd1AE/UuIA/iGtH7R9MC0mSqbTxPYBHinB6RsTLSfA13XgudLOYllZOw2 yMTKBTQ8mJ80jBotXdRQPOm6gE170hPAIxdX/NZX+usbbqQQVEa/RXTl+0F7TE3EIaOY 7WhO73GWKWICNt/mWEHz/mG1F9za1ndXeiGlyiW6GU3m3OgvOwHJGxzZgMeqifYjKbUq 3UAvKWHYebzhrJkty0KjODB/MYmT35tpHbjyflc0fgDxjyo/UNYJVES9Ax2LC3N2ym9k wS4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787893571; x=1788498371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=a4ksl9SsTnU1qraDN3sQ8M70vtHGdDPB0HKfqeC0tuc=; b=Y0ou8bULV0G/S3wo8sUs9jGDvYxp2U+3r49RSH2cUdzCKkO2uXEuUzIwy+q/xG7zpX GfAkQAeOg4t42NpiE+R0Oqfy+TxY921EiVUSDW8pFfmZOw4aOwIY2vgOaunp5Cp/aWQN uOm9i69/xjs2a0F4aHLcRNFd+JcuHpQDqELYNJbjCf8E8DScOnSCiS/KznPaaOYS10Ag nuuiOOtySqd8W+AQ9jgscAlRAZ76/gKruqp8KwXzHhKW7yqWqx5M942Mw42iMf3vIaJA 9JrXFnIjjfGrf4LIETdttpOMVxV8QFcTboOMfKQS72fyLWZ0X9ti+nWqcql1GqIamg1H H29A== X-Forwarded-Encrypted: i=1; AHgh+Rqa92sJ0kI5cZYjJhxJarljVJJ44OejmP/gCbetkycbfzbJ4eXMCm3mrOweQU5OmJklp6Lr+QI8ZFpe6qo=@vger.kernel.org X-Gm-Message-State: AFuF++lIVBvPBklI6qvIcJIF1ktuBiSqSc2MNRBYi9SFlihxTyNS3mRm COx2CBJflG/I5fezkvD04EPj2DAF3gYFUdpOj7v+/lgUQwkktQ6b41tW X-Gm-Gg: AR+sD12Amt1sP8ONS8sk8hGtNaXx4w34JvWQWsB4mwGSik0YnbRjO0gcTAlWFQtr1Hx V6izOWIaiPeIAF7BqXqMcAcZYKsrLfters95xkTRGKbtjimO+36YaAqD5GUelqNdngRs5I1i00c dMWrG8kWumUCzbruLdo+QwPQ5bI9VwT8Mir4MR+pmvcCw+B+sQlochYhDaytM+k0HaD28WS0CxU wbFrA9dlXhx7/CyyNlP8xAPIfpb0kQsnJZCT4vTiNxqppBp2Xu4a0064vj5BTTw3vnM+yxof59w cCtvksUaYr+HStmscJZbGf92Vj4ENA0Ax3u0TEIFGmaEo4Cj9iRBzVwrbrkoH9e8NolQTloyIw2 6pTmvkWc7TZxHf3789MSPOwQgNzBhGIcw2+4EkSMZdxuJB+sXUeO+DBb5BcgF1Q2vq76N2y+CSf jWMkOM+puKEsMO1CkhKeycpI2r8WpjJNqJsC9XAI+BM0Tu2qFP4JEailNzJ4wx4zDBkVd8VzxKn dqc9Z8Cr6nhYt5ZEfSeTFk9d2i3Hl6BDLpduuc7Go/NcpsKWjFGpNA8GrEshBav8AxOwKENV3hR MAPS X-Received: by 2002:a17:90b:2cc6:b0:381:1f51:1ff0 with SMTP id 98e67ed59e1d1-396d0d92cffmr9327276a91.2.1787893571476; Thu, 27 Aug 2026 22:06:11 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-396dda7c922sm986549a91.7.2026.08.27.22.06.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 22:06:11 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 5/5] ASoC: mediatek: mt8183: Drop redundant probe error messages Date: Fri, 28 Aug 2026 12:05:26 +0700 Message-ID: <20260828050526.590761-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260828050526.590761-1-phucduc.bui@gmail.com> References: <20260828050526.590761-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The errors handled here are already reported by the called functions, either directly or deeper in the call chain. Therefore, the additional dev_err() calls are redundant and can be removed. Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- Changes in v3: - Add a Reviewed-by tag. sound/soc/mediatek/mt8183/mt8183-afe-pcm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c b/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c index 2634699534db..46b7a2bb6aaa 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c @@ -809,10 +809,8 @@ static int mt8183_afe_pcm_dev_probe(struct platform_device *pdev) /* initial audio related clock */ ret = mt8183_init_clock(afe); - if (ret) { - dev_err(dev, "init clock error\n"); + if (ret) return ret; - } pm_runtime_enable(dev); @@ -903,10 +901,8 @@ static int mt8183_afe_pcm_dev_probe(struct platform_device *pdev) ret = devm_request_irq(dev, irq_id, mt8183_afe_irq_handler, IRQF_TRIGGER_NONE, "asys-isr", (void *)afe); - if (ret) { - dev_err(dev, "could not request_irq for asys-isr\n"); + if (ret) goto err_pm_disable; - } /* init sub_dais */ INIT_LIST_HEAD(&afe->sub_dais); -- 2.43.0