From: Mehmet Fide <mehmet.fide@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Stefan Agner <stefan@agner.ch>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Bill Pringlemeir <bpringlemeir@nbsps.com>,
Brian Norris <computersforpeace@gmail.com>,
Alexey Klimov <alexey.klimov@linaro.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] mtd: rawnand: vf610_nfc: fix the OOB of written pages and the command completion
Date: Fri, 28 Aug 2026 10:53:38 +0200 [thread overview]
Message-ID: <20260828085340.3916239-1-mehmet.fide@gmail.com> (raw)
From: Mehmet Fide <mehmet.fide@screeningeagle.com>
Two pre-existing issues found while checking the Sashiko report Miquel
pointed at on the large-OOB series [1]; they are independent of that
fix, so they come separately.
The first has been there since the ->exec_op() conversion: the ECC page
write transfers the spare area out of the controller SRAM but nothing
ever puts chip->oob_poi there, so every written page gets whatever the
previous transfer left behind as its OOB. The second is as old as the
driver: a command that timed out can still complete cmd_done from its
late interrupt, and the next command then returns before the hardware
is done.
Tested on a Colibri VF50 and a Colibri VF61 on top of the large-OOB v2
series: UBIFS write/read-back intact, clean ECC counters.
[1] https://lore.kernel.org/linux-mtd/20260818114208.2780311-1-mehmet.fide@gmail.com/
Mehmet Fide (2):
mtd: rawnand: vf610_nfc: write the OOB bytes on page writes
mtd: rawnand: vf610_nfc: rearm the completion before starting a
command
drivers/mtd/nand/raw/vf610_nfc.c | 6 ++++++
1 file changed, 6 insertions(+)
--
2.54.0
next reply other threads:[~2026-08-28 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 8:53 Mehmet Fide [this message]
2026-08-28 8:53 ` [PATCH 1/2] mtd: rawnand: vf610_nfc: write the OOB bytes on page writes Mehmet Fide
2026-08-28 8:53 ` [PATCH 2/2] mtd: rawnand: vf610_nfc: rearm the completion before starting a command Mehmet Fide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260828085340.3916239-1-mehmet.fide@gmail.com \
--to=mehmet.fide@gmail.com \
--cc=alexey.klimov@linaro.org \
--cc=bbrezillon@kernel.org \
--cc=bpringlemeir@nbsps.com \
--cc=computersforpeace@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=stefan@agner.ch \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®