From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C133A36F8E5 for ; Fri, 28 Aug 2026 09:27:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787909275; cv=none; b=NSbHpmsTQ9uXWEWPM+EB1Ibo1dSC7ozRG7Ob79O1ZryXxdrSGF6hMgD7yLrvuuHMSrRn/IkZL1jvjnj2zXX07/acCojtMEQvrYfU3aQ0h4eg4ymjKLTFkZwTv7L5/ZqCyOsofjs/Z0BHsA9ktici0NWnRG3DQ6b8w+7/uQg+oKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787909275; c=relaxed/simple; bh=I/vYuKgJLTZRgDTqGS1seT20mT5U0t8GT3h0wImZ8Vw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=G+QYZyH9ioI3iPSv1qIBXE9E1jT+EO9AKYxdUsuENvQoCE5+F+L8GW2oesgxYIAh8jMXg9iqIfa6a3rnE563tg62cS722ieAtz7svyrZ8o516zInR+uiIalekRhuWyNrNxjHEj97YEKUWuLhsl07A16rDsx8ARIroNO0uPIaG0A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=niShYthy; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="niShYthy" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2d58efc7356so7262125ad.1 for ; Fri, 28 Aug 2026 02:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787909273; x=1788514073; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=jQoHUJcgX1iG4XupJx9j5w4PxH5rLx3k8eXCcQlCBrE=; b=niShYthyCBpeuzWOcV5jTJI7CpqqtPBUndsHPDmZM+xPVKfFpcVxtTe1k9XeOk7zSo 29t06f7g8dVgZn313/mzZcXp+/MKEnlNcEqK2VTJNrUIRWzVBekPmb92bkuw4789QtX3 A0fr+K05/BUYTasQ0HECDQebdbN9znZMfUBTQ6THhJnYQOU4zlRkl8P4gVGy39TN/p1m gE0LGGl5xw1BFbATrhBuOn2gcsGCB1FYxXLFsAV+KePrbMnX2DeQuRlo6u3qLOq1+f2o mA8V3FIJMSvrRLrL6GO5+Tsy77iDD9Qm8dbqLE5voOjPDKdeyY74DWeBEVrX8cUT4cDl v5Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787909273; x=1788514073; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jQoHUJcgX1iG4XupJx9j5w4PxH5rLx3k8eXCcQlCBrE=; b=lbiAs3hYxbrLEpkFvcwkt8LOESnUWsbECeB34sF257Xw7eJxJ0jNQNXEMax9P/1WJa 3mJ0IaL2GbAscFNbJtTkuh5s3vl2q9mBTQyq4Gdxd7dEs6QpSPPnbM8G9iAhaalwC8M3 sG7xr3OzU8rkQaJRNCYtcnOGX9GQppANxWB39E0U9/l6HD5zdqE0aUGS/3l64OXwGpVo QaHWsaYg9ylrlqU8TSc1IvM3PgSmbwy8XSe3hN3XNHI4xjZ/9K/FQ/LY97HOexzXc2mS 7t3kOtrjzJGklO2D6IFF8vN6VEt6vr8RJsH6xDju0fockSk37r5a8TqAqLraOqgW4h8a JRrQ== X-Forwarded-Encrypted: i=1; AHgh+RpxigaSbg8I/waKTtk/f0LG4x3gePbPYol6I9ofbRVNgoG9JLOAMhNzKyzBDBYZA6bq/Ilu45LvnqtZG5c=@vger.kernel.org X-Gm-Message-State: AFuF++k3V9ALlljr9YzGV9/MH5WAt3ANiZ95trmpHLi2aqMOns71yTNR CnWuwmGucU5kiH2ZP8DDtPjW9PIvhKvwPWlMaHkPpsOj8k+ym+ciduBo X-Gm-Gg: AR+sD10z4sdtWo7ijmK0On2LtAGJM3dlf+LEfK5t6V7vhgFWCHPtnH8glFgRKh25xtY sTVTKGFwO8BfxdW3iaZjX58Jglmqz1hNOC4mbf6YqMeGogliAu6IuDE1de7VodPajN07CaQwfRS tduGmMyrT5usSAN8YzNCjiInFlFRHTcVpPlKdY31pb7y7/r1yautUVn9NN2qEU7c4KrpWMpdV/n unXZ9iVfowcI2O8gJt58RdtRYpl5xMt4viWL0JFRPQLY16eOZIgWAKSYdoPA1EBYRh0maKe/lW+ wiym568gZ2ZFHPmKDCbN0hf/YTI6p+37+spvoxp2c15EGye3UNSoWStYoNY/k1CkFMX2lmzBYC9 4EuNRKCOPoAs1y1AONgfCixGL9khcrZWV2V2bTl2xZ9t5Z9PBpIgV0dDOwzaXrLeth6ZT45pTEd QvCyjtDYYDNKmgXcVp/Ne86keN4yGj/7mEhDMnZ14lFVunteFZwRNHjnSF+xvMYGIgn898/iC9K hrRDoZkSGFNIAK5ZL4KVWsH92EtuntrYcGA8rPmBbXU0XrFyM7No0dR2rhY7/DpS6lWbGWsiXGE FrG5Eak98T0B65k= X-Received: by 2002:a17:902:cf4b:b0:2d7:71e:575d with SMTP id d9443c01a7336-2d74df04c8amr111140945ad.9.1787909272886; Fri, 28 Aug 2026 02:27:52 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d75988b68esm3680355ad.58.2026.08.28.02.27.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2026 02:27:52 -0700 (PDT) From: phucduc.bui@gmail.com To: Alexander Viro , Christian Brauner , Jan Kara Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2] chardev: check return value of kobject_set_name() in __register_chrdev() Date: Fri, 28 Aug 2026 16:27:34 +0700 Message-ID: <20260828092734.600911-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The kobject_set_name() function can fail and return -ENOMEM if memory allocation fails. While all other functions called inside __register_chrdev() are properly checked for errors, kobject_set_name() was missing this check. Add the error check for kobject_set_name() and jump to the 'out' label on failure to maintain consistency and ensure proper error handling. Found by manual code inspection. Reviewed-by: Jan Kara Signed-off-by: bui duc phuc --- Changes in v2: - Add Reviewed-by tag from Jan Kara. fs/char_dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/char_dev.c b/fs/char_dev.c index 00229e25c10f..5ce5423f6c99 100644 --- a/fs/char_dev.c +++ b/fs/char_dev.c @@ -280,7 +280,9 @@ int __register_chrdev(unsigned int major, unsigned int baseminor, cdev->owner = fops->owner; cdev->ops = fops; - kobject_set_name(&cdev->kobj, "%s", name); + err = kobject_set_name(&cdev->kobj, "%s", name); + if (err) + goto out; err = cdev_add(cdev, MKDEV(cd->major, baseminor), count); if (err) -- 2.43.0