From: Ahmed Yaseen <yaseen@ghoul.dev>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Hans de Goede" <hansg@kernel.org>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
"Denis Benato" <denis.benato@linux.dev>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Ahmed Yaseen <yaseen@ghoul.dev>
Subject: [PATCH 0/2] platform/x86: asus-armoury: fix notifications for grouped attributes
Date: Fri, 28 Aug 2026 11:12:40 +0000 [thread overview]
Message-ID: <20260828111232.74443-1-yaseen@ghoul.dev> (raw)
Both fixes are the same mistake: the code identifies an attribute by
attr->attr.name, but callers always pass a current_value attribute, and
that name is always "current_value". sysfs_notify() therefore resolves
nothing, and asus_bios_requires_reboot() never matches.
Patch 1 threads the group name down to the notify calls; patch 2 uses
it for the reboot check, so it needs patch 1.
Ahmed Yaseen (2):
platform/x86: asus-armoury: fix sysfs_notify() of grouped attributes
platform/x86: asus-armoury: fix pending_reboot for grouped attributes
drivers/platform/x86/asus-armoury.c | 23 ++++++++++++-----------
drivers/platform/x86/asus-armoury.h | 16 +++++++++-------
2 files changed, 21 insertions(+), 18 deletions(-)
base-commit: e6664f2b33db9b6811eb4cec109f06cb2b4f458d
--
2.55.0
next reply other threads:[~2026-08-28 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 11:12 Ahmed Yaseen [this message]
2026-08-28 11:12 ` [PATCH 1/2] platform/x86: asus-armoury: fix sysfs_notify() of " Ahmed Yaseen
2026-08-28 11:12 ` [PATCH 2/2] platform/x86: asus-armoury: fix pending_reboot for " Ahmed Yaseen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260828111232.74443-1-yaseen@ghoul.dev \
--to=yaseen@ghoul.dev \
--cc=corentin.chary@gmail.com \
--cc=denis.benato@linux.dev \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®