mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tony Luck <tony.luck@intel.com>
To: Tony Luck <tony.luck@intel.com>
Cc: "Borislav Petkov" <bp@alien8.de>,
	"Qiuxu Zhuo" <qiuxu.zhuo@intel.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Breno Leitao" <leitao@debian.org>,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@lists.linux.dev
Subject: [PATCH v2 0/7] EDAC/intel-bff: Driver to reset bitfix filters
Date: Fri, 28 Aug 2026 08:29:55 -0700	[thread overview]
Message-ID: <20260828153002.10290-1-tony.luck@intel.com> (raw)

Some Intel CPUs implement a "bitfix filter" to suppress reporting of the
same corrected errors repeatedly in the case where aging silicon
develops stuck bits.

But when systems run for weeks, or months, the filters may become clogged
with transient errors.

When the filter is full (indicated by a "yellow" signature in a machine
check bank) clear the filter. This may make space for additional hard
errors.

Save a time stamp when clearing a filter. Log with "WARN" severity if
the filter overflows quickly (in tem minutes or less).

Signed-off-by: Tony Luck <tony.luck@intel.com>
---
Changes since v1: https://lore.kernel.org/all/20260825181526.13203-1-tony.luck@intel.com/

Boris:
	Change from a platform driver to an EDAC driver to avoid
	spreading RAS code into yet another corner of the source tree.

Ilpo:
	Use <linux/bitfield.h> macros FIELD_GET() and FIELD_PREP() for
	bit wrangling.
	Did NOT add comma to last initializer for dmr_mcbanks[]. The
	list is complete, this CPU model won't add extra banks that
	support the bitfix filter.

Sashiko: https://sashiko.dev/#/patchset/20260825181526.13203-1-tony.luck%40intel.com
	Ignored complaint about lost #GP faults. The driver
	checks that the feature is enumerated, so #GP can't happen.
	Ignored complaint about overwriting bits 63:1 in the reset
	MSRs. Only bit 0 is defined in these MSRs.
	Applied suggestion to save bank number in upper 32 bits of bff_id.
	a/IS_ERR()/xa_is_err()/ for check of return from xa_store()

Miscellaneous:
	Added entry in MAINTAINERS file
	Applied some cleanup suggestions from internal AI review.

Qiuxu Zhuo (1):
  cacheinfo: Export get_cpu_cacheinfo_id() for loadable modules

Tony Luck (6):
  x86/mce: Add enumeration for Intel bitfix filter reset
  EDAC/intel-bff: Add stub Intel bitfix filter driver
  EDAC/intel-bff: Add Diamond Rapids support
  EDAC/intel-bff: Reset bitfix filter when it overflows
  EDAC/intel-bff: Compute unique ID for overflowed filter
  EDAC/intel-bff: Report frequent filter overflows

 include/linux/cacheinfo.h        |  12 +-
 arch/x86/include/asm/mce.h       |   5 +
 arch/x86/include/asm/msr-index.h |   2 +
 drivers/base/cacheinfo.c         |  17 ++
 drivers/edac/intel-bff.c         | 295 +++++++++++++++++++++++++++++++
 MAINTAINERS                      |   6 +
 drivers/edac/Kconfig             |  13 ++
 drivers/edac/Makefile            |   2 +
 8 files changed, 341 insertions(+), 11 deletions(-)
 create mode 100644 drivers/edac/intel-bff.c


base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f
-- 
2.55.0


             reply	other threads:[~2026-08-28 15:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 15:29 Tony Luck [this message]
2026-08-28 15:29 ` [PATCH v2 1/7] cacheinfo: Export get_cpu_cacheinfo_id() for loadable modules Tony Luck
2026-08-28 15:29 ` [PATCH v2 2/7] x86/mce: Add enumeration for Intel bitfix filter reset Tony Luck
2026-08-28 15:29 ` [PATCH v2 3/7] EDAC/intel-bff: Add stub Intel bitfix filter driver Tony Luck
2026-08-28 15:29 ` [PATCH v2 4/7] EDAC/intel-bff: Add Diamond Rapids support Tony Luck
2026-08-28 15:30 ` [PATCH v2 5/7] EDAC/intel-bff: Reset bitfix filter when it overflows Tony Luck
2026-08-28 15:30 ` [PATCH v2 6/7] EDAC/intel-bff: Compute unique ID for overflowed filter Tony Luck
2026-08-28 15:30 ` [PATCH v2 7/7] EDAC/intel-bff: Report frequent filter overflows Tony Luck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260828153002.10290-1-tony.luck@intel.com \
    --to=tony.luck@intel.com \
    --cc=bp@alien8.de \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=leitao@debian.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@lists.linux.dev \
    --cc=qiuxu.zhuo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®