mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: <wang.yaxin@zte.com.cn>
Cc: <fan.yu9@zte.com.cn>, <yang.yang29@zte.com.cn>,
	<thomas.weissschuh@linutronix.de>, <corbet@lwn.net>,
	<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
	<xu.xin16@zte.com.cn>
Subject: Re: [PATCH v5 0/4] tools/accounting: refactor delay fields and share format_timespec()
Date: Sat, 29 Aug 2026 15:43:19 -0700	[thread overview]
Message-ID: <20260829154319.5d5422b8da6a93eaa72a00bc@linux-foundation.org> (raw)
In-Reply-To: <20260829171238191s9SIXoZPTlZSmA2Px30hn@zte.com.cn>

On Sat, 29 Aug 2026 17:12:38 +0800 (CST) <wang.yaxin@zte.com.cn> wrote:

> - Convert per-field delay members in struct task_info to an array indexed
>   by enum delay_type, eliminating offsetof() pointer arithmetic.
> 
> - Add __kernel_old_time_t typedef to tools/include/uapi/linux/time_types.h
>   per Thomas's suggestion for backward compatibility with pre-v5.5
>   UAPI headers.
> 
> - Factor out a common format_timespec() implementation shared by getdelays
>   and delaytop, using strftime for cleaner timestamp formatting.
> 
> - Replace the complex sizeof/ULL/shift Y2038 guard with a direct narrowing
>   truncation check ((long long)time_sec != ts->tv_sec).

Thanks.  I can't figure out how to apply this, and neither can Sashiko:
	https://sashiko.dev/#/patchset/20260829171238191s9SIXoZPTlZSmA2Px30hn@zte.com.cn

Seems there's a dependency on your "delaytop: add delay max, timestamp
and sorting for top latency analysis" series which didn't get applied
for reasons which I don't recall.


  parent reply	other threads:[~2026-08-29 22:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-29  9:12 wang.yaxin
2026-08-29  9:13 ` [PATCH v5 1/4] delaytop: refactor repetitive delay fields into array with enum wang.yaxin
2026-08-29  9:14 ` [PATCH v5 2/4] tools/include/uapi: Add __kernel_old_time_t typedef to tools/include/uapi/linux/time_types.h wang.yaxin
2026-08-31  9:13   ` Thomas Weißschuh
2026-08-29  9:15 ` [PATCH v5 3/4] tools/accounting: factor out shared format_timespec() implementation wang.yaxin
2026-08-29  9:16 ` [PATCH v5 4/4] tools/accounting: simplify 32-bit time_t overflow check in format_timespec() wang.yaxin
2026-08-29 22:43 ` Andrew Morton [this message]
2026-09-05  0:33   ` [PATCH v5 0/4] tools/accounting: refactor delay fields and share format_timespec() wang.yaxin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260829154319.5d5422b8da6a93eaa72a00bc@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=fan.yu9@zte.com.cn \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=wang.yaxin@zte.com.cn \
    --cc=xu.xin16@zte.com.cn \
    --cc=yang.yang29@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®