From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.mainlining.org (mail.mainlining.org [5.75.144.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B52139C636; Sat, 29 Aug 2026 16:17:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.75.144.95 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788020261; cv=none; b=U4AeDAKievODo8RjE88UB2FlZj9GsJHosX8XXN8XnB6YnBO1WvTjnL4JqBYU2N1rAZEaLRMFyONcR0J6elgwUauf1lAf6lIbVZlhmD5tq3sB2kcKeHmpfBiw33vYUvTUuFJ9UAR9ydinKavhqM2rznstKSVcBxE5T5+gnPZ5ooo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788020261; c=relaxed/simple; bh=uZKY6mc+5pft/q3cAwuIhr586hkZ+KFWPhywxEQWTm4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WMxuDVkl+1mlagBJyNTIgxe7SmB/TZtKce9iei3rdgXqH4I21iqMaCdrhRSLaoRiB5Tz6KdL1SWxEr/YLMMUgcXGKtxY8HfdtjOuG8ckiEn85kP2kgBHiHfvNhj7hMlYrm1Lppwrwbo0YRUYAbBw3/vYvhMuDciGZRSb+8FKqPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=reject dis=none) header.from=grrlz.net; spf=pass smtp.mailfrom=mainlining.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=AGppSPD8; dkim=permerror (0-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=J5RldUj/; arc=none smtp.client-ip=5.75.144.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=reject dis=none) header.from=grrlz.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mainlining.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="AGppSPD8"; dkim=permerror (0-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="J5RldUj/" DKIM-Signature: v=1; a=rsa-sha256; s=202507r; d=mainlining.org; c=relaxed/relaxed; h=Message-ID:Date:Subject:To:From; t=1788020257; bh=ngSOMec2hvD+GVCYRJ3MZdS rfGEKoGbtHjfNNfZkYJQ=; b=AGppSPD8iX/nu6kk7r/8CEPI3/4gXIlSNqo2StDtTK3PahSlKx 83zFMj4vJvlLzFQO28/oQr3m+LLNDiVRThMszJkKRkn895AomV0PK7TYSgLitsGJcJ8AASnuCVl wbzQ83Egj8NkeBNjuqREY5s21Qb8wyCvd+gGc1bEQHOkljm43AXIzmjFjS+EXsHNrTmz7aPp2xV w6EC3stCrIEldHtj7OVFy7DSrXapu+t0w0g6Z11DfiGe61iTxSj1KpmOfN+LwCbqU10j6qVtLEU ukDQo80u7Y8Tuud+B+JmlT8BqtPQri2B8EG0CKxXEspX/IHZS5NTCwCpCo5qy3VSt4A==; DKIM-Signature: v=1; a=ed25519-sha256; s=202507e; d=mainlining.org; c=relaxed/relaxed; h=Message-ID:Date:Subject:To:From; t=1788020257; bh=ngSOMec2hvD+GVCYRJ3MZdS rfGEKoGbtHjfNNfZkYJQ=; b=J5RldUj/KuPJRh4/Du9+M2PfT4SGsTns7G3mjV3RRXj1kHdOUs L3axmodW26y5YIef5wR956XVZGtEjMqlm2CQ==; From: Bradley Morgan To: "Rafael J . Wysocki" , Viresh Kumar Cc: Ingo Molnar , Peter Zijlstra , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, brads@mainlining.org Subject: [PATCH 4/5] cpufreq: schedutil: convert to kthread_create_worker Date: Sat, 29 Aug 2026 16:17:38 +0000 Message-ID: <20260829161738.19639-1-include@grrlz.net> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260829161150.16301-1-include@grrlz.net> References: <20260829161150.16301-1-include@grrlz.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Bradley Morgan Embedding a kthread_worker and running kthread_worker_fn yourself is the old way. Convert cpufreq_schedutil to kthread_create_worker(), dropping the separate thread pointer. This is part of removing the worker->task self-assignment in kthread_worker_fn(). Signed-off-by: Bradley Morgan --- kernel/sched/cpufreq_schedutil.c | 33 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c index 49ccd6f1c185..5023c24d8a21 100644 --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -31,8 +31,7 @@ struct sugov_policy { struct irq_work irq_work; struct kthread_work work; struct mutex work_lock; - struct kthread_worker worker; - struct task_struct *thread; + struct kthread_worker *worker; bool work_in_progress; bool limits_changed; @@ -586,7 +585,7 @@ static void sugov_irq_work(struct irq_work *irq_work) sg_policy = container_of(irq_work, struct sugov_policy, irq_work); - kthread_queue_work(&sg_policy->worker, &sg_policy->work); + kthread_queue_work(sg_policy->worker, &sg_policy->work); } /************************** sysfs interface ************************/ @@ -669,7 +668,6 @@ static void sugov_policy_free(struct sugov_policy *sg_policy) static int sugov_kthread_create(struct sugov_policy *sg_policy) { - struct task_struct *thread; struct sched_attr attr = { .size = sizeof(struct sched_attr), .sched_policy = SCHED_DEADLINE, @@ -692,32 +690,29 @@ static int sugov_kthread_create(struct sugov_policy *sg_policy) return 0; kthread_init_work(&sg_policy->work, sugov_work); - kthread_init_worker(&sg_policy->worker); - thread = kthread_create(kthread_worker_fn, &sg_policy->worker, - "sugov:%d", - cpumask_first(policy->related_cpus)); - if (IS_ERR(thread)) { - pr_err("failed to create sugov thread: %pe\n", thread); - return PTR_ERR(thread); + sg_policy->worker = kthread_create_worker(0, "sugov:%d", + cpumask_first(policy->related_cpus)); + if (IS_ERR(sg_policy->worker)) { + pr_err("failed to create sugov thread: %pe\n", sg_policy->worker); + return PTR_ERR(sg_policy->worker); } - ret = sched_setattr_nocheck(thread, &attr); + ret = sched_setattr_nocheck(sg_policy->worker->task, &attr); if (ret) { - kthread_stop(thread); + kthread_destroy_worker(sg_policy->worker); pr_warn("%s: failed to set SCHED_DEADLINE\n", __func__); return ret; } - sg_policy->thread = thread; if (policy->dvfs_possible_from_any_cpu) - set_cpus_allowed_ptr(thread, policy->related_cpus); + set_cpus_allowed_ptr(sg_policy->worker->task, policy->related_cpus); else - kthread_bind_mask(thread, policy->related_cpus); + kthread_bind_mask(sg_policy->worker->task, policy->related_cpus); init_irq_work(&sg_policy->irq_work, sugov_irq_work); mutex_init(&sg_policy->work_lock); - wake_up_process(thread); + wake_up_process(sg_policy->worker->task); return 0; } @@ -728,8 +723,8 @@ static void sugov_kthread_stop(struct sugov_policy *sg_policy) if (sg_policy->policy->fast_switch_enabled) return; - kthread_flush_worker(&sg_policy->worker); - kthread_stop(sg_policy->thread); + kthread_flush_worker(sg_policy->worker); + kthread_destroy_worker(sg_policy->worker); mutex_destroy(&sg_policy->work_lock); } -- 2.47.3