From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 935733B895D for ; Sun, 30 Aug 2026 15:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788105141; cv=none; b=VfnOCme89AE37AVn6jfeGJ7ahFSNsLHzjl3qDQBXL1QfXj+IUl1g1LXVUhbXAr51UWJFW/diR0tthosyED/nn2w6vjKdgqjX0UyKHypXfJKXRDuvqgO1CyfAIqKsks1SA13mqjxbFhiQ8FMfN5LoFeXGqkjO7Dm7lwYyfM/Lg90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788105141; c=relaxed/simple; bh=R7Emn6xm8pXsKAcdrDs+f1v2J7med05J/NuiW1giTgk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WITuC96YGQm9lKpigxzUbb0+Gy/Z2NJ9YOII+CGF3VA5q4fNFMItW2qWxiBWEovTpB1PPNRXIb1h5qQC8YaiJlImwr4c98KTpPObJ1t6tF0exNG4CAqJ/hhYc+o7czifonuBFO5h1NgY1yGeOU9uYXpPQY7Y/Z3hoWrGDO1Ssoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Sk65VCN9; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Sk65VCN9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEBEF1F000E9; Sun, 30 Aug 2026 15:52:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788105140; bh=lTn2PwZa/M8+jVj3fJrDpEEh/COhBy7FRr29V6qoiYI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Sk65VCN98VsowdHN+8Zoh22imIXgdBaOP7PxtTldPwfbpfAo/y59yZ/4RYrYu4x5w iVHCkW+vNye4ghW0ubslfMd/4D+ggCwHAXfpnXhHS6dcp/KzSXfJAeSTVs/RT32Mj8 h3PTGZN1mycvPUnvvKeyFKTgJhoCgNUzKysnH9pKM5K5QNGQcHNVMvJ9RTnNyw71Bc gAtgNERhBYT9wor5+n1FemtO8LmlnFRlH9WsfMY93jhDxcs1RxILx0mezVHQtbIBdZ P1HeqziyyP/feTb6f8Me7R/3YceRW5mAYvK5Jwbz4gvrZaqpF1bYGrJYoIH1YtNnhv dV7Oa369JSrQQ== From: SJ Park To: =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= Cc: SJ Park , Richard Weinberger , Anton Ivanov , Johannes Berg , "Christophe Leroy (CS GROUP)" , Thomas Gleixner , linux-um@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] um: Use asm-generic/timex.h over the host architecture one Date: Sun, 30 Aug 2026 08:52:11 -0700 Message-ID: <20260830155212.97975-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260819-uml-timex-fix-v1-1-f690b514fc9f@linutronix.de> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Wed, 19 Aug 2026 09:24:21 +0200 Thomas Weißschuh wrote: > The removal of the architecture-specific asm/timex.h was meant to fall > back to asm-generic/timex.h. However on UML, the host architecture > headers are earlier on the include path and therefore asm/timex.h from > the host architecture is used. > On x86 that header in turn requires the generation of cpufeaturemasks.h, > which is not set up for UML and the build fails. > > In file included from ../arch/x86/include/asm/tsc.h:9, > from ../arch/x86/include/asm/timex.h:6, > from ../include/linux/timex.h:67, > from ../include/linux/time32.h:13, > from ../include/linux/time.h:60, > from ../include/linux/jiffies.h:10, > from ../include/linux/ktime.h:25, > from ../include/linux/timer.h:6, > from ../include/linux/uprobes.h:18, > from ../include/linux/mm_types.h:16, > from ../include/linux/mmzone.h:22, > from ../include/linux/gfp.h:7, > from ../include/linux/slab.h:17, > from ../include/linux/crypto.h:18, > from ../arch/um/kernel/asm-offsets.c:6: > arch/x86/include/asm/tsc.h: In function ‘get_cycles’: > arch/um/include/asm/cpufeature.h:52:39: error: implicit declaration of function ‘DISABLED_MASK_BIT_SET’ [-Wimplicit-function-declaration] > 52 | (__builtin_constant_p(bit) && DISABLED_MASK_BIT_SET(bit) ? 0 : _static_cpu_has(bit)) > | ^~~~~~~~~~~~~~~~~~~~~ > arch/x86/include/asm/tsc.h:79:14: note: in expansion of macro ‘cpu_feature_enabled’ > 79 | if (!cpu_feature_enabled(X86_FEATURE_TSC)) > | ^~~~~~~~~~~~~~~~~~~ > arch/um/include/asm/cpufeature.h:115:17: error: implicit declaration of function ‘_static_cpu_has’ [-Wimplicit-function-declaration] > 115 | _static_cpu_has(bit) \ > | ^~~~~~~~~~~~~~~ > arch/um/include/asm/cpufeature.h:52:72: note: in expansion of macro ‘_static_cpu_has’ > 52 | (__builtin_constant_p(bit) && DISABLED_MASK_BIT_SET(bit) ? 0 : _static_cpu_has(bit)) > | ^~~~~~~~~~~~~~~ > arch/x86/include/asm/tsc.h:79:14: note: in expansion of macro ‘cpu_feature_enabled’ > 79 | if (!cpu_feature_enabled(X86_FEATURE_TSC)) > | ^~~~~~~~~~~~~~~~~~~ > arch/um/include/asm/cpufeature.h:115:17: note: ‘_static_cpu_has’ is a function-like macro and might be used incorrectly > arch/um/include/asm/cpufeature.h:52:72: note: in expansion of macro ‘_static_cpu_has’ > 52 | (__builtin_constant_p(bit) && DISABLED_MASK_BIT_SET(bit) ? 0 : _static_cpu_has(bit)) > | ^~~~~~~~~~~~~~~ > arch/x86/include/asm/tsc.h:79:14: note: in expansion of macro ‘cpu_feature_enabled’ > 79 | if (!cpu_feature_enabled(X86_FEATURE_TSC)) > | ^~~~~~~~~~~~~~~~~~~ > > The x86-specific timex.h also doesn't make sense on UML in general. > > Reintroduce the UML-specific asm/timex.h and add a comment to document > its necessity. I got the same issue, and confirmed this patch fixes it on my setup. Thank you for sharing this patch. > > Fixes: 3ed403bbc967 ("treewide: Remove CLOCK_TICK_RATE") > Signed-off-by: Thomas Weißschuh Tested-by: SJ Park Thanks, SJ [...]