Re: [PATCH] iio: light: vcnl4000: use sysfs_emit() for near_level

[Joshua Crofts <joshua.crofts1@gmail.com>]

On Sun, 30 Aug 2026 14:42:36 +0900
Donggeun Yoo <donggeunyoo.kernel@gmail.com> wrote:

> Use sysfs_emit() instead of sprintf() for writing to the sysfs
> output buffer. sysfs_emit() is aware of the buffer's PAGE_SIZE
> limit and is the preferred helper for sysfs callbacks.
> 
> Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
> ---
>  drivers/iio/light/vcnl4000.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
> index 336468d59ea7..dac235dd6220 100644
> --- a/drivers/iio/light/vcnl4000.c
> +++ b/drivers/iio/light/vcnl4000.c
> @@ -1504,7 +1504,7 @@ static ssize_t vcnl4000_read_near_level(struct iio_dev *indio_dev,
>  {
>  	struct vcnl4000_data *data = iio_priv(indio_dev);
>  
> -	return sprintf(buf, "%u\n", data->near_level);
> +	return sysfs_emit(buf, "%u\n", data->near_level);

You should also include <linux/sysfs.h>.

-- 
Kind regards,
Joshua Crofts