mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Edward Adam Davis <eadavis@sina.com>
To: syzbot+5fabc1ae99ff40690d84@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [usb?] KASAN: slab-use-after-free Write in keyspan_close
Date: Mon, 31 Aug 2026 07:50:31 +0800	[thread overview]
Message-ID: <20260830235031.326993-1-eadavis@sina.com> (raw)
In-Reply-To: <6a944641.4d659fcc.734b4.003c.GAE@google.com>

From: Edward Aadm Davis <eadavis@sina.com>

#syz test: upstream 08dbfad3f504

diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index 17edc057a311..51359815432a 100644
--- a/drivers/usb/serial/usb-serial.c
+++ b/drivers/usb/serial/usb-serial.c
@@ -301,11 +301,19 @@ static void serial_port_shutdown(struct tty_port *tport)
 	struct usb_serial_port *port =
 		container_of(tport, struct usb_serial_port, port);
 	struct usb_serial_driver *drv = port->serial->type;
+	struct usb_serial *serial = port->serial;
+
+	mutex_lock(&serial->disc_mutex);
+	if (serial->disconnected) {
+		mutex_unlock(&serial->disc_mutex);
+		return;
+	}
 
 	if (drv->close)
 		drv->close(port);
 
 	usb_autopm_put_interface(port->serial->interface);
+	mutex_unlock(&serial->disc_mutex);
 }
 
 static void serial_hangup(struct tty_struct *tty)

  reply	other threads:[~2026-08-30 23:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-30 15:03 syzbot
2026-08-30 23:50 ` Edward Adam Davis [this message]
2026-08-31  0:14   ` syzbot
2026-08-31  0:10 ` Forwarded: [PATCH] USB: serial: keyspan: fix use-after-free " syzbot
2026-08-31  0:38 ` [syzbot] [usb?] KASAN: slab-use-after-free Write " Edward Adam Davis
2026-08-31  1:02   ` syzbot
     [not found] <20260831001012.8665-1-kartikey406@gmail.com>
2026-08-31  0:37 ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260830235031.326993-1-eadavis@sina.com \
    --to=eadavis@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+5fabc1ae99ff40690d84@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®