mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Andy Chang <andy.chang@synaptics.corp-partner.google.com>
Cc: linux-bluetooth@vger.kernel.org,
	Marcel Holtmann <marcel@holtmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, Linus Walleij <linusw@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] Bluetooth: dt-bindings: net: bluetooth: add BCM4384
Date: Mon, 31 Aug 2026 16:02:35 +0100	[thread overview]
Message-ID: <20260831-cosmic-crawling-cf0532d4d3c0@spud> (raw)
In-Reply-To: <CAF8VQdEA7=LRpHaVOVZxRi73kRf=0pK_etJOJ5oeULtgw4k5Bg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 967 bytes --]

On Mon, Aug 31, 2026 at 05:34:23PM +0800, Andy Chang wrote:
> On Fri, Aug 28, 2026 at 12:38 AM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Thu, Aug 27, 2026 at 07:02:41PM +0800, Andy Chang wrote:
> > > Add the brcm,bcm4384-bt compatible string to support the
> > > Synaptics BCM4384 Bluetooth controller.
> >
> > Please explain why a fallback compatible is not suitable here, or
> > alternatively if it is, use one.
> >
> > pw-bot: changes-requested
> >
> > Thanks,
> > Conor.
> Hi Conor,
> A fallback compatible is not suitable here because the BCM4384
> controller requires a dedicated firmware patch file (.hcd) matching
> its specific hardware ID and revision.
> Falling back to an existing compatible would cause the driver to
> request the wrong firmware binary and fail the controller
> initialization.
> Therefore, it requires a distinct compatible string.

Cool, please put this info in the commit message.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-08-31 15:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27 11:02 [PATCH v1 0/2] Add support for the Synaptics BCM4384 Bluetooth controller Andy Chang
2026-08-27 11:02 ` [PATCH v1 1/2] Bluetooth: dt-bindings: net: bluetooth: add BCM4384 Andy Chang
2026-08-27 16:38   ` Conor Dooley
2026-08-31  9:34     ` Andy Chang
2026-08-31 15:02       ` Conor Dooley [this message]
2026-09-01  2:32   ` [PATCH v2 0/2] Add support for the Synaptics BCM4384 Bluetooth controller Andy Chang
2026-09-01  2:32     ` [PATCH v2 1/2] Bluetooth: dt-bindings: net: bluetooth: add BCM4384 Andy Chang
2026-09-01  8:57       ` [PATCH v3 0/2] Add support for the Synaptics BCM4384 Bluetooth controller Andy Chang
2026-09-01  8:57         ` [PATCH v3 1/2] Bluetooth: dt-bindings: net: bluetooth: add BCM4384 Andy Chang
2026-09-01 13:42           ` Paul Menzel
2026-09-04 16:56           ` patchwork-bot+bluetooth
2026-09-01  8:57         ` [PATCH v3 2/2] Bluetooth: btbcm: Add Synaptics 4384 chip support Andy Chang
2026-09-01 13:55           ` Paul Menzel
2026-09-01 17:11           ` Linus Walleij
2026-09-01 17:10       ` [PATCH v2 1/2] Bluetooth: dt-bindings: net: bluetooth: add BCM4384 Linus Walleij
2026-09-01  2:33     ` [PATCH v2 2/2] Bluetooth: btbcm: Add Synaptics 4384 chip support Andy Chang
2026-09-03 12:18     ` [PATCH v4 0/2] Add support for the Synaptics BCM4384 Bluetooth controller Andy Chang
2026-09-03 12:18       ` [PATCH v4 1/2] Bluetooth: dt-bindings: net: bluetooth: add BCM4384 Andy Chang
2026-09-03 12:18       ` [PATCH v4 2/2] Bluetooth: btbcm: Add Synaptics 4384 chip support Andy Chang
2026-09-04 16:56       ` [PATCH v4 0/2] Add support for the Synaptics BCM4384 Bluetooth controller patchwork-bot+bluetooth
2026-08-27 11:02 ` [PATCH v1 2/2] Bluetooth: btbcm: Add Synaptics 4384 chip support Andy Chang
2026-09-04 16:56 ` [PATCH v1 0/2] Add support for the Synaptics BCM4384 Bluetooth controller patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260831-cosmic-crawling-cf0532d4d3c0@spud \
    --to=conor@kernel.org \
    --cc=andy.chang@synaptics.corp-partner.google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®