From: Borislav Petkov <bp@alien8.de>
To: Jason Andryuk <jason.andryuk@amd.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Thomas Gleixner <tglx@kernel.org>,
x86@kernel.org, Yazen Ghannam <yazen.ghannam@amd.com>,
linux-kernel@vger.kernel.org, Penny Zheng <penny.zheng@amd.com>,
stable@vger.kernel.org,
"Mario Limonciello (AMD)" <superm1@kernel.org>
Subject: Re: [PATCH v3 2/2] x86/amd_node: Remove smn_exclusive
Date: Sun, 30 Aug 2026 19:30:16 -0700 [thread overview]
Message-ID: <20260831023016.GEapTnOHTbN8XZGe2j@fat_crate.local> (raw)
In-Reply-To: <20260825214805.39148-3-jason.andryuk@amd.com>
On Tue, Aug 25, 2026 at 05:48:03PM -0400, Jason Andryuk wrote:
> - root = amd_roots[node];
> - if (!root)
> + /*
> + * non-NULL amd_roots indicates pci_request_config_region_exclusive()
> + * succeeded and userspace cannot access the registers.
> + */
> + if (!amd_roots)
So then this should be
if (amd_roots)
return err;
?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2026-08-31 2:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 21:48 [PATCH v3 0/2] x86/amd_node: Fixes for virtualized systems Jason Andryuk
2026-08-25 21:48 ` [PATCH v3 1/2] x86/amd_node: Avoid divide by zero on " Jason Andryuk
2026-08-26 4:45 ` Borislav Petkov
2026-08-26 12:15 ` Jason Andryuk
2026-08-26 15:55 ` Borislav Petkov
2026-08-31 17:35 ` [tip: x86/urgent] " tip-bot2 for Jason Andryuk
2026-08-25 21:48 ` [PATCH v3 2/2] x86/amd_node: Remove smn_exclusive Jason Andryuk
2026-08-31 2:30 ` Borislav Petkov [this message]
2026-08-31 17:52 ` Jason Andryuk
2026-09-01 0:27 ` Borislav Petkov
2026-09-01 11:59 ` Jason Andryuk
2026-09-02 21:32 ` [tip: x86/urgent] x86/amd_node: Prevent potential NULL pointer dereference tip-bot2 for Jason Andryuk
2026-09-08 7:05 ` [tip: x86/urgent] x86/amd_node: Fix " tip-bot2 for Jason Andryuk
2026-09-08 7:21 ` tip-bot2 for Jason Andryuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831023016.GEapTnOHTbN8XZGe2j@fat_crate.local \
--to=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jason.andryuk@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=penny.zheng@amd.com \
--cc=stable@vger.kernel.org \
--cc=superm1@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®