From: Peter Zijlstra <peterz@infradead.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Chen Yu <yu.c.chen@intel.com>,
Ricardo Neri <ricardo.neri@intel.com>,
Len Brown <len.brown@intel.com>, Aubrey Li <aubrey.li@intel.com>,
linux-kernel@vger.kernel.org,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Subject: Re: [PATCH] sched/fair: avoid creating misfits during cache-aware balancing
Date: Mon, 31 Aug 2026 10:41:49 +0200 [thread overview]
Message-ID: <20260831084149.GG4120091@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20260825174112.2580942-1-tim.c.chen@linux.intel.com>
On Tue, Aug 25, 2026 at 10:41:12AM -0700, Tim Chen wrote:
> Cache-aware load balancing biases tasks toward their preferred LLC. On
> asymmetric CPU capacity systems (e.g. big.LITTLE) the destination LLC may
> contain CPUs that are too small to run the task. Pulling the task there
> turns it into a misfit, trading a cache-locality gain for a capacity loss
> that's more detrimental to performance.
>
> Guard both cache-aware migration entry points against this:
>
> - can_migrate_llc_task(): forbid the LLC migration when the task fits its
> source CPU but would not fit the destination CPU.
> - alb_break_llc(): veto the active balance under the same condition so the
> runnable task is not pushed onto a CPU that cannot accommodate it.
>
> Both checks are gated with checks for hybrid processors, so symmetric
> systems are unaffected. Tasks that already do not fit their source CPU
> are left to the existing LLC policy, since the move cannot make their
> fitness worse (this also preserves misfit up-migration to bigger CPUs).
>
> Additionally, if there are misfit tasks found in the load balancing
> classification phase, prioritize misfit task migrations
> over LLC load aggregation on asymmetric systems. A better fitting
> CPU will boost performance more than better cache locality.
>
> Reviewed-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
> Tested-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
> Reviewed-by: Chen Yu <yu.c.chen@intel.com>
Tim sends patch, Tim adds SoB, yes?
Also, we start $subject with capital after subsystem: part.
next prev parent reply other threads:[~2026-08-31 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 17:41 Tim Chen
2026-08-26 15:57 ` Tim Chen
2026-08-31 8:41 ` Peter Zijlstra [this message]
2026-08-31 17:17 ` Tim Chen
2026-08-31 17:40 ` Tim Chen
2026-09-02 7:21 ` [tip: sched/urgent] sched/fair: Avoid " tip-bot2 for Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831084149.GG4120091@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aubrey.li@intel.com \
--cc=kprateek.nayak@amd.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=ricardo.neri@intel.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®