From: ThangNN99 <ngocthang2710.1999@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-rt-devel@lists.linux.dev, linux-mm@kvack.org,
Vlastimil Babka <vbabka@kernel.org>, Harry Yoo <harry@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH v3] mm/slab: don't use kfree_rcu sheaves on PREEMPT_RT in kvfree_call_rcu()
Date: Mon, 31 Aug 2026 20:55:46 +0700 [thread overview]
Message-ID: <20260831135546.9929-1-ngocthang2710.1999@gmail.com> (raw)
In-Reply-To: <20260831135150.1B4B31F00A3E@smtp.kernel.org>
Thanks, both are pre-existing and out of scope for this patch:
- The GFP_NOWAIT/wakeup_kswapd() concern in __kfree_rcu_sheaf() applies
identically before and after this patch on !PREEMPT_RT; this patch
only changes the PREEMPT_RT branch. It also predates the commit this
patch fixes: alloc_empty_sheaf() has used GFP_NOWAIT in this call
chain since the sheaves feature was introduced in ec66e0d59952
("slab: add sheaf support for batching kfree_rcu() operations"), not
since 2a8bb29ec9b2. It's a real question about the sheaf/barn
allocation design itself, not something a small, targeted fix for
the syzbot-reported splat should also try to redesign.
- Same as noted for the previous review: kfree_call_rcu_nolock() is
intentionally left untouched by this patch. Agreed it doesn't fully
deliver on its 'any context' contract on PREEMPT_RT either, for the
reasons given (local_trylock ordering, and now also alloc_empty_sheaf()
reaching zone->lock). That's a separate fix.
Both would be good candidates for their own patches from whoever
knows the sheaf/barn allocation path best; happy to help test if one
gets posted. This patch stays scoped to the specific circular-locking
splat in kvfree_call_rcu() reported by syzbot.
Thanks,
ThangNN99
next prev parent reply other threads:[~2026-08-31 13:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 5:38 [PATCH] " ThangNN99
2026-08-31 5:50 ` sashiko-bot
2026-08-31 6:06 ` [PATCH v2] " ThangNN99
2026-08-31 6:20 ` sashiko-bot
2026-08-31 6:33 ` ThangNN99
2026-08-31 13:00 ` Sebastian Andrzej Siewior
2026-08-31 13:32 ` [PATCH v3] " ThangNN99
2026-08-31 13:51 ` sashiko-bot
2026-08-31 13:55 ` ThangNN99 [this message]
2026-08-31 14:35 ` Sebastian Andrzej Siewior
2026-08-31 16:04 ` Vlastimil Babka (SUSE)
2026-08-31 16:17 ` [PATCH] mm/slab: don't use kfree_rcu_sheaf() on PREEMPT_RT again ThangNN99
2026-09-02 10:05 ` [PATCH v3] mm/slab: don't use kfree_rcu sheaves on PREEMPT_RT in kvfree_call_rcu() Harry Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831135546.9929-1-ngocthang2710.1999@gmail.com \
--to=ngocthang2710.1999@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=harry@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®