From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DF323A9871 for ; Mon, 31 Aug 2026 18:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788200291; cv=none; b=t2zofsNiIf5Fry9ClqWSATVJvoW6axSDn6Zt1tv3QhbwYceIIsay21MYauQar1LvORG/CfD9UHG9w80NFtXj0J6NGiVKosViEipIKE38yGK17Tf5PYyItuh+SHxjTm7Qm8MOWYwNpP2WVMssON8GWgtVt9Y1nPseO7wel9F8yFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788200291; c=relaxed/simple; bh=59NyyHL41/fxCKnVpkaZ9/UftIltcgBlLurz9X8b9lc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OSB2+DKUMHuFeu/9TiEHjFKP8s2M2bMB/fkBHcvqAEzFG84Yldyh3v+vgXpPuT0GumbNI0vsy0GOm2od19GqD0V+8ZEESaystoN6VigbrX9ydX9mmg3FrhX3ceGRe1P9jM90/uRQuTQZErCHYGdyoyJKLlz5Gf+Dn1SUHIcHl7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AmFpDPKe; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AmFpDPKe" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-482f9309813so40142f8f.1 for ; Mon, 31 Aug 2026 11:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788200287; x=1788805087; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OtkK6MeXx36zYOmLk563en61hTj5SYJiMnh1Sx9Z2s8=; b=AmFpDPKe+Yzzuh4X9MjlgpxQeqRNOMJ5mQretUU40ad/SSpzb6zNLYGbu8DGBOnCGn MCYuU3M8E4MeKn/SOfrkqEkHFcQX20fWM8fHdyQHjZLHc3qGLZ+HktO8iWz6WQHteX8C CZ1noK6yf17ALCD4nqBEpVex8ZNsKL1vp6EPQ6Dd6ryG+SPth9SiuzWzSativ3RoM29d VTWjsXuLaHpM6nLHAtBPLehicVV75ECMv0orEXDiqEZX0hWawjZleaUGf/euIdoFpqPX 7QUb6+WLSk/C+yXi7QvEFh2mCKwYgs5bmOjAcjU9pxrOAvFwxSuYBj/XGRA0i/risgWM 7ZBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788200287; x=1788805087; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=OtkK6MeXx36zYOmLk563en61hTj5SYJiMnh1Sx9Z2s8=; b=DNMRDTa8trPFuUnKYa+2XxCUwZw54fV6Du+qvFmnZb7LQSeNaa6hJjBUq8a1gt+dJw eiI33wic+JoOEzKzZVvtYXJNwpT22ylxLGa7PFO7Sr90b5JhEVhAQcP549KxcZnD9KoK 05jc7xBqRBCPBynceZIyWX1CUq9lyo7h6dnHbphQBlgERlyDpAF/GewfJEXPVZS0QLiV ngEE0Jl9jwvvEp+wAwQH5QjS6p+/ab/bldmeCMuGxwwjhcALXgTugFFCML4Mg9ik9qqE IeZ1YCuK9JWRAKa7NiEzK3IHs8ANZXY8IlvEanF1KNirTwAYkJlMQKKjNvL2XUdAEbgh OUoA== X-Gm-Message-State: AFuF++mLOPGfXNLaISxOXu1g/vLKyD/M7mXOHGsCa05EfH6AcwBxog6V iB79b7jSCdC1bMHekP1rAFU+4b8YUaYvznUvc4Jd8GJ+yCopdzRhsH0F4RY9iQ== X-Gm-Gg: AYBFou38kurbERo5jmDpFGMc4IwoiPMhln3Lzgf0DXIgGYeuFPMgzOr02d2C3Kj0Ob+ cDzt76Ldtm4MnIob00vHc2qH3Jthew4t5Nnn4ovJu6ZeOhD7bYTGWOx3rNy7ZZAjbb052xv3zeF WgOQ0G919b3EuGxi6Li2Gw2Ts8PTvV6fUKDQLkVnwo8drSy5p+264+Ib5Lp46PbgdJwlGo2p1CD VN0m1mnzBN2yA+c0nJMF/ggomxlGLhJZHA/SPkByGMnhjmjn6qbtaaqNHUXCr97goiikYazObYu CwaCRVVeMfq9VIezuLgLQqH4iKhwhjq6FpUBDmMk2xi8TGOEEGWuiz7vFcBd2qMnyFvQim7Vbc3 2l9JM4a+zqhqhJWahNppqz6Qcx23Wt6LocQaFYTeVRTeTDctMYQRbAQaT3Vpwk0Wz+vbnsLztJK g/f3m7YV4eW/3/fbdE9Kxr6oK0WqgzGbGhpSxEZjW7k8UUxj2mwtAJ1P5W55ovyfFdMaKiIaIt+ /WBqeslvlY4 X-Received: by 2002:a05:6000:4692:b0:482:d7db:ec06 with SMTP id ffacd0b85a97d-482f79cfc09mr35102693f8f.22.1788200287133; Mon, 31 Aug 2026 11:18:07 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:5d3a:fe75:a74b:bc2a:bdfb:30ff]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48440e08b43sm2656289f8f.22.2026.08.31.11.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2026 11:18:06 -0700 (PDT) From: Fernando Rimoli To: Daniel Scally , Sakari Ailus , linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/4] media: ipu-bridge: Request non-continuous clock for ov5693 on IPU6 Date: Mon, 31 Aug 2026 20:18:00 +0200 Message-ID: <20260831181800.322529-1-fernandorimoli11@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <13d6659f-4b51-4041-8aff-70b991ac306e@ideasonboard.com> References: <20260717132021.18034-1-fernandorimoli11@gmail.com> <20260720163819.104130-1-fernandorimoli11@gmail.com> <20260720163819.104130-5-fernandorimoli11@gmail.com> <13d6659f-4b51-4041-8aff-70b991ac306e@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Dan, Thanks for the reviews on v3, and sorry for the slow follow-up. > Hm, I think this is functionally fine, but matching on PCI ID and sensor > does seem a bit quirky...do you know if the IPU3 case is fine with the > clock-noncontinuous flag too? If not I can test it tomorrow. You and Sakari landed on the same objection, and v4 drops that helper entirely. Instead struct ipu_sensor_config gains an optional IPU PCI product ID and a flags field (Sakari's suggestion), so the ov5693 on IPU6 becomes table entries rather than a special case in code: IPU_SENSOR_CONFIG("INT33BE", 1, 419200000), IPU_SENSOR_CONFIG_MATCH_FL("INT33BE", PCI_DEVICE_ID_INTEL_IPU6, CSI2_CLK_NONCONTINUOUS, 1, 419200000), IPU_SENSOR_CONFIG_MATCH_FL("INT33BE", PCI_DEVICE_ID_INTEL_IPU6EP_ADLP, CSI2_CLK_NONCONTINUOUS, 1, 419200000), That also answers your IPU3 question without needing the test: IPU3 has no matching entry, so it keeps using the generic one and never sees the flag, by construction rather than by a PCI check. So please don't spend hardware time on it on my account. If you are curious anyway I would still be interested in the result, since knowing IPU3 tolerates the flag would let a later patch collapse those three entries back into one, but it is not blocking anything now. Since a PCI ID in the table is new, one semantic came with it that I would value your view on as the bridge's author: a sensor with both a specific and a generic entry for the same HID matches twice on the specific IPU, and ipu_bridge_connect_sensor() would then enumerate the same ACPI device twice and consume two of the four IPU ports. v4 therefore skips the generic entry when a specific one matches, as an order-independent filter in ipu_bridge_connect_sensors() rather than a rule about table ordering. Two other things you should know about v4: - Patch 3 now writes only bit 5 (clock-lane gate), not bit 5 + bit 2. Sakari asked whether IPU6 needed bit 2; it does not, and my sweep data agreed, so it is gone. It is also now set with cci_update_bits() rather than a full-register cci_write(): the ov5693 does not otherwise program MIPI_CTRL00, and since this driver serves IPU3/CIO2 and Rockchip too, touching the one bit leaves anything the platform left there intact. Because that changes behaviour I dropped your Reviewed-by from that patch rather than carry it. Happy to add it back if you are still content with the narrower write. Since v3 a linux-surface user also reproduced the value question independently on a Surface Pro 8 (Tiger Lake IPU6, INT33BE rather than OVTI5693) and got the one result I was missing: the vendor value with only bit 5 cleared does not stream, so bit 5 is necessary and not just sufficient. Details and the caveats in the cover letter. - Your Reviewed-by on v3 2/4 is carried forward unchanged onto v4 2/6, as that patch is untouched. Thank you for it. There is also a new no-op refactor as patch 4/6 (endpoint property indices assigned dynamically, per NEXT_PROPERTY() in mipi-disco-img.c). It turned out to fix a latent issue in my v3: because the property array is NULL-terminated, a conditional property at a fixed index would have been silently dropped for any sensor with nr_link_freqs == 0, INTC10C5 being the in-tree example. Thanks, Fernando