From: Lovekesh Solanki <lovekeshsolanki00@gmail.com>
To: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Michal Pecio <michal.pecio@gmail.com>,
Mathieu Fluhr <mathieu.fluhr@gmail.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Thorsten Leemhuis <regressions@leemhuis.info>,
regressions@lists.linux.dev, stable@vger.kernel.org,
Lovekesh Solanki <lovekeshsolanki00@gmail.com>
Subject: [PATCH 2/2] xhci: drop 120ms U3 LFPS wake retry wait from runtime resume
Date: Tue, 1 Sep 2026 00:33:49 +0530 [thread overview]
Message-ID: <20260831190349.29590-2-lovekeshsolanki00@gmail.com> (raw)
In-Reply-To: <20260831190349.29590-1-lovekeshsolanki00@gmail.com>
On auto resume (is_auto_resume), xhci_resume() used to msleep(120)
when there were suspended USB3 devices and no pending port event,
to give USB3 devices time to resend their U3 LFPS wake (at 100ms
intervals) if the first wake signalling failed.
The hub driver now holds the SS root hub awake for
USB_SS_ROOT_HUB_U0_WAKE_TIME (120ms) after a resume, which covers that
same window and lets the pending port event be picked up through the
normal hub event path. Therefore, this legacy wait in xhci_resume()
is redundant and can be removed.
Cc: stable@vger.kernel.org
Signed-off-by: Lovekesh Solanki <lovekeshsolanki00@gmail.com>
---
drivers/usb/host/xhci.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index a9e47e178c28..b0caba8ebf18 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -1083,7 +1083,6 @@ int xhci_resume(struct xhci_hcd *xhci, bool power_lost, bool is_auto_resume)
struct xhci_segment *seg;
int retval = 0;
bool pending_portevent = false;
- bool suspended_usb3_devs = false;
bool reset_registers = false;
if (!hcd->state)
@@ -1245,18 +1244,8 @@ int xhci_resume(struct xhci_hcd *xhci, bool power_lost, bool is_auto_resume)
/*
* Resume roothubs only if there are pending events.
- * USB 3 devices resend U3 LFPS wake after a 100ms delay if
- * the first wake signalling failed, give it that chance if
- * there are suspended USB 3 devices.
*/
- if (xhci->usb3_rhub.bus_state.suspended_ports || xhci->usb3_rhub.bus_state.bus_suspended)
- suspended_usb3_devs = true;
-
pending_portevent = xhci_pending_portevent(xhci);
- if (suspended_usb3_devs && !pending_portevent && is_auto_resume) {
- msleep(120);
- pending_portevent = xhci_pending_portevent(xhci);
- }
if (pending_portevent) {
if (xhci->shared_hcd)
--
2.55.0
next prev parent reply other threads:[~2026-08-31 19:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 19:03 [PATCH 1/2] usb: hub: use shorter 120ms post resume hold for SS root hubs Lovekesh Solanki
2026-08-31 19:03 ` Lovekesh Solanki [this message]
2026-09-01 12:53 ` [PATCH 2/2] xhci: drop 120ms U3 LFPS wake retry wait from runtime resume Mathias Nyman
2026-09-01 15:50 ` Lovekesh Solanki
2026-09-02 12:10 ` Mathias Nyman
2026-09-02 18:21 ` Lovekesh Solanki
2026-09-03 7:42 ` Mathias Nyman
2026-09-04 13:13 ` Lovekesh Solanki
2026-09-02 13:29 ` [PATCH 1/2] usb: hub: use shorter 120ms post resume hold for SS root hubs Mathias Nyman
2026-09-02 18:43 ` Lovekesh Solanki
2026-09-03 7:50 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831190349.29590-2-lovekeshsolanki00@gmail.com \
--to=lovekeshsolanki00@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mathias.nyman@linux.intel.com \
--cc=mathieu.fluhr@gmail.com \
--cc=michal.pecio@gmail.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®