From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 952C43AB47A for ; Mon, 31 Aug 2026 23:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788219180; cv=none; b=crpyQ5DgyifhTeUgse+2S+z6o0FlE73E/5OOID7UWYlqB2eW2friEk5egfWJh4qhbetmtnWi5haaidhQBsjSKUeKq4a+/Xal+8MQ4PcDHfaZF1JFwz0KQRJIrJAX1j/wGGZyejRwZJfsrnu4xzX/cdik35WwXN7V0ysFtM5kesQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788219180; c=relaxed/simple; bh=AoHlLmUVrv0UCPPJiNi0th1LWyobNOZqM6w5kHqkUGA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=czvVNwx6QddtUQDTvMVyz8EeY5bH08upS3YGfziAG1EIjdY3BvHtbb4RDHuezhHZnyjLFhqNjO7C/F3YcmjtFNIOJk4Lx16hAmagHFhWAwulzNMCc6RJ4uY0DQWwWLX7WbViCx4zLzu4yPdA43IsQsZWQBJdKB15e0RKUVyNyL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IbBGBvrO; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IbBGBvrO" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-cb2513ec378so511135a12.3 for ; Mon, 31 Aug 2026 16:32:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788219178; x=1788823978; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Oe/+b6soCrWQD2YEO2XBQ9XzBFUniWrh2jlWRQSn7jg=; b=IbBGBvrOSJy5vBhr6IO0GICD5yQAgJ9gQ3jYZ9xlc8eTD2eXtHh3yY72o+58uJF1Sa TILji0ot6YlVRHftEap9jGEEn74Zc4FlFq61ws6iOY/GZTL72RNj1FsSQpM+tVvvTKOS y4iSJV7wl/v7dx3Sy1Yp+mx8x2HmjPDDG+jdK7Ja/43jqhfW3lWzlqTihP8iUiLTd+Mm PtC5GYsIsgQK/qlQdDRGFfmCCObK8a7zKx1eMIL/5AD3dj3tuVKlfIdopyUukFWJ/Hd+ Q94viQU0c5hgrH77cI4h1zJI/49b5cRxC/8AcaU7oiLYnfeIcoE5J+iAM2HMFAm80LA9 BOWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788219178; x=1788823978; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Oe/+b6soCrWQD2YEO2XBQ9XzBFUniWrh2jlWRQSn7jg=; b=MlDV9liZkFCCkiP8yC4npRYyQiSflQzCErbsdKVoxmSp3zWojZf+6KRJtaqzZDoXl5 ix9IgQuXPPGZFOwy90t1vXm6d6R47xE3iD9eI/bv17HJxZdZO9Dk1gRmKO/HKGruuoB7 tbLNq90FrsuUQjX0f01rJLKy8e101z2o2tp5MSoGtcYa9dMT/+PNJj17QY00NBp/NLHE U/y+afAvQDUPMMvVbiN9KB2dyJ0en39gbaCZOwnld5k6WWa3mDDU0m9R6X4w7fjouGGB 5/w5Bx6DsDDVS8D5MmnPAdw5Nw3vimpSPsrPP4aILnmu0OvIYDwrxtBHe3KW2FGuFkoJ VpMA== X-Forwarded-Encrypted: i=1; AHgh+RoSQaVdJ0if6KGZwDJOS6nf3itd2NLLkk80LacIrk+MIx3aHu0ESgA/WeeW8N2g5TLrqzQenrm0WBSVsp8=@vger.kernel.org X-Gm-Message-State: AFuF++kX0Ba0nsUHKsw/tcqIuO+NoebBjWEYCZMUviH5bXbMY4R2HSxO GnXo5MxD85y15SYpBfzxc3j4rh7Yf3Ge/nsWmH6+3H2b/Oxx1W2N+PqR X-Gm-Gg: AR+sD11hrvf/hMaIRPlm8zOsVW+CYC0yQ6OaqjxN2L4VEEvVIVBm1COf5GOTWSrlSWj 4NG2mqJ80kIlxi5zet+eU4DCkNK6l+egwSoN3NCPscf1YpePtv8KV9TfjYp+JSfvcULtQE/dx4z h/72t5O3ju1/oKvSRsPao909G1mNRL8CqNo1QXls3xU6X67pkEyPO7pF5CuMk0MrOEq7qc4eUke Vz8UY0VOWLRrKkTBZfVvCHTs/sQn6lmuTeFrKA/t/yfc/3bo/OImPbxnpl0OQFZ7J1PPCUsxOKk q7N8It1XRFgORuTSUWqUb3w/EHNw208tjyKn/cXrJd3S8NLI1oguCFfUnCkZg+x55pkosXQ/APa bQyD5FRhBbqCpzIW6RumQ4I7TH0qKo1i7wGLJPHjq/+Qc4PHyMU2B9H31rYrirmMjauWWoFFgnD l0ZsVgr/WFgPRnQtqz0u+eaBvHrS06XdmKC5qS3+lSIOM2hly8eQtjm7NWS50tpwfk7Zmp3CI= X-Received: by 2002:a05:6a00:4449:b0:851:c2bd:43d1 with SMTP id d2e1a72fcca58-85628a85b9amr17918783b3a.1.1788219177621; Mon, 31 Aug 2026 16:32:57 -0700 (PDT) Received: from [10.60.78.252] ([2409:40c2:5002:4362:354a:8f21:7ceb:c8a6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-85be5ca747csm154393b3a.5.2026.08.31.16.32.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2026 16:32:56 -0700 (PDT) From: Bhargav Joshi Date: Tue, 01 Sep 2026 05:02:11 +0530 Subject: [PATCH v4 2/2] spi: dt-bindings: ti,davinci-spi: Convert to DT schema Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260901-ti-davinci-spi-v4-2-92e9c0b2e1d4@gmail.com> References: <20260901-ti-davinci-spi-v4-0-92e9c0b2e1d4@gmail.com> In-Reply-To: <20260901-ti-davinci-spi-v4-0-92e9c0b2e1d4@gmail.com> To: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Nishanth Menon , Santosh Shilimkar Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, goledhruva@gmail.com, m-chawdhry@ti.com, daniel.baluta@gmail.com, simona.toaca@nxp.com, j.bhargav.u@gmail.com X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788219139; l=9793; i=j.bhargav.u@gmail.com; h=from:subject:message-id; bh=AoHlLmUVrv0UCPPJiNi0th1LWyobNOZqM6w5kHqkUGA=; b=oN0aF37xkqWQ77+dtc3pNHFk+Lt7OJhSd5aVl2EXhCB1gPISphfMF7RK5YTESE9gEtwxsKG13 8chIjncM9KaBObhgfSUpcJOaSE1hJFrPqSawPdXcAN+WQA3ibfiyyKw X-Developer-Key: i=j.bhargav.u@gmail.com; a=ed25519; pk=IqNDwUZKECEA+n8wXctFLBbYL9NhFstZNbOznm/nX1k= Convert the TI DaVinci/Keystone SPI controller binding from text format to DT schema. Changes during the conversion: - Create a separate ti,davinci-spi-peripheral-props.yaml schema to properly define the ti,spi-wdelay peripheral property. - Add missing dmas and dma-names properties. - Add constraints to ti,spi-wdelay based on the 6-bit width of the SPIFMTn.WDELAY hardware register field. Reviewed-by: Rob Herring (Arm) Signed-off-by: Bhargav Joshi --- .../devicetree/bindings/spi/spi-davinci.txt | 100 ----------------- .../bindings/spi/spi-peripheral-props.yaml | 1 + .../spi/ti,davinci-spi-peripheral-props.yaml | 25 +++++ .../devicetree/bindings/spi/ti,davinci-spi.yaml | 124 +++++++++++++++++++++ 4 files changed, 150 insertions(+), 100 deletions(-) diff --git a/Documentation/devicetree/bindings/spi/spi-davinci.txt b/Documentation/devicetree/bindings/spi/spi-davinci.txt deleted file mode 100644 index f012888656ec..000000000000 --- a/Documentation/devicetree/bindings/spi/spi-davinci.txt +++ /dev/null @@ -1,100 +0,0 @@ -Davinci SPI controller device bindings - -Links on DM: -Keystone 2 - https://www.ti.com/lit/ug/sprugp2a/sprugp2a.pdf -dm644x - https://www.ti.com/lit/ug/sprue32a/sprue32a.pdf -OMAP-L138/da830 - http://www.ti.com/lit/ug/spruh77a/spruh77a.pdf - -Required properties: -- #address-cells: number of cells required to define a chip select - address on the SPI bus. Should be set to 1. -- #size-cells: should be zero. -- compatible: - - "ti,dm6441-spi" for SPI used similar to that on DM644x SoC family - - "ti,da830-spi" for SPI used similar to that on DA8xx SoC family - - "ti,keystone-spi" for SPI used similar to that on Keystone2 SoC - family -- reg: Offset and length of SPI controller register space -- num-cs: Number of chip selects. This includes internal as well as - GPIO chip selects. -- ti,davinci-spi-intr-line: interrupt line used to connect the SPI - IP to the interrupt controller within the SoC. Possible values - are 0 and 1. Manual says one of the two possible interrupt - lines can be tied to the interrupt controller. Set this - based on a specific SoC configuration. -- interrupts: interrupt number mapped to CPU. -- clocks: spi clk phandle - For 66AK2G this property should be set per binding, - Documentation/devicetree/bindings/clock/ti,sci-clk.yaml - -SoC-specific Required Properties: - -The following are mandatory properties for Keystone 2 66AK2G SoCs only: - -- power-domains: Should contain a phandle to a PM domain provider node - and an args specifier containing the SPI device id - value. This property is as per the binding, - -Optional: -- cs-gpios: gpio chip selects - For example to have 3 internal CS and 2 GPIO CS, user could define - cs-gpios = <0>, <0>, <0>, <&gpio1 30 0>, <&gpio1 31 0>; - where first three are internal CS and last two are GPIO CS. - -Optional properties for slave devices: -SPI slave nodes can contain the following properties. -Not all SPI Peripherals from Texas Instruments support this. -Please check SPI peripheral documentation for a device before using these. - -- ti,spi-wdelay : delay between transmission of words - (SPIFMTn.WDELAY, SPIDAT1.WDEL) must be specified in number of SPI module - clock periods. - - delay = WDELAY * SPI_module_clock_period + 2 * SPI_module_clock_period - -Below is timing diagram which shows functional meaning of -"ti,spi-wdelay" parameter. - - +-+ +-+ +-+ +-+ +-+ +-+ +-+ +-+ -SPI_CLK | | | | | | | | | | | | | | | | - +----------+ +-+ +-+ +-+ +-+ +---------------------------+ +-+ +-+ +- - -SPI_SOMI/SIMO+-----------------+ +----------- - +----------+ word1 +---------------------------+word2 - +-----------------+ +----------- - WDELAY - <--------------------------> - -Example of a NOR flash slave device (n25q032) connected to DaVinci -SPI controller device over the SPI bus. - -spi0:spi@20bf0000 { - #address-cells = <1>; - #size-cells = <0>; - compatible = "ti,dm6446-spi"; - reg = <0x20BF0000 0x1000>; - num-cs = <4>; - ti,davinci-spi-intr-line = <0>; - interrupts = <338>; - clocks = <&clkspi>; - - flash: flash@0 { - #address-cells = <1>; - #size-cells = <1>; - compatible = "st,m25p32"; - spi-max-frequency = <25000000>; - reg = <0>; - ti,spi-wdelay = <8>; - - partition@0 { - label = "u-boot-spl"; - reg = <0x0 0x80000>; - read-only; - }; - - partition@1 { - label = "test"; - reg = <0x80000 0x380000>; - }; - }; -}; diff --git a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml index 880a9f624566..cb5d608998e1 100644 --- a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml +++ b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml @@ -155,5 +155,6 @@ allOf: - $ref: fsl,dspi-peripheral-props.yaml# - $ref: samsung,spi-peripheral-props.yaml# - $ref: nvidia,tegra210-quad-peripheral-props.yaml# + - $ref: ti,davinci-spi-peripheral-props.yaml# additionalProperties: true diff --git a/Documentation/devicetree/bindings/spi/ti,davinci-spi-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/ti,davinci-spi-peripheral-props.yaml new file mode 100644 index 000000000000..1060f176c6cb --- /dev/null +++ b/Documentation/devicetree/bindings/spi/ti,davinci-spi-peripheral-props.yaml @@ -0,0 +1,25 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/ti,davinci-spi-peripheral-props.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI DaVinci/Keystone SPI Peripheral Properties + +maintainers: + - Bartosz Golaszewski + +description: + Peripheral-specific properties for SPI devices attached to a TI + DaVinci/Keystone SPI controller. + +properties: + ti,spi-wdelay: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 63 + description: + delay between transmission of words (SPIFMTn.WDELAY, SPIDAT1.WDEL) + must be specified in number of SPI module clock periods. + +additionalProperties: true diff --git a/Documentation/devicetree/bindings/spi/ti,davinci-spi.yaml b/Documentation/devicetree/bindings/spi/ti,davinci-spi.yaml new file mode 100644 index 000000000000..672d03d2492b --- /dev/null +++ b/Documentation/devicetree/bindings/spi/ti,davinci-spi.yaml @@ -0,0 +1,124 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/ti,davinci-spi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI DaVinci/Keystone SPI Controller + +maintainers: + - Bartosz Golaszewski + +properties: + compatible: + oneOf: + - enum: + - ti,da830-spi + - ti,keystone-spi + - ti,dm6441-spi + - items: + - const: ti,keystone-spi + - const: ti,dm6441-spi + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + power-domains: + maxItems: 1 + description: + Should contain a phandle to a PM domain provider node + and an args specifier containing the SPI device id + value. + + num-cs: + minimum: 1 + default: 1 + description: + Number of chip selects supported by the controller. This + includes both internal and GPIO chip selects. + + ti,davinci-spi-intr-line: + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [0, 1] + description: + Interrupt line used to connect the SPI IP to the interrupt + controller within the SoC. The SPI peripheral can route its + interrupt output to one of two lines (INT0 or INT1). Set + this based on the SoC-specific wiring to the interrupt + controller. + + dmas: + items: + - description: RX DMA channel + - description: TX DMA channel + + dma-names: + items: + - const: rx + - const: tx + + "#address-cells": + const: 1 + +required: + - compatible + - reg + - interrupts + - clocks + - ti,davinci-spi-intr-line + - num-cs + - "#address-cells" + - "#size-cells" + +allOf: + - $ref: spi-controller.yaml# + - if: + properties: + compatible: + const: ti,keystone-spi + then: + required: + - power-domains + +unevaluatedProperties: false + +examples: + - | + spi@20bf0000 { + compatible = "ti,keystone-spi", "ti,dm6441-spi"; + reg = <0x20bf0000 0x1000>; + num-cs = <4>; + ti,davinci-spi-intr-line = <0>; + interrupts = <338>; + clocks = <&clkspi>; + #address-cells = <1>; + #size-cells = <0>; + + flash@0 { + compatible = "jedec,spi-nor"; + spi-max-frequency = <25000000>; + reg = <0>; + ti,spi-wdelay = <8>; + }; + }; + + - | + spi@41000 { + compatible = "ti,da830-spi"; + reg = <0x41000 0x1000>; + num-cs = <6>; + ti,davinci-spi-intr-line = <1>; + interrupts = <20>; + dmas = <&edma0 14 0>, <&edma0 15 0>; + dma-names = "rx", "tx"; + clocks = <&psc0 4>; + power-domains = <&psc0 4>; + #address-cells = <1>; + #size-cells = <0>; + }; -- 2.55.0