Re: [PATCH v2] dt-bindings: hwmon: tmp102: Document TMP113

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2595 bytes --]

On Tue, Sep 01, 2026 at 06:09:20PM +0200, Marek Vasut wrote:
> The TMP113 temperature sensor part is register compatible with TMP102,
> document it using a fallback compatible. Unlike TMP102 and TMP110, the
> TMP113 does have additional unique ID registers, it is up to the driver
> to handle those.
> 
> Signed-off-by: Marek Vasut <marex@nabladev.com>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Flaviu Nistor <flaviu.nistor@gmail.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-hwmon@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> V2: Rebase on current next and resend, resolve a conflict with commit
>     d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")
>     Note that the TMP102,110,113 are backward compatible, therefore the
>     valid compatible strings are:
>     - "ti,tmp110", "ti,tmp102"
>     - "ti,tmp113", "ti,tmp102"
>     - "ti,tmp102"
>     The TMP103 is not backward compatible, it only shares bindings now,
>     therefore the only valid compatible string for the TMP103 should be:
>     - "ti,tmp103"
>     And that is all, no other compatible strings are acceptable here.
> ---
>  .../devicetree/bindings/hwmon/ti,tmp102.yaml          | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> index 55d9f106465d7..c0b747a9ce0de 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: TMP102/TMP103/TMP110 temperature sensor
> +title: TMP102/TMP103/TMP110/TMP113 temperature sensor
>  
>  maintainers:
>    - Krzysztof Kozlowski <krzk@kernel.org>
> @@ -13,11 +13,12 @@ properties:
>    compatible:
>      oneOf:
>        - items:
> +          - enum:
> +              - ti,tmp110
> +              - ti,tmp113
>            - const: ti,tmp102
> -          - const: ti,tmp103
> -          - const: ti,tmp110
> -      - enum:
> -          - ti,tmp102
> +      - const: ti,tmp102
> +      - const: ti,tmp103

Should this not be two patches, one fixing the existing stuff and one
adding the 113?

>  
>    interrupts:
>      maxItems: 1
> -- 
> 2.53.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]