From: Petr Vorel <pvorel@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>,
Joe Perches <joe@perches.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Cryolitia PukNgae <cryolitia@uniontech.com>
Subject: Re: [PATCH v4 0/3] checkpatch: userspace improvements
Date: Tue, 1 Sep 2026 08:17:22 +0200 [thread overview]
Message-ID: <20260901061722.GA804595@pevik> (raw)
In-Reply-To: <20260831205511.9bf609fc3d8c5ab98df2a1a5@linux-foundation.org>
Hi Andrew,
> On Mon, 10 Aug 2026 18:45:49 +0200 Petr Vorel <pvorel@suse.cz> wrote:
> > Changes v3->v4:
> > * Change test for directory to be more more generic (Joe)
> > * Allow to use --no-userspace (sashiko)
> Sashiko had a few more questions?
> https://sashiko.dev/#/patchset/20260810164552.1049483-1-pvorel@suse.cz
Thanks for a reminder. All are about kernel code being wrongly considered as user space.
At the beginning I was not sure if we need --no-userspace at all, but we
probably do for non-kernel projects which pass --userspace permanently via
configuration file.
1) The original regex was suggested by Joe and should mostly work, but using /
is indeed safer.
-m@^arch/.*\btools\b@
+m@^arch/.*/tools/@
2) my $userspace = 0 will indeed prevent --no-userspace from working as an
override. I did not considered this as important, but let's fix that.
3) return ($userspace || path based detection: dtto
=> v5
Kind regards,
Petr
prev parent reply other threads:[~2026-09-01 6:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 16:45 Petr Vorel
2026-08-10 16:45 ` [PATCH v4 1/3] checkpatch: Add more userspace directories to is_userspace() Petr Vorel
2026-08-10 16:45 ` [PATCH v4 2/3] checkpatch: Ignore <inttypes.h> format macros for userspace tools Petr Vorel
2026-08-10 16:45 ` [PATCH v4 3/3] checkpatch: Add new option to force userspace Petr Vorel
2026-09-01 3:55 ` [PATCH v4 0/3] checkpatch: userspace improvements Andrew Morton
2026-09-01 6:17 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901061722.GA804595@pevik \
--to=pvorel@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=cryolitia@uniontech.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®