From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11A7047988C for ; Tue, 1 Sep 2026 09:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788254011; cv=none; b=gZIJUFBQ6c7peMH5aNucEegkK5wqgpZ2MQmWs6iCS2uAttaS0dmlvqxYJNGnceMmEemUyJU7nYbyVfvqn7BvrVSPcVgedeEdJn2v3q2WolgJSMD5tvOD+sK++hl8YrK8wvo8+NJv4WCHcTjChWjJdCo33HGqNezwZ9r+2bLXobo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788254011; c=relaxed/simple; bh=wiy8pO7v9iI1/7qOJcZeis9iXMhYLOorLIS5PCg4eBE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=VMMmuK/j0tR25FWdm2p0aDQ54K9UGSgchmBPwsqXNqYkOkglR5a6pxFWOU4oXB3gocyrIeEl2DpDVPWXWKiMAjNggvd5+/9PpywPzPMStCVSD7a8jbCvJjC58QqIWw99oa1de1SQ3SNFbulvU8FRj51+1n1nz35DCrB6OIggOqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NPoU7h1V; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NPoU7h1V" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-48444eff835so91808f8f.3 for ; Tue, 01 Sep 2026 02:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788254006; x=1788858806; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=VTk2I9UAlwFcSdMLy483yatScQNtKnIT1avRSc59jAI=; b=NPoU7h1VFHs9yhF1P/3i7cfJt/00J2/eoUqyzFfqMk3K0POIMYTaxtODh0C6albeTo QgMlvgduPTmQgWJ1pIns+QXYKsqaK/n+NczhcRu5Yg1MoC9kSUz89MeysgKybHhVaSqA iBaySSBSnfTqRIjuwRjcc/GVtB5OQLWBiHjv4mcB7kXX31/GYhelcpirpJC46Hi0Wuob x2TxA5aGaQ/QZhPRLGcm+GcT9MyMsoDBhq8Jato07Fok2hZzGiqOkOvKmhzOdnyxprxp y0xgv+E+yT7k2+1RBWSukI7DlE5MQq6vcPQwJTmVdzJGOEK74PqQ9w62C22rhnq1ZjA3 MtUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788254006; x=1788858806; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VTk2I9UAlwFcSdMLy483yatScQNtKnIT1avRSc59jAI=; b=SzOhMAvcEov9sXoiaLFZYgn0nUEIYjXdB24rvQd53QXUmb8TNg6cp8Tc5fXenw7nvW EZf/2Y6dyiE4Do0sYDNGdQQeZIbG3yLTM6EaGIHirKZaLMtzWhL9Dv754aF6d2eRafq/ LYCTZwi3+qrlyXoshWaJU0wbv2F0hgOZYNiRkC2fdCayNKX+tTFhiz7ejBofrwdB9rJ2 HBrvUCCtJZv0BqIbL03SXThX2y0kv46u89QcXRn3bHacX4jjvSHzkD9WeFbdS4ucWibe yi4uKNOntxme8y38AuFaDVPa8DsxGPeJjUQnpzHdmz6DTIiioVFOecMglw/QoH6++Mnq Gwdw== X-Forwarded-Encrypted: i=1; AKwUvBwMd1ijEWhiWCY6pOZ6rRmTYJKpKWuRqptN+CG4z5Q91c1tLCVWTFakzRKHYnaguTPVHksIJFBdfFP3RRY=@vger.kernel.org X-Gm-Message-State: AFuF++kVmebLdXCEvudDhVuLAzLi8oulFvqKuYV8b2VEMwBWuCskJga8 +a2NZ39FrwVCvGb5MPesa/MokObnOOlQDVoI6U3ESpUDeGI69IQS02Sz X-Gm-Gg: AYBFou0Zg2TnVl7vtSFZ/5bZS8N9owRWwWIoU+wO2KaLr6abOpyyrNQTFHaP4xqnje4 OskktTI/WrZphdIOFAZcks6zfY4Drwxz+j45RezRFfEW8QtxN+jH9d5elFYhQNJlnwoJAfdRpPr cNVpzjulgQllqOGrvWoJuIGJN5TuUbYpcsfUB17pevnTA3R/p8bdcaLn+GG9gYcRcrTQmvgKjpK MbRQp6kMG4LNMtw4SwdV4dNSs/UDy8mT96zYeItscJEdBEWs2XJm0DYrEy7ddHXGTeT1bqiJQOb EQmk/trTsYOEUqyAcGtk2mH3pwrEtU7FODeQPPk4zsxSzmVEtht5ycwRe/nWmSIJEuz8jd7EfnQ MrCvFErGw25UZxu0hR/VaXoBh2lhmAHr3cCteFyXmZm20Iyv611qxsZGJFKoR2Gny690F1njTWV S1NtTtP/3Px/tuw5+JxVwZfbsESOkPoBuR8AXgRQlL5us4rpUnn9Q6OBnR5SeOrZVYTGPipA/mC rmzWYubUVO3lNV5fpvhBFHkj2i/JrDBtfzVXdQhh6aOEV5LiIbcFsISaqlfen2uCvZrWWi8rR+w qSEwTerAD1w3Y4PvNSxL13mK8+l6KbQeKKgYAMi7hQEWZ5jYUb0z4bEiFEfEpXM4W+Q= X-Received: by 2002:a05:6000:3106:b0:47f:8d71:210a with SMTP id ffacd0b85a97d-482f79cf4d0mr47047548f8f.15.1788254005998; Tue, 01 Sep 2026 02:13:25 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a02-3100-a16a-7801-fd8c-4b37-36b4-e53a.310.pool.telefonica.de. [2a02:3100:a16a:7801:fd8c:4b37:36b4:e53a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48442d781bcsm3378291f8f.26.2026.09.01.02.13.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 01 Sep 2026 02:13:25 -0700 (PDT) From: Karl Mehltretter To: stable@vger.kernel.org Cc: Karl Mehltretter , Greg Kroah-Hartman , Jaroslav Kysela , Takashi Iwai , =?UTF-8?q?C=C3=A1ssio=20Gabriel?= , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+8fa95c41eafbc9d2ff6f@syzkaller.appspotmail.com, Takashi Iwai , Sasha Levin Subject: [PATCH 6.1.y 2/2] ALSA: aloop: Fix peer runtime UAF during format-change stop Date: Tue, 1 Sep 2026 11:13:02 +0200 Message-Id: <20260901091302.66860-3-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20260901091302.66860-1-kmehltretter@gmail.com> References: <2026050445-connector-rebuff-f713@gregkh> <20260901091302.66860-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Cássio Gabriel [ Upstream commit e5c33cdc6f402eab8abd36ecf436b22c9d3a8aff ] loopback_check_format() may stop the capture side when playback starts with parameters that no longer match a running capture stream. Commit 826af7fa62e3 ("ALSA: aloop: Fix racy access at PCM trigger") moved the peer lookup under cable->lock, but the actual snd_pcm_stop() still runs after dropping that lock. A concurrent close can clear the capture entry from cable->streams[] and detach or free its runtime while the playback trigger path still holds a stale peer substream pointer. Keep a per-cable count of in-flight peer stops before dropping cable->lock, and make free_cable() wait for those stops before detaching the runtime. This preserves the existing behavior while making the peer runtime lifetime explicit. Reported-by: syzbot+8fa95c41eafbc9d2ff6f@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=8fa95c41eafbc9d2ff6f Fixes: 597603d615d2 ("ALSA: introduce the snd-aloop module for the PCM loopback") Cc: stable@vger.kernel.org Suggested-by: Takashi Iwai Signed-off-by: Cássio Gabriel Link: https://patch.msgid.link/20260424-alsa-aloop-peer-stop-uaf-v2-1-94e68101db8a@gmail.com Signed-off-by: Takashi Iwai [ used scoped_guard(spinlock_irq) instead of guard(spinlock_irq) ] Signed-off-by: Sasha Levin [ Karl Mehltretter: 6.12.y commit 03f52a9c1704 applies to 6.1.y/6.6.y unchanged; identical patch-id. ] Assisted-by: LLM Signed-off-by: Karl Mehltretter --- sound/drivers/aloop.c | 44 +++++++++++++++++++++++++++++-------------- 1 file changed, 30 insertions(+), 14 deletions(-) diff --git a/sound/drivers/aloop.c b/sound/drivers/aloop.c index 67bbadcec02b0..64870381d66ec 100644 --- a/sound/drivers/aloop.c +++ b/sound/drivers/aloop.c @@ -98,6 +98,9 @@ struct loopback_ops { struct loopback_cable { spinlock_t lock; struct loopback_pcm *streams[2]; + /* in-flight peer stops running outside cable->lock */ + atomic_t stop_count; + wait_queue_head_t stop_wait; struct snd_pcm_hardware hw; /* flags */ unsigned int valid; @@ -347,8 +350,11 @@ static int loopback_check_format(struct loopback_cable *cable, int stream) return 0; if (stream == SNDRV_PCM_STREAM_CAPTURE) return -EIO; - else if (cruntime->state == SNDRV_PCM_STATE_RUNNING) + else if (cruntime->state == SNDRV_PCM_STATE_RUNNING) { + /* close must not free the peer runtime below */ + atomic_inc(&cable->stop_count); stop_capture = true; + } } setup = get_setup(dpcm_play); @@ -371,8 +377,11 @@ static int loopback_check_format(struct loopback_cable *cable, int stream) } } - if (stop_capture) + if (stop_capture) { snd_pcm_stop(dpcm_capt->substream, SNDRV_PCM_STATE_DRAINING); + if (atomic_dec_and_test(&cable->stop_count)) + wake_up(&cable->stop_wait); + } return 0; } @@ -1004,24 +1013,29 @@ static void free_cable(struct snd_pcm_substream *substream) struct loopback *loopback = substream->private_data; int dev = get_cable_index(substream); struct loopback_cable *cable; + struct loopback_pcm *dpcm; + bool other_alive; cable = loopback->cables[substream->number][dev]; if (!cable) return; - if (cable->streams[!substream->stream]) { - /* other stream is still alive */ - spin_lock_irq(&cable->lock); - cable->streams[substream->stream] = NULL; - spin_unlock_irq(&cable->lock); - } else { - struct loopback_pcm *dpcm = substream->runtime->private_data; - if (cable->ops && cable->ops->close_cable && dpcm) - cable->ops->close_cable(dpcm); - /* free the cable */ - loopback->cables[substream->number][dev] = NULL; - kfree(cable); + scoped_guard(spinlock_irq, &cable->lock) { + cable->streams[substream->stream] = NULL; + other_alive = cable->streams[!substream->stream]; } + + /* Pair with the stop_count increment in loopback_check_format(). */ + wait_event(cable->stop_wait, !atomic_read(&cable->stop_count)); + if (other_alive) + return; + + dpcm = substream->runtime->private_data; + if (cable->ops && cable->ops->close_cable && dpcm) + cable->ops->close_cable(dpcm); + /* free the cable */ + loopback->cables[substream->number][dev] = NULL; + kfree(cable); } static int loopback_jiffies_timer_open(struct loopback_pcm *dpcm) @@ -1216,6 +1230,8 @@ static int loopback_open(struct snd_pcm_substream *substream) goto unlock; } spin_lock_init(&cable->lock); + atomic_set(&cable->stop_count, 0); + init_waitqueue_head(&cable->stop_wait); cable->hw = loopback_pcm_hardware; if (loopback->timer_source) cable->ops = &loopback_snd_timer_ops; -- 2.53.0