From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73D9047A895; Tue, 1 Sep 2026 09:26:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788254787; cv=none; b=hWfdYkfEjQGCBfLum3M1CPx7NAUqD26eCQHmd4xxVn0QyA4e9/+Xr818+g4GS5O/2Lnx0KqUDPmNfcaMBMAIkjq7YChG20Mt5y0Vy01G61n9iOpT9GnKM7QoCekkqsotI3tIERI1FpXoA9plEB2j958eNwedcPXvfLDuIq/4GR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788254787; c=relaxed/simple; bh=2ZJa10s5B8swPsDfg2S3YAMjoD1kSrH3mbZ5esnW5Gc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=beQA71VM8KtfiDZdEmt8F5ULXGJI31+/RzXFPJ4ojQxiwTz0OaJ7nwHdbZgDCWlx7GN42G5LMoyfiQXPhH0U+KRPVbV47zjyiwc53Zj4KRL/2fWGELq+18XuYUSits/65pwJG+GpfJaLvM4y5tVBT2RV0p13uK0vN/pKK8YOfKs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=iPYF385I; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="iPYF385I" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6817VY9x571761; Tue, 1 Sep 2026 09:26:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=xV5uxuK+OqQtUrop5OEhE1Ov9RkWif hVrlckzwzZjFY=; b=iPYF385IC+vCcd9WWwAA7KylYqvthnwLEYL3mqZQqR08Ac Mg8/xaiCR8CuI4nqQhWLjeUatMnmKW48GF3LD9zn+TeEFcAY9aRAkuStH5LBHQ1j Xm9TJ7J3+ytdTWOlasVRUxlINDUMrpc5b6geLeIr4ezaDOQOhme+nxKusfSW2r0f ahA/91PeXK2U5TSoHIY8PM/wLjNcbamRXdiXv+I80VtTCSoiCXaJ7fA8Y+EjU6E/ fhfzHAGRjkJVVP435nNBkq/b8LyhcUtqnYxoO53RsCb39vFHS83Y8PjKs5z3QKKk uJ1ft9YqYJioIjHzon5e3M6n5rAJbYfIJfaR+oyw== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gbq54pv5f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 01 Sep 2026 09:26:02 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 6819BIOD005036; Tue, 1 Sep 2026 09:26:00 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4gcark2w19-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 01 Sep 2026 09:26:00 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 6819Ps3537618120 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 1 Sep 2026 09:25:54 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 336602004B; Tue, 1 Sep 2026 09:25:54 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C864C20043; Tue, 1 Sep 2026 09:25:53 +0000 (GMT) Received: from osiris (unknown [9.224.76.185]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 1 Sep 2026 09:25:53 +0000 (GMT) Date: Tue, 1 Sep 2026 11:25:52 +0200 From: Steffen Eiden To: Marc Zyngier Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Alexander Gordeev , Andreas Grapentin , Arnd Bergmann , Catalin Marinas , Christian Borntraeger , Claudio Imbrenda , David Hildenbrand , Friedrich Welter , Fuad Tabba , Gautam Gala , Hariharan Mari , Heiko Carstens , Hendrik Brueckner , Ilya Leoshkevich , Janosch Frank , Joey Gouly , Nico Boehr , Nina Schoetterl-Glausch , Oliver Upton , Paolo Bonzini , Suzuki K Poulose , Sven Schnelle , Ulrich Weigand , Vasily Gorbik , Will Deacon , Zenghui Yu Subject: Re: [PATCH v2 03/20] arm64: sysreg: Define OSLSR_EL1_OSLK_MASK Message-ID: <20260901092552.231001-A-seiden@linux.ibm.com> References: <20260831145536.913567-1-seiden@linux.ibm.com> <20260831145536.913567-4-seiden@linux.ibm.com> <87v78pmmtz.wl-maz@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87v78pmmtz.wl-maz@kernel.org> X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAxMDA4MCBTYWx0ZWRfX8xslj0CEzrny I870zjdnuI65T0MuYtoOptYdzTMbteRcW+SxhEtSXVJyq+JKjL1e8xqpqJzbl8ta3JemDEbbxGZ FonFGGrB3t4IVuPmLFKqQV4be7v2CY5fZtn0qX2rZ7LKq8htSy04qEGwiuB2J/kYez7l5t15QBP IH5JpIPQ+NGVk1jfUjTu90FlP7BR0SuTFX89zbz8N/nXk5GPLFlEhqq/GOYe8gnkYZrau91y/iz f7rXrheByTG170YogC6v7SNbWytI5YtnP9voY7HkzFD1IJKokdeipktn+6twX4mWywhIxXLiINk SQGqdVg1zs0aDqDQSez0wdGGrPlQENN8SmewK58qLgt5RS8B1b0n8imqn+osaY5aPOMfILClJyz gMBS2LwIQff1/5+0Ca/rtvdFXcHnIPHHuIb8HZ60WlUM2ue/9iG85H6vVft3lRk38nHQ94GtB2k L/FEKcdsNpp4K5/Yl0g== X-Proofpoint-ORIG-GUID: I-mtpcS85hHB8dxIUUm3PzblhLWkM2jC X-Authority-Analysis: v=2.4 cv=CNgamxrD c=1 sm=1 tr=0 ts=6a969a2a cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=kj9zAlcOel0A:10 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VnNF1IyMAAAA:8 a=tb7DenZA0QQaIP_q4lIA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-GUID: LHOJJuwKv02WXCucgi7cBBp1KnMnc0PR X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAxMDA4MCBTYWx0ZWRfXwtM0K71xZrh6 2N3iuWstOoFIsy8FtxbkR+jF9480VaNirXdbLdtu4uNUhCO6AoadoKorhMXRTKja93QvI5rkFjQ qqSHwIkbMwWMwgqTkFqxoK5Av2Ms+T4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-01_02,2026-08-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609010080 On Tue, Sep 01, 2026 at 08:51:04AM +0100, Marc Zyngier wrote: > On Mon, 31 Aug 2026 15:55:18 +0100, > Steffen Eiden wrote: > > > > Define the missing mask for the OLSK field of OSLSR_EL1 which is > > required to safely write a value to that field. > > > > Signed-off-by: Steffen Eiden > > --- > > arch/arm64/include/asm/sysreg.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > > index 1c5c4df260be..5a439853b721 100644 > > --- a/arch/arm64/include/asm/sysreg.h > > +++ b/arch/arm64/include/asm/sysreg.h > > @@ -200,6 +200,7 @@ > > #define OSLSR_EL1_OSLM_NI 0 > > #define OSLSR_EL1_OSLM_IMPLEMENTED BIT(3) > > #define OSLSR_EL1_OSLK BIT(1) > > +#define OSLSR_EL1_OSLK_MASK BIT(1) > > Just move the required sysregs to the sysreg file, with the full bit > description. This will sort this once and for all. You mean to the tools/syreg file to generate the descriptions? I wanted to do that but OSLSR has a split field (OSLM in bit 3 and 0) which the generation tooling cannot handle. (right?) Now that I am rethinking this: I could move the stuff to the tools/sysregs and in addtion define the OSLM field here manually but this time using the generated constansts. probably sth. like: #define OSLSR_EL1_OSLM_MASK (OSLSR_EL1_OSLM0_MASK | OSLSR_EL1_OSLM3_MASK) #define OSLSR_EL1_OSLM_NI OSLSR_EL1_OSLM0_NI #define OSLSR_EL1_OSLM_IMPLEMENTED OSLSR_EL1_OSLM3_IMPLEMENTED Shall I do this? Steffen