From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ECE847D470 for ; Tue, 1 Sep 2026 13:20:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788268830; cv=none; b=qGAt4Crjy/qZNjIq4MixGc5enUN+PoRfSYbf9jph6/zk4lD2Nzx2qrPhQUDEoQPBzOlXq5ny8qx2wstnGKvSWDOWfQLzxuDwgjMQPYbCJk3y6bdKJvMPQLCFMBIf1iHPXSlGaZD4W0Gz5liVgCSrtBGS0+80VudmyJP3oI5cPKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788268830; c=relaxed/simple; bh=KDktPBIZnTUsCVqQrYT803wekYLhe+qbjOOKuzaIwfM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XX9DZ7NUFGdwc1rRpBaWZo4dvhAfvdHOy8qqKw/Hb4v0nmEhG0NNvQ16K6wki1OexGe1IdG7o83KRKpl/MVMB4QZZYSIc7zTowISJHAUUqwLFtk/UpyIIKlwwQJMyvs25H4hqjOWFIB2FUWlUU2nksGOhEeYYYGX7Sl3TRmENqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=i18dBmGz; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="i18dBmGz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1788268827; bh=KDktPBIZnTUsCVqQrYT803wekYLhe+qbjOOKuzaIwfM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=i18dBmGzXXVxRYTDuziHzl3/K6DoX7q3IM1PmHNqCt/H+mxvUHNgpLfXPXTNcUX9c kEfSCCWYYk3oEn8wL0lyC7aaV8QyBX4NMqevI9lob6eSiiXz4vSbb+T/PyR+hi1Wq1 SePkBU1sj6/Pn+huFEyYnSLnNf/9PKdlEUWdbP6qWKSKIYpHAf1BkXzrKIogVgwbzD /g+a03oUv6OqJdVtH9axaGMSk/7SXyb81YAaHkBJrgUgDwf+2VTf5PcZIm8OxNvmhE Bo5GfHkTFmEuKH4HgNBttRUxm8ABGAt4OZFiRDNZB+X/FxK29NTrInWmHFGf6vtQXo JlfcLR7QLZN8w== Received: from fedora-21.home (unknown [100.64.0.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 9E49B17E006A; Tue, 01 Sep 2026 15:20:26 +0200 (CEST) Date: Tue, 1 Sep 2026 15:20:22 +0200 From: Boris Brezillon To: =?UTF-8?B?QWRyacOhbg==?= Larumbe Cc: Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , Neil Armstrong Subject: Re: [PATCH v7 10/17] drm/panfrost: Add warning messages to fatal error conditions Message-ID: <20260901152022.69f3e969@fedora-21.home> In-Reply-To: <20260828-claude-fixes-v7-10-72a13b2c125d@collabora.com> References: <20260828-claude-fixes-v7-0-72a13b2c125d@collabora.com> <20260828-claude-fixes-v7-10-72a13b2c125d@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 28 Aug 2026 21:56:50 +0100 Adri=C3=A1n Larumbe wrote: > Rather than just failing silently, let's warn the user of device remove n= ot > being able to take an PM reference or the PM suspend path still reporting > inflight jobs. Neither situation should ever happen. >=20 > Signed-off-by: Adri=C3=A1n Larumbe Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/panfrost/panfrost_device.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm= /panfrost/panfrost_device.c > index 70c8109ea698..d8acae9b8cfa 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_device.c > +++ b/drivers/gpu/drm/panfrost/panfrost_device.c > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > =20 > #include "panfrost_device.h" > #include "panfrost_devfreq.h" > @@ -367,7 +368,7 @@ int panfrost_device_init(struct panfrost_device *pfde= v) > =20 > void panfrost_device_fini(struct panfrost_device *pfdev) > { > - pm_runtime_get_sync(pfdev->base.dev); > + drm_WARN_ON(&pfdev->base, pm_runtime_get_sync(pfdev->base.dev) < 0); > pm_runtime_dont_use_autosuspend(pfdev->base.dev); > pm_runtime_disable(pfdev->base.dev); > pm_runtime_put_noidle(pfdev->base.dev); > @@ -517,7 +518,7 @@ static int panfrost_device_runtime_suspend(struct dev= ice *dev) > { > struct panfrost_device *pfdev =3D dev_get_drvdata(dev); > =20 > - if (!panfrost_jm_is_idle(pfdev)) > + if (drm_WARN_ON(&pfdev->base, !panfrost_jm_is_idle(pfdev))) > return -EBUSY; > =20 > panfrost_device_disable_hw(pfdev); >=20